From: Joe Perches <joe@perches.com>
To: Jia He <hejianet@gmail.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, Jia He <jia.he@hxt-semitech.com>
Subject: Re: [PATCH] checkpatch: relax check for revert commit
Date: Mon, 09 Apr 2018 03:50:36 -0700 [thread overview]
Message-ID: <e5d59c005cdf0183b866fd24a012ccc35118f121.camel@perches.com> (raw)
In-Reply-To: <979a4ce5-2c68-6186-476c-1214aed2cdbc@gmail.com>
On Mon, 2018-04-09 at 14:37 +0800, Jia He wrote:
>
> On 4/9/2018 1:07 AM, Joe Perches Wrote:
> > On Sun, 2018-04-08 at 10:12 +0800, Jia He wrote:
> > > Hi Andy & Joe
> > >
> > > Although it is minor, it is a real bug, I thought.
> > >
> > > Is there any comment? Thank you
> >
> > If you really want to do something useful here,
> > quote the quote characters and compare for that.
> >
> >
>
> Hi Joe, thanks for the comments
> I am not sure I understand you comments here.
Change the tests to allow quote characters instead
of ignoring them.
To do this matching, any internal quote character in
the actual commit string and the commit string from the
patch must be perl quoted with \Q<string>\E so that the
expected title can be matched properly.
next prev parent reply other threads:[~2018-04-09 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 14:28 [PATCH] relax check regex " Jia He
2018-04-02 14:28 ` [PATCH] checkpatch: relax check " Jia He
2018-04-08 2:12 ` Jia He
2018-04-08 17:07 ` Joe Perches
2018-04-09 6:37 ` Jia He
2018-04-09 10:50 ` Joe Perches [this message]
2018-04-10 2:42 ` Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d59c005cdf0183b866fd24a012ccc35118f121.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=hejianet@gmail.com \
--cc=jia.he@hxt-semitech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®