From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9568130EF64 for ; Tue, 14 Apr 2026 18:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776190038; cv=none; b=qNAyKEeCYNSPckIQfS6/nMhhhDAKrcK6Mhe7QKfdcuA0W6cqkzGPwxpVnEXS/Oxyao6P+raICFyWrHylEW0C/IVwt6lsbeJ1MQAAUf/dIrqL9deJesPm+0JoTDcm33bLK/Oh/5/sFoWAe9f66SvCyk4S8ZLge5VlVg9qW59wkSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776190038; c=relaxed/simple; bh=eEb/lB1KUyn1kADF0Y41MtKSFWEswdFH9DeVlSb7mYM=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=u2CsVvegJ/DKyeaqUpcU10GHmjC2twphM36Vprv5M0zMI1DdgQ1xf5DLt0MAm+wTSQzFuH6Ahcw13k749L9KAyH4HL7X1qSZKaHzjcBBqRnv0IKFFtYOl3oHiGNuov9lp12UP+z2AQqQKbvOegOGCiwUc1ZjrYhiXpa6N2W7DyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GNNpeyB3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=TTQVMrP8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GNNpeyB3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="TTQVMrP8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776190036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eEb/lB1KUyn1kADF0Y41MtKSFWEswdFH9DeVlSb7mYM=; b=GNNpeyB3p1M3NkeTDJ+46EMSu3QHTs0zoTwlAxi34Ars3YB2UkuvxK3p02lJpXSJKCJjx0 dRShA4irQvdoJgyd3YMpNPx86PVttEDifc5eiGJsX7/yjDRoL/OUkepL8c2fbea4zZD2AQ cg7r9x0S3+wdAZuknDwZsKUFBiq3/8s= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-gxJIez7fOm-Au1wZc35yPg-1; Tue, 14 Apr 2026 14:07:15 -0400 X-MC-Unique: gxJIez7fOm-Au1wZc35yPg-1 X-Mimecast-MFC-AGG-ID: gxJIez7fOm-Au1wZc35yPg_1776190035 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8acb26fbbb2so12161536d6.2 for ; Tue, 14 Apr 2026 11:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776190035; x=1776794835; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eEb/lB1KUyn1kADF0Y41MtKSFWEswdFH9DeVlSb7mYM=; b=TTQVMrP8bX89lms7sMEbEP7A3jDjYNAqBBCVqH77qOXcUDdGVEa2mcahYQITrE9wwX LHjpTy7WmsjdXKS8HBR4PSj4EuHX+eBgHUNcaerjoNaDg0WyIKdN6JQk/RkyjCoUMnpA T9kmK6hx5qfkMR5US0UKEvVh8AtD6N3bDmJr+sZ25tXW2PQ4jz+slKD41ff3KtU88p7l X36hhUNHY2EX5Hc1qX8EclNdA09yg9m6gy/VAMsTlYe6aPe8/VoGYMHBHNgtDFXX0zNQ NsZ9JnPKP+VffhX+J3bfvjdjnrvaYmN02nXSj5v1TD34Hzjl71fISwQlOpRJhIOQeAA/ 6uYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776190035; x=1776794835; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eEb/lB1KUyn1kADF0Y41MtKSFWEswdFH9DeVlSb7mYM=; b=NRf8wg2elLYsed95pehKhLYqsHDFu7RVyIP6k3DQx4gdxhPS1Ibya8YbVE7vV67OUM yakNIsN9Ewvix3XQipjvUQQEljfblUcwR26NMNcVzevZrMi7USlbLFg/asm90Bj/mHmP /70Y23FOLOgfCMvTZljDdap88qcLBG0H2WHZZy0pd7pkT5J33EcuylJ5Cgu/IlMjT+Fl anPywUYeTuKI9YlekbIsvDvrsTClOSHlXb0cEsXAMeola38QdOQVKb9dffXlVPNiNOwN SYeD+lj/dWeON8d8gWw2jOwViWUedxqGKb258WKSRKHEhlQPYDD8FjZCUDMwSPuR/J2S NZsw== X-Forwarded-Encrypted: i=1; AFNElJ9t74C8lOX3WTiBqGF71AOjNYinSbHkqWiVzix3+NCtaaSzE7hBGPKqNV2NGvL1eZZ8gm5tLWERu+VOaLE=@vger.kernel.org X-Gm-Message-State: AOJu0YyDRWYJ0L+5U7kzUN4hs0yoxpYXFeqMcWPrSdVoFwr2dr9CUYtW SXwQmgEPBT2DlyiSVqSxpVmFbkhRzx5vlIpgVTXC217Yp6jBGxQ4ZnLXFMNWWjoZjvt1NF6B0Jm We+O8nhPHa+cdlgPwM4xoOP07jxPsVuSWs3ox/zvCBY2BLvHQ/vBT8R2tD2YJWT/F9BpH/Yfb3w == X-Gm-Gg: AeBDieveSifLdXdwF6GtDHVqITxjTkwi40QZDmjKQV6Pjs95lVZ1oNy94BDDvSOEb80 2UG0AEbzwl7mq9H/X7FQfu7DzM+MzzIzzF5GISG8vtwKIOjRjaX968B0ZraFw5IQ6IFNESiz3Yc zeJT5p7zRmLTvE8BZdBXAj5m9+jPGuLX/Dyji26pLGJpPTtsmN0b+hq8Dun2cOO73n968n6NmRa qUbuB9zxgO/YcS7ngjvYrmtXPJmYlTDpq4bVzqSIfgYRUpByUIGkT3Orh5Tu1eyapG+CWPdKVt/ psVzhc8g6G/8odWvYU0pK75tA7jsv+6EU7xSX0a8xs1LhNzpfOt6UPzIynGZaCs3G1kEMS+Z/oX SKmtezr2HRPPdpHWW/Tc6qzlxDzogJvXjpcT3uykFYnLZy5Kxp7DahQ== X-Received: by 2002:a05:6214:8008:b0:8a6:efd8:9b30 with SMTP id 6a1803df08f44-8ac860c661fmr259886476d6.6.1776190034790; Tue, 14 Apr 2026 11:07:14 -0700 (PDT) X-Received: by 2002:a05:6214:8008:b0:8a6:efd8:9b30 with SMTP id 6a1803df08f44-8ac860c661fmr259885826d6.6.1776190034183; Tue, 14 Apr 2026 11:07:14 -0700 (PDT) Received: from crwood-thinkpadp16vgen1.minnmso.csb ([2601:447:cc81:56d0:ab94:b2cb:29a6:7ac0]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac849e2891sm162232916d6.5.2026.04.14.11.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 11:07:13 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1] tools/rtla: Fix --dump-task option name to --dump-tasks From: Crystal Wood To: Costa Shulyupin , Steven Rostedt , Tomas Glozar , Wander Lairson Costa , Ivan Pravdin , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 14 Apr 2026 13:07:12 -0500 In-Reply-To: <20260414140621.28027-1-costa.shul@redhat.com> References: <20260414140621.28027-1-costa.shul@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-04-14 at 17:06 +0300, Costa Shulyupin wrote: > The option was inconsistently named --dump-task in the usage > string and getopt_long table while the actual implementation > uses --dump-tasks. Fix both occurrences to match. How is the getopt_long table not the "actual implementation"? Wouldn't it make more sense to fix the one place in the documentation that says --dump-tasks to match what the current behavior is? ...except that apparently timerlat top does use --dump-tasks[1], so maybe we want to make that consistent, but the changelog should be clear that this is an interface change for timerlat hist. We should also probably be making sure we have test coverage for both hist and top, which would have caught this, rather than picking one or the other for most tests. -Crystal [1] Oddly, timerlat_top.c is missing --dump-tasks from msg_start[], which is the one place that timerlat_hist.c has the plural --dump-tasks.