From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0E33A1691; Tue, 24 Mar 2026 17:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774373959; cv=none; b=sD2xbzc76KZ55Wg0bXwUG2nEjejXSadj5yZdnLlQv6pw+al7H901ujA5WWxvTqx/WlBhiU2OZ5/oRhhfQCDzBJrHQdAtdKYqMsXqNL/38OcYBqSJeCeEmGYJ25m5r6HHOzvPOj1QiU/lYwFS8i8lPcWC5nQVEgpyf4Eb0nFK3MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774373959; c=relaxed/simple; bh=xU/WyK7McpXWdO+9gz1Fv5LxGOl6yL1ITwyb79CIAHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KyWeEQys0wlzb11Fzk8JoNGnLBs/UxhtZVvP5/ayntFQUGdpkO+oK2sJfpy8XUFil9gjz8PYDiPjca7MfGvZIiKOf0uNzAyjuQypTeZcWvHfs1ChJl9yZKk6PAwhSbC99wz7dkvqnxxp0+KCpu+KFJooYOIxhu99+8prijYDIzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=IVfk07uk; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="IVfk07uk" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9886F112113; Tue, 24 Mar 2026 18:39:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1774373954; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=f/JtUAW8GMSlEGiFymjy5UUqojkB5rvdVEFyaDuZCyA=; b=IVfk07uk/ynDHxds/NRsCk3rHM3TbSBSIOTj/IqLvbEz9cyuAO144EmuDtwORQW1zsNVxW rmNoWq9YmK80G3NdDLO7FbGf/FljjqwSPCRhdJMk3VyJCFXZ6BcJe3sDHYOPYB03GNPEHv Eiq542aYV+NqmjD6j3BZuScr/0mbOZmCx53FhUQ2LbEgzojWBTxzeHBcE69xFvSeqtlPe5 IBBvAVDx+7Jdv1xn6bpiREYhkPuMS5tIuDPwg1lTyGe6I1XQO2DjrcaQWlm6xnFoo02+Cq dJ0CCD6fjki60dIA3qzlV9i68+aPL7tRjE4uaT7hWj2f2+BEqBnPRwlQdeGu3Q== Message-ID: Date: Tue, 24 Mar 2026 18:39:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: imx8mp: Add DT overlays for DH i.MX8M Plus DHCOM SoM and boards To: Frank Li Cc: linux-arm-kernel@lists.infradead.org, Christoph Niedermaier , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , devicetree@vger.kernel.org, imx@lists.linux.dev, kernel@dh-electronics.com, linux-kernel@vger.kernel.org References: <20260312232500.197096-1-marex@nabladev.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 3/24/26 5:01 PM, Frank Li wrote: > On Fri, Mar 13, 2026 at 12:24:04AM +0100, Marek Vasut wrote: > ... > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi >> new file mode 100644 >> index 0000000000000..534737363c9f0 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi >> @@ -0,0 +1,42 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (C) 2022 Marek Vasut > > 2026? That was the original copyright year when this was implemented, but I can update it to 2022-2026 ? >> + */ >> + >> +&display_bl { >> + pwms = <&pwm1 0 5000000 0>; >> +}; >> + >> +&DH_OVERLAY_PANEL_I2C_BUS { > > why upcase for label, generally it should be lower case Because this label is really a macro , please read on. >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + touchscreen@41 { >> + compatible = "ilitek,ili251x"; >> + pinctrl-0 = ; >> + pinctrl-names = "default"; >> + reg = <0x41>; > > reg should second property, please dt-format for new dts files. > check others What is "dt-format" ? Linux kernel source tree, even current next, does not mention such a tool . I did run schema check and checkpatch on these patches. obv. >> + interrupt-parent = <&DH_OVERLAY_PANEL_I2C_TOUCHSCREEN_IRQ_PARENT>; > ... >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@1 { >> + reg = <1>; > > need empty line between child node and property. Fixed in V2 >> + #size-cells = <0>; >> + >> + eeprom@56 { >> + compatible = "atmel,24c04"; >> + reg = <0x56>; >> + pagesize = <16>; >> + }; >> +}; >> + >> +&ecspi2 { >> + status = "okay"; > > status should be last property. I stop here because these > should be identify by tools/script Neither checkpatch nor schema validation complained about these. I moved the status=okay to the end. Anything else I should update ?