From: Markus Elfring <Markus.Elfring@web.de>
To: linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Amol Maheshwari <amahesh@qti.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cong Liu <liucong2@kylinos.cn>, Kunwu Chan <chentao@kylinos.cn>
Subject: [PATCH] misc: fastrpc: Use memdup_user() rather than duplicating its implementation
Date: Sun, 28 Jan 2024 15:35:19 +0100 [thread overview]
Message-ID: <e5d9404d-eb3b-4d35-a027-790229986cdf@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 28 Jan 2024 15:17:03 +0100
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
Generated by: scripts/coccinelle/api/memdup_user.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/misc/fastrpc.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 1c6c62a7f7f5..83da6ad4e541 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1260,17 +1260,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
goto err;
}
- name = kzalloc(init.namelen, GFP_KERNEL);
- if (!name) {
- err = -ENOMEM;
+ name = memdup_user(init.name, init.namelen);
+ if (IS_ERR(name) {
+ err = PTR_ERR(name);
goto err;
}
- if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.namelen)) {
- err = -EFAULT;
- goto err_name;
- }
-
if (!fl->cctx->remote_heap) {
err = fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,
&fl->cctx->remote_heap);
--
2.43.0
next reply other threads:[~2024-01-28 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 14:35 Markus Elfring [this message]
2024-01-29 14:42 ` [PATCH v2] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d9404d-eb3b-4d35-a027-790229986cdf@web.de \
--to=markus.elfring@web.de \
--cc=amahesh@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=chentao@kylinos.cn \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liucong2@kylinos.cn \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®