From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAF5C43460 for ; Wed, 19 May 2021 15:42:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58F496124C for ; Wed, 19 May 2021 15:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354945AbhESPn5 (ORCPT ); Wed, 19 May 2021 11:43:57 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34792 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242076AbhESPnz (ORCPT ); Wed, 19 May 2021 11:43:55 -0400 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ljOLD-0005oO-3i for linux-kernel@vger.kernel.org; Wed, 19 May 2021 15:42:35 +0000 Received: by mail-qk1-f199.google.com with SMTP id 78-20020a3703510000b02903a5be8eaaadso1991510qkd.11 for ; Wed, 19 May 2021 08:42:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y58HNIGfyjO1NHrX6PUICkpjj0HsKsC4MLHocdrJRYk=; b=KtWxNKrJbM/u9vprpb3RhSKk+30WbuszzwcbbyOdYK3js/ENSl8qonfVwQK/0dSK8r HQQhNYOOf3PiaCcw9fEK3beGtwidW+sU4T4HxtxYuf9yUz+yCgXo4URM9S7ZLKeMmEYg Y6g+ekDTGhuPflKSWHjijgCSEo553Q7xh2iMERtOKaNbA/ZNSq5na5aXSBzeG4FaEHBt 6N033taZE/nhAocukqIM+RiuZtr7oLGfLoDSqyc0G1nb/pNWaFpzWwBEkFgkBvPMhxG5 xHBONuAr//ni09q6Nw4shUiZErrPSN60tCdwGrE97TAR1APs9C4wQwemLnSjP2jhCLcM 6Ssg== X-Gm-Message-State: AOAM531vyrztN2SvkBwowcWLyGFp81RsXrAP/o5hsn4BAod3Z2pULKq7 6ejO5N4AOv4S3rnrfkm4OfODU3zGfXB0FK1KKcp3KhFBwLQKfuP0ZZgqOCi8fI4UdC5xCoJPKnL eMF0jXB9AGEZWQj/xi5Fgdk9TzRiy2CSQTZ+aloo7Sw== X-Received: by 2002:a05:6214:148a:: with SMTP id bn10mr54285qvb.40.1621438954267; Wed, 19 May 2021 08:42:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM3qJR3wRrIB8QCZlm0Kqj1eQyfF0OiKakSDAmRtrZDGKvkzveVMOvfO4jeZ8NFVcIbMF/dw== X-Received: by 2002:a05:6214:148a:: with SMTP id bn10mr54270qvb.40.1621438954117; Wed, 19 May 2021 08:42:34 -0700 (PDT) Received: from [192.168.1.4] ([45.237.48.3]) by smtp.gmail.com with ESMTPSA id h2sm22576qkf.106.2021.05.19.08.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 08:42:33 -0700 (PDT) Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation To: David Hildenbrand , Andrew Morton , Akinobu Mita , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Vlastimil Babka , Michal Hocko , "Rafael J . Wysocki" , Andrea Righi , Guilherme Piccoli References: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 19 May 2021 11:42:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/2021 11:30, David Hildenbrand wrote: > On 19.05.21 17:28, Krzysztof Kozlowski wrote: >> The documentation of DEBUG_PAGEALLOC states that it cannot be used with >> hibernation, however the Kconfig entry would allow it if >> ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC. >> >> Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix") >> Signed-off-by: Krzysztof Kozlowski >> --- >> mm/Kconfig.debug | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug >> index 1e73717802f8..0ace5b2a9d04 100644 >> --- a/mm/Kconfig.debug >> +++ b/mm/Kconfig.debug >> @@ -11,7 +11,7 @@ config PAGE_EXTENSION >> config DEBUG_PAGEALLOC >> bool "Debug page memory allocations" >> depends on DEBUG_KERNEL >> - depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC >> + depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC >> select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC >> help >> Unmap pages from the kernel linear mapping after free_pages(). >> > > I remember this should be working now, as we temporarily map the pages > in the direct map when hibernating? Let me actually test it on x86_64... Best regards, Krzysztof