From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71057C433F5 for ; Mon, 10 Oct 2022 21:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiJJVvg (ORCPT ); Mon, 10 Oct 2022 17:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiJJVve (ORCPT ); Mon, 10 Oct 2022 17:51:34 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 281D251400 for ; Mon, 10 Oct 2022 14:51:33 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C42B25C010C; Mon, 10 Oct 2022 17:51:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 10 Oct 2022 17:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1665438690; x= 1665525090; bh=rpBVhQk5UAQBeLz9Wj9al8x+/KWr2QPTJzXQc8qVA3Y=; b=H 1MMxhne69iw66AdXtMiewZX4q90l8HAGeTWeIOvfjlrL7RLDMv0fT+njsF4KrEnG NCBm9IBdjAJ/VxPS/eqiUz9vVdOya8eN3SoOE/vLrsEz5yDnZ/ht/GWA7zoPJkYI gWcTWyYecYfRcQ4Nj0zsUXIqBzF1aRgW9nc10RQm5ewrIwdZiyEDHqlp4dJJN+8C 0KDuRj7wFSzjkCNCNAI6AeW3l0uDPSYXK4gX/W1pTTFQ6kPn3vQGYelmcZ4wBxFc 1bz6H74VTdx/DCiLlp0wXUlLwoUGcUqtK5rSWjyLFSB5nSU02ef76w+v6Bgl0QRV hSSEnUpL5qXz+TrWTeLtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665438690; x= 1665525090; bh=rpBVhQk5UAQBeLz9Wj9al8x+/KWr2QPTJzXQc8qVA3Y=; b=M I/DX6XAVtlo+vMeCQlHDN9gN/BkKLNTXTj5RLSoFq7aVjVsz5h8deP8CUZGD9pvO 8FEfsmcdMWYiuHde5Y5oP3tjttT7AovpaauWFD+k/J+3oCfp9BJP3zK7h+Rm4OMB f28jCIFLxZRGaUcYQLnU72TbffI4zydMWmfGFU2HWq3W36qfbzZYJBwqGL7ntaQ5 FuwiA9MKWoaBxfvXWbBXMFoOkrlw9kBmX73EAPWP/WKRlforOiu7SYOCIlobIZO8 0oy9Q8lraOwyqzDQ6Sj/c+w4SiMvkVM2ycEfwhe4Cvyw+74HUBQDQL7s90F0I1p0 BB6coXjDfGw/OG8BDQG5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvveffjghftgfgfgggsehtqhertddtreejnecuhfhrohhmpefnuhhk vgculfhonhgvshcuoehluhhkvgeslhhjohhnvghsrdguvghvqeenucggtffrrghtthgvrh hnpeekfeffueejveeujeeugeelleehtdegvdeludektddtfffhieefledvudehfeejieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehluhhkvg eslhhjohhnvghsrdguvghv X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Oct 2022 17:51:26 -0400 (EDT) Message-ID: Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack") From: Luke Jones To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, perex@perex.cz Date: Tue, 11 Oct 2022 10:50:29 +1300 In-Reply-To: <87zge3etjw.wl-tiwai@suse.de> References: <20221010065702.35190-1-luke@ljones.dev> <87zge3etjw.wl-tiwai@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 (by Flathub.org)) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-10-10 at 14:45 +0200, Takashi Iwai wrote: > On Mon, 10 Oct 2022 08:57:02 +0200, > Luke D. Jones wrote: > >=20 > > The initial fix for ASUS G533Z was based on faulty information. > > This > > fixes the pincfg to values that have been verified with no existing > > module options or other hacks enabled. > >=20 > > Enables headphone jack, and 5.1 surround. > >=20 > > Signed-off-by: Luke D. Jones >=20 > The changes look OK, but the subject line should be rather describing > what about the patch is about.=C2=A0 I corrected the subject and put the > proper Fixes tag (as well as Cc-to-stable). >=20 > Also, the indent level wasn't right, so I corrected it locally, too. Oh... Sorry about the hassle there, I could have sworn it was correct. Thanks for accepting regardless :) >=20 > thanks, >=20 > Takashi