From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD9C19AD89 for ; Wed, 2 Jul 2025 11:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456640; cv=none; b=oRWv3oPOnkHwZM4GC3o0+d4KkYFd1BEWaQ8hnTV9tn73SDnNA7V7sI316yXdqtmLLJNqjHwyihivqt9OdtM4y5l+SKj3fwzJiKXfQ8UAHVf1EDp7dr9D0TdddqKARvhEWc1FoiCZrcG4Sfm+ISJrmLyMHJ1pH7hcPTYeZM9lTdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456640; c=relaxed/simple; bh=lQ5pOB3PF0Ozj2m53e3VhTH0wmfKLgTVASK5lMyhgEI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QQL8M5soEmakm35PhuSteWghkKj50pKGp4sCjRCIHCW3QbzWfOyj5O6cND4fCDNeg+aTIrSy9Gmc4anbPe1bn6ORE9P9IKreiPpTkXkmRnWa9MmNFC0kJIWJ2zWelOaZsgM2Oas95swAVDLH/88ggKUh3fEC6gb3jTGjnhKOPB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AxQxCQFa; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AxQxCQFa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751456635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dwvTGYy8qX0iUTJggFcHacmEi3yRTYRCFkLK9Jl7i5c=; b=AxQxCQFaMcL4SWlU5G+tMrrZRuPhtj1geNlTc8XoTc9kRqU5gdNeT/E1mlGAQNzqVsFtum 4U17YTxGICr5ccaqyd1l5p0nkdkIz6kRjPVsqKD8iSon25i6dYjlllb01PrgzvCjOIk8xG uEIXE+CeIVhuVHDn/QYfVamcC27gokc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-b07H8pFiO_mvNmbmdKQTUw-1; Wed, 02 Jul 2025 07:43:51 -0400 X-MC-Unique: b07H8pFiO_mvNmbmdKQTUw-1 X-Mimecast-MFC-AGG-ID: b07H8pFiO_mvNmbmdKQTUw_1751456627 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 852EF18011FE; Wed, 2 Jul 2025 11:43:46 +0000 (UTC) Received: from [10.45.226.95] (unknown [10.45.226.95]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A0E02195608F; Wed, 2 Jul 2025 11:43:39 +0000 (UTC) Message-ID: Date: Wed, 2 Jul 2025 13:43:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v12 07/14] dpll: zl3073x: Add clock_id field To: Jiri Pirko Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Jason Gunthorpe , Shannon Nelson , Dave Jiang , Jonathan Cameron , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Michal Schmidt , Petr Oros References: <20250629191049.64398-1-ivecera@redhat.com> <20250629191049.64398-8-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 02. 07. 25 12:31 odp., Jiri Pirko wrote: > Sun, Jun 29, 2025 at 09:10:42PM +0200, ivecera@redhat.com wrote: >> Add .clock_id to zl3073x_dev structure that will be used by later >> commits introducing DPLL feature. The clock ID is required for DPLL >> device registration. >> >> To generate this ID, use chip ID read during device initialization. >> In case where multiple zl3073x based chips are present, the chip ID >> is shifted and lower bits are filled by an unique value - using >> the I2C device address for I2C connections and the chip-select value >> for SPI connections. > > You say that multiple chips may have the same chip ID? How is that > possible? Isn't it supposed to be unique? > I understand clock ID to be invariant regardless where you plug your > device. When you construct it from i2c address, sounds wrong. The chip id is not like serial number but it is like device id under PCI. So if you will have multiple chips with this chip id you have to distinguish somehow between them, this is the reason why I2C address is added into the final value. Anyway this device does not have any attribute that corresponds to clock id (as per our previous discussion) and it will be better to NOT require clock id from DPLL core side. Ivan