From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7830C34FF71 for ; Fri, 30 Jan 2026 09:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766230; cv=none; b=TZktzjMn7zgDAqx43iL89sc00uGbh0CgHYjuvxx8MQ91D6SUkroCy3SwwUTUyfC4SAXxz7ieG1+7+vcHDnMSB32r4+dfx7v6monQtu/zPhBwPufDs3BXBWfZHlDd2AWH20GbwE9QSzeN+XJzqYXc8nE13qVudCYO9h1gS6ngPyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766230; c=relaxed/simple; bh=8nBohHh4B1JistrSLUe+ybhsXh3+QyKVS/BB/3QK+1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RgnBeiY2f38hKG0o2thlsENVxT5IOXD/R8dPz85R3TCSqoJgmvnr11+vQ5jUSp6xmJ9XFxXcZxdu91rIBRHcdsWAFRt820lY0mw0qUHtpzY4Tgo8c7Y8yBj85JX//Eot5iipEnKIAVb2z3AiIGQmqO7yT3pizKwS/Kh3BuUdCP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oVkpAs+t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e7s7u6mc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oVkpAs+t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e7s7u6mc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U4tOMB2294948 for ; Fri, 30 Jan 2026 09:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= arNaou7UElK3kr0918LpPz/GUPVT1/KgI0TILUNW3OE=; b=oVkpAs+t0jSfRhlT n5AbivMEM7GFy3AQeh1owMxN7LAa13TkjHYD80Ruj72TVPHc5Q3WLzH0Ed6zTXOm Mr9xN51lkvtbnmRjgO3fvlJ6Lv06W7FQDKTC0G9wROOGEHPnHRHfk8IyfCB/zfxZ +gCAf5E4ly0r3ka+NWJYq3/BIQW/BrXhZ3OGm3yxPvzu9SJlEcYgaQinqLfI5Rpg RyvDEMn5bKrOlordtihxAIN2igQCe4FoKyHiaOON4p1f+Jn5V6BaHp5GF4XOAcLh iPds9OyBj21HarL2SIrmgX45NvnEwpAgepgmIwaruBFyoys5sW3adxdyOymJ6KKG 0Kkwzw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0p1x8sv6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 09:43:48 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8888ae5976aso1835526d6.2 for ; Fri, 30 Jan 2026 01:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769766228; x=1770371028; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=arNaou7UElK3kr0918LpPz/GUPVT1/KgI0TILUNW3OE=; b=e7s7u6mckBzUXVWb69M/5Ecy5u0K6DEc7l/FsuSLDwTos4FVZggaE/4toW08qpeHa9 F18ujmmLw0sU3WnivvrbYVhrl8/inrxohspzzMELXLTPdL7BXC6MS3qmz8Fq1vJ0Vb7S 2OLpnfV/lEzCq6h54H983+G5w8C3eVOl4eJ7QBkYDBbHQv3WiQapyCHmzt55sMumeNnS nrHPR1f3dBGG+Se6q6M2fJO3YI27ephhHuK+2GMibcSCqJj0QCs1N62K8ptYYV3OfR5I NQV3qwv949K832ChjDtTIHnV/gz/iSxs+KIEOUXr5oB4wkGyZuWFQ9agfataiV5SMqFh sxtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769766228; x=1770371028; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=arNaou7UElK3kr0918LpPz/GUPVT1/KgI0TILUNW3OE=; b=cL3WUbiDSttzmBTJrKhI4fFvOmXWAazdVzZ0/mFyRniLKEAT8J94ALxUfDMuy63fhp vCxvfwVIT/YARRg8v4Iulf9WW42F+a0tJcdlpnqZOz58WHUDD+smJGat1UWRRBYdUXKM xVQqObq5l+ARJFs84oRDpCWNPtR3vGH5qHHv3M+/7l2ENfY3A6q+8OJj9kjZb5p0mVTI A4iCmAgCFDGMjNJv1Of0DySY/ypd2WIGk02GIuRn8rNHWHnxLgljNeSCPXUT8scjjKJE VkWON70OJACASfUcLNwFWxPSHcD7GG3fJn304/tehuafBrzag1eBT4P+8izq0yQPJnsb SM8w== X-Forwarded-Encrypted: i=1; AJvYcCVqclQgDFAdWZWgoz1NMzg+NmggFoBpHojMHgqaO3Up3+m9k+kl5ZCvQL53SI7c/Lh3pv+lrEYSVcKaRbI=@vger.kernel.org X-Gm-Message-State: AOJu0YxpnZrxo2X0pRAcQCBIFoVBU/5F3LTJ4LF/mlOZKCa2AYD+Og3k luw7i1/4vMXSSL9GcadKiu6lEZmLdRkrc5iwFc4BwIzPkk3llQWUPdMX9edf95569fSEjgTV5za rzfG6Tn7PbpxuePaTbG9SMoSpuGTqox1mTOQHN7OsH9/h7H+/6UieW/JFXpccZnFGTqo= X-Gm-Gg: AZuq6aIOmfvWalJaPPmQccJxHWya3Ch7VkGOV8yaN77KEOqIwHQLUzy1lsl5gj0H6WK SjGAsOQ8Evkvn86of63cFlIfTqCdVTTQm/i+2hUZlwj8ZDAS+YpZ/5aBR2E7/mAljo8NVuYJXGv H6gM4wNsAWjyWAw9B4//1SUDPRA81R4n31kLQfs+GtNIsKTnMIORUIKZKX6qkpmwlnrQt+ZI7EK XLyZWDM+8nPYe0OS2Q0KhCU2NAE/GnRAi4CVy+OvRUDPX+LgfkM/1NWmytiTgefAD6cd0X963U0 8qm5idlIsfqxet8lBXWo0GX6E16zt/L54TwH1CC/t3ejDGI89kugtNGLAYqxX6ZGpgHvEOgoy33 oYU9DKlJMyGrwv/HR8Fhxw5quPHBKHD4Vui1V9b6UDXgiT6suc6en3z2I+tdoubrOu70= X-Received: by 2002:a05:6214:8086:b0:894:de0a:4cf1 with SMTP id 6a1803df08f44-894ea18f0b8mr21353546d6.8.1769766227827; Fri, 30 Jan 2026 01:43:47 -0800 (PST) X-Received: by 2002:a05:6214:8086:b0:894:de0a:4cf1 with SMTP id 6a1803df08f44-894ea18f0b8mr21353466d6.8.1769766227455; Fri, 30 Jan 2026 01:43:47 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b42563dbsm4094058a12.3.2026.01.30.01.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 01:43:46 -0800 (PST) Message-ID: Date: Fri, 30 Jan 2026 10:43:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] clk: qcom: Add TCSR clock driver for Eliza To: Abel Vesa Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luca Weiss , Taniya Das , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127-eliza-clocks-v2-0-ccee9438b5c8@oss.qualcomm.com> <20260127-eliza-clocks-v2-6-ccee9438b5c8@oss.qualcomm.com> <44k56h4yjjknc5xnwlrmlpgj2hpf6rvdsv7fhrhb4qnzsz7goi@o6qz7im62kg3> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <44k56h4yjjknc5xnwlrmlpgj2hpf6rvdsv7fhrhb4qnzsz7goi@o6qz7im62kg3> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -mn3TPgsR-nu95uAIb2sC09cNku_XQ6f X-Proofpoint-ORIG-GUID: -mn3TPgsR-nu95uAIb2sC09cNku_XQ6f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA3NSBTYWx0ZWRfXzHTJGTw8UXBr VR3xLo8NcXkrR6kq3TuTuqN6fESXGunYSVovL3wfKUwzWopoDS8Xk0tOFGHC1Qwi//svHFJruGh qzewEFwYQLZ7AHP/PhcIvvVMbiBtkNsYKHjQfu4FXtL6WR9vD1fnm3/NUxQWY6FoeUOjvJ/qsGf jwzh2cZ12WawzTcTlYBjyiTusqirLnA2IftId/W0swRVfLJfbjVCtokYGBKTh8yigdwb3idvww7 nJ+t1BSzInqzwJEmfEdXDwSGiNu8DnQ3rWRqechPtFvLRgKSLBtI+EAjMLwX3UwVyudOGGwUsRN 1lEBkxIaKTiRrDythSloWP3hm90t+OceAdoWBi2phyMfRlvD8SunSXjq61z3YgTyaAFWtGHiw5U tqynRat7b98az3FR3EQ+SZwwu9O9RqKinmuWpGhVR7XHlC3F8MfquTMxs1PgtMaKUTa5rQIC+0A jS/P/fC0PVZk5AtGvrQ== X-Authority-Analysis: v=2.4 cv=G5cR0tk5 c=1 sm=1 tr=0 ts=697c7d54 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=AKt-FI4Am6_hGqfKY9QA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300075 On 1/28/26 3:10 PM, Abel Vesa wrote: > On 26-01-28 11:34:49, Konrad Dybcio wrote: >> On 1/27/26 4:03 PM, Abel Vesa wrote: >>> Add the TCSR clock controller that provides the refclks on Eliza >>> platform for PCIe, USB and UFS subsystems. >>> >>> Co-developed-by: Taniya Das >>> Signed-off-by: Taniya Das >>> Signed-off-by: Abel Vesa >>> --- >> >> [...] >> >>> +++ b/drivers/clk/qcom/tcsrcc-eliza.c >>> @@ -0,0 +1,144 @@ >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/* >>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +#include "clk-branch.h" >>> +#include "clk-regmap.h" >>> +#include "common.h" >>> + >>> +enum { >>> + DT_BI_TCXO_PAD, >>> +}; >>> + >>> +static struct clk_branch tcsr_pcie_0_clkref_en = { >>> + .halt_reg = 0x0, >> >> These regs certainly aren't at +0x0 to what we normally expect to >> be the start of the TCSR node > > They are if we add the TCSR node with reg range starting at 0x1fbf000. "if we take the wrong base, the wrong offset is right" ;) The docs for Eliza don't have the nice separation like on e.g. Hamoa, but 0x01fc0000 is what we generally agreed upon to be "tcsr". The registers that first appear in that region are the same as on Hamoa, and so is the address, so let's continue that tradition Konrad