mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Nicholas Mc Guire <hofrat@osadl.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Rob Herring <robh@kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: zynq: do not allow kmalloc failure
Date: Wed, 21 Nov 2018 13:01:28 +0100	[thread overview]
Message-ID: <e5e7b0be-8d45-ec7a-618d-8248a41e2361@xilinx.com> (raw)
In-Reply-To: <1542795390-16221-1-git-send-email-hofrat@osadl.org>

On 21. 11. 18 11:16, Nicholas Mc Guire wrote:
>  The kmalloc here is small (< 16 bytes) and occurs during initialization

no reason for space in front of "The"

> during system startup here (can not be built as module) thus if this
> kmalloc failed it is an indication of something more serious going on
> and it is fine to hang the system here rather than cause some harder
> to understand error by dereferencing NULL.
> 
>  Explicitly checking would not make that much sense here as the only

ditto.

> possible reaction would be would BUG() here anyway.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> 
> Problem located with experimental coccinelle script
> 
> Patch was compile tested with: multi_v7_defconfig (implies
> CONFIG_ARCH_ZYNQ=y)
> 
> Patch is against 4.20-rc3 (localversion-next is next-20181121)

I have no problem with the patch but things below your SoB shouldn't
land in the git history.

When this is fixed feel free to add my
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

      reply	other threads:[~2018-11-21 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 10:16 Nicholas Mc Guire
2018-11-21 12:01 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5e7b0be-8d45-ec7a-618d-8248a41e2361@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=hofrat@osadl.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®