From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD1524EAB3 for ; Tue, 29 Apr 2025 02:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745893522; cv=none; b=E5YZpf4mHhN6jvDB1Ptm1Si8Dx9o8bXOGHze9kfitI1S3+d4Rqk5VBZbY7Tk0uIpU6JbOq1l30qBYWLBS8HgNBEydUHDRXczPQVTSA4OahhDMMGrW3ufGAq/ikibxZyCs/1z2PVwxOaYHyIhqRBpZSop8ETcpZKCPXkKfDxUK3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745893522; c=relaxed/simple; bh=JSqQK3eTz30bWSYni3gWxQC52G7BCzb9ke/8+uRJ68I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HuJ2WVvrm4BohAKbDuEmRo2EA4O9CHDbna6XaTWZZTA6tue62WFIlNxhsmn5vbTwVdTs3Q+zeeVxhKyeauSYndqS8RXfi2B2b5u0yCYwxzcrRrPrmQcWigRuHz31Ro3+eZJxpUzb2P2Msecp+H3lF1qg4FODRucD3XG1h4GZVN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=kPoMLQLn; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="kPoMLQLn" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso62242075e9.3 for ; Mon, 28 Apr 2025 19:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1745893519; x=1746498319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=logGtVu+7IT0r/51fYLuRIbXnsRggGmi2FqqOlrz5h4=; b=kPoMLQLnIpTkib1Pr3UvxWHLC8byRWkLf/pPOGEKxZhRYvWGkhzKDTfjXoiQ3fNgVX pDkfA6HahX/5sX8NznPvlMcmB9qH0KZKqVD8a+sfnd5Dg72QZAwlpc65gi75fvVRVnCn F6BHRr5OkdvvyM7al4VfQLnaYHJmja2DrRHTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745893519; x=1746498319; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=logGtVu+7IT0r/51fYLuRIbXnsRggGmi2FqqOlrz5h4=; b=NDjgmv5lieyY2z6uoIlliyEKXx98+/6fHOl2d72v1LSoKAkSVWODHGFVp7/sGpVbKJ cnOrnLt5f3qQqzGOpXKECqroMh25nmwtvXmhPNCjKZ8GDm+5SMbkz9w2wKU7G0huygm7 Clm0h2H5yAe1HPpo11MZsH/nsvJw3914mge7K3clEaIjib52FCp/RFmmQtfmHlGgHs8o IEpIzdE29hl9oe4xOUSifMtauXJ9lnmWVpvgMco8pPiCYuMb4dJmGObZvbJ723uEhmBo /yNew8puSb82tgOOJOLryFdCD6esEll+Hz0Up2z+227a41T7eIjrz+kn6LdlRgf4xn9C j0Pw== X-Forwarded-Encrypted: i=1; AJvYcCUh6nGZa2evko2ECJr7/weff2QXye9OXaPROhkHd6pyvfAcaP5VufpdtHFwHmp7AcFQc7czcD1gSCi9Xd4=@vger.kernel.org X-Gm-Message-State: AOJu0YwApWBsjTTu3a9hETHRJN5gWmXGigZ9vQ0uhbASj0ApPUv+UOSn lwsOasByA0h7J4KtF8tQrAXou7AiDwH8ZvEISyBXTzplZSHIlOVR+DdusgMHZa0= X-Gm-Gg: ASbGncvz4fxQGfiLju2krrwdMADNvyarqxPiRB4+hVMPW0eQlbdKcTckLfs8VKrRvOL HoMrgDH6PquXEm5j4u6uTXz4EV64Q1+YNa9Y2L/NStOpB7NwBgJo94sgL1wr9lE11G2dRNTp19q euV1GBKSNgQzENDp0uW/BT2sMarO6rNWVP7M2Vv0zNlhsEDtV863w3arUrYN78fFrogRMF7d7vU Ndz9AmLBuh28Kub4hSK2zBfoIA3W+TEHq+l5AHIty5dUWEdheooKOB7h8y8pcANj57569XXE/kd a81XHVTcLt3hHK2xSRS5efOXj89qUjuUNJ3rS9pxzFDUojnJBCJMTEm8MJb2RgbGXIQjs255gnv oFZx/mQ== X-Google-Smtp-Source: AGHT+IFiy/yhIU/mxQaqPdQVeUobhwf07A5N4rQG91TwFqvD7lyrojMQY0WpnRjmIrNN+QjB0m4YYQ== X-Received: by 2002:a05:600c:4fd0:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-441ac84b469mr9380965e9.7.1745893518863; Mon, 28 Apr 2025 19:25:18 -0700 (PDT) Received: from [192.168.1.183] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2abf73sm172928625e9.20.2025.04.28.19.25.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 19:25:18 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 03:25:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bitops/32: Convert variable_ffs() and fls() zero-case handling to C To: "H. Peter Anvin" , Linus Torvalds , Ingo Molnar Cc: Arnd Bergmann , Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Juergen Gross , Boris Ostrovsky , Alexander Usyskin , Greg Kroah-Hartman , =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= , Mike Rapoport , Ard Biesheuvel , Peter Zijlstra , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20250425141740.734030-1-arnd@kernel.org> <67be5eee-b67b-409a-8309-829f891b9944@citrix.com> <916BD58C-E6A7-495E-9A60-722E130AC7A7@zytor.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <916BD58C-E6A7-495E-9A60-722E130AC7A7@zytor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/04/2025 3:00 am, H. Peter Anvin wrote: > On April 28, 2025 5:12:13 PM PDT, Andrew Cooper wrote: >> On 28/04/2025 10:38 pm, H. Peter Anvin wrote: >>> On April 28, 2025 9:14:45 AM PDT, Linus Torvalds wrote: >>>> On Mon, 28 Apr 2025 at 00:05, Ingo Molnar wrote: >>>>> And once we remove 486, I think we can do the optimization below to >>>>> just assume the output doesn't get clobbered by BS*L in the zero-case, >>>>> right? >>>> We probably can't, because who knows what "Pentium" CPU's are out there. >>>> >>>> Or even if Pentium really does get it right. I doubt we have any >>>> developers with an original Pentium around. >>>> >>>> So just leave the "we don't know what the CPU result is for zero" >>>> unless we get some kind of official confirmation. >>>> >>>> Linus >>> If anyone knows for sure, it is probably Christian Ludloff. However, there was a *huge* tightening of the formal ISA when the i686 was introduced (family=6) and I really believe this was part of it. >>> >>> I also really don't trust that family=5 really means conforms to undocumented P5 behavior, e.g. for Quark. >> https://www.sandpile.org/x86/flags.htm >> >> That's a lot of "can't even characterise the result" in the P5. >> >> Looking at P4 column, that is clearly what the latest SDM has >> retroactively declared to be architectural. >> >> ~Andrew > Yes, but it wasn't about flags here. > > Now, question: can we just use __builtin_*() for these? I think gcc should always generate inline code for these on x86. Yes it does generate inline code.  https://godbolt.org/z/M45oo5rqT GCC does it branchlessly, but cannot optimise based on context. Clang can optimise based on context, except the 0 case it seems. Moving to -march=i686 causes both GCC and Clang to switch to CMOV and create branchless code, but is still GCC still can't optimise out the CMOV based on context. ~Andrew