From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531643B6C1E for ; Fri, 20 Mar 2026 15:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774020280; cv=none; b=myqcZjOja8mtIExlOPdNAwGGGP6sPofjl6iO5lYOk5t/sOIRK2v1v0LtvUcEC2BBtWmWX0tkzJ/Na/nHYfWNXtCpOtY7kPUuaxLCKhxJ1x5yTzxT2rS1i7OAdl306BfVNnZpCbF/eOCo3GxewCCMvGLNytN28V4qPjckPTOfCKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774020280; c=relaxed/simple; bh=1uUWbAfjhQKGsekiHalIN3wkJj3mxEEBjAHougA6NbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X79D6VQgr5utUiF0fgqUmW3aYsB7w2oP6kjZkuTy3cUbub76hnThaAcZwu5WWYyzTsWYJS1gv/g+0Tm6RQJZrohZwxz6nC025MslHVxckPTCzkcHKKbysQ5qaScnz9LaB3a+wFZ7yPwhxHVbGj8lyeTirh5NkpQAwegqofBH9Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rpHpAdXH; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rpHpAdXH" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so15390035e9.1 for ; Fri, 20 Mar 2026 08:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774020278; x=1774625078; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EGuAgDtSJcuttCP6aHyWnJnRrzDxd6vKtX0ipXN9Dgo=; b=rpHpAdXH55b27GtYFM02oUpbQYUX469RBhm9tX8PCevng+6acrEtSge84WdQvJWbKr 1BYHZiANoz+d78VO7fgy21jGLgjBmKUh/6ND486tR1t+aGfF4ksuOEGYw/1g3CNxXi2N GG7GeHAasVmHXOJZHWDdSMtL+yZnPT66dmFb4sgBKdrPaq5VqDqznoKUy/yAeKGsSb4L tf1c/xhgYGmR+BSu7qlesId9pkMhOqhpmaUowtEJlAu4qpZWYM6vr9wBfQim20hXY+yg zcAEMKO/m7BhBs0lXOcFuemNwI41xwXmLJ9g+L60zftWEImu0f5Ajfc2yIVsYl9tDxSj 1y6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774020278; x=1774625078; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EGuAgDtSJcuttCP6aHyWnJnRrzDxd6vKtX0ipXN9Dgo=; b=hZxYP5pSp1mu8TW+GiQ/y9udgOwPO9tOptF+dAwDf7TpDQxMwHwveTegFhOUEP2Vua rtsJd04M3HujCwJ2IxQMJbQXJDCWPnedPsvzuGTwDRbKmYY32qp1r2A9aj2A7FaTGNFZ J8jMLSaCXI2zhCy2cj/dnjX/CY6bfCgWhKfsCNvawEj1f5TUchQoPIA5W0ghVXl/StnB x9Ga4nOPpBXKGLb7eQsUH4cjbV0xM80su1XurwaSCC0emv+jwfcI1VlP3nlkjVavkltv Q99Oh13YUH18f1J1TXLFrVncaClBGepCDnjtLp92KFKdpjXDN0xBAWwd1oxMNID16YeA d+Wg== X-Forwarded-Encrypted: i=1; AJvYcCUSqOMeReEvzv/kW4piqx21ZHnfUXOe/0Ha7FvGgW7gwmkhwEqTURVyXP2QDbWJ7igEStEZy3KKxdnE28A=@vger.kernel.org X-Gm-Message-State: AOJu0YyYSr0j0H1HFKgeBr9Mc1iG2B94OnEDUokMGLc0bS+XJznvIQ4n obv4y3JXzsjqYQ2lFJyC/rDrJMniLNlx/ULw0TR5cQDhxZuTkrmnZNf6goY7y3myZkk= X-Gm-Gg: ATEYQzxrnGdtPdrYFTcAjtGZrAxdl0kPuT9pkQ/4wSnVJODeZoLOPp1yaB/+sW2eRli sW+VIPuCSjUjDkjqlQlA5P8odU46D7zFdA9OXbVSHwVlPtSTldo8yRBvtg5EEnZEjHMr4D9m9Cv FfH2oxsrwCgkZqwlJPxIXxENTaK5ixD+HTL1j5IrDiu4Z64XFEPixenh2OJfkqqjhdm3OlNd/BJ Ak0HDMeh9MOaVsthP9EXn3IYlJdL8JDJ1be9ByYOGgHv3n07V6KvIdalvwoz6EhHaODgk1QD8PC OnvbZlJtnyyFNMvRK8UOBRfXAHU4Xs9hX4KzgcRE33qkozakLFvsBi+x5gKpdJhIijdyY5Pyepa 45Aiz7RKenP0ZS8VbLn8N6RR9YKjtGEEHThfb85OYplcLkV0q0WmYnowHH/AY+cxsxmYASauGkU pAuDwMoGh1/Q2sBLtLEmQwz7S5keScDGcnWRrS7H3XdN3kQ4M= X-Received: by 2002:a05:600d:8449:b0:477:9890:9ab8 with SMTP id 5b1f17b1804b1-486fe8a2bafmr46366735e9.3.1774020277489; Fri, 20 Mar 2026 08:24:37 -0700 (PDT) Received: from [192.168.0.167] ([109.76.207.215]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff1e6029sm33334055e9.9.2026.03.20.08.24.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Mar 2026 08:24:36 -0700 (PDT) Message-ID: Date: Fri, 20 Mar 2026 15:24:35 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: avoid format string warning To: Arnd Bergmann , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Nathan Chancellor , Hans Verkuil Cc: Arnd Bergmann , Vladimir Zapolskiy , Nick Desaulniers , Bill Wendling , Justin Stitt , Hans Verkuil , Vincent Knecht , Wenmeng Liu , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20260320151828.3456863-1-arnd@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260320151828.3456863-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/03/2026 15:18, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang-22 warns about csiphy_match_clock_name() taking a variable format > string that is not checked against the 'int index' argument: > > drivers/media/platform/qcom/camss/camss-csiphy.c:566:44: error: diagnostic behavior may be improved by > adding the 'format(printf, 2, 3)' attribute to the declaration of 'csiphy_match_clock_name' > [-Werror,-Wmissing-format-attribute] > 561 | static bool csiphy_match_clock_name(const char *clock_name, const char *format, > | __attribute__((format(printf, 2, 3))) > 562 | int index) > 563 | { > 564 | char name[16]; /* csiphyXXX_timer\0 */ > 565 | > 566 | snprintf(name, sizeof(name), format, index); > | ^ > drivers/media/platform/qcom/camss/camss-csiphy.c:561:13: note: 'csiphy_match_clock_name' declared here > 561 | static bool csiphy_match_clock_name(const char *clock_name, const char *format, > | ^ > > Change the function to use a snprintf() style format string that allows this > to be checked at the call site. > > Fixes: 0727615fb975 ("media: qcom: camss: Functionally decompose CSIPHY clock lookups") > Signed-off-by: Arnd Bergmann > --- > drivers/media/platform/qcom/camss/camss-csiphy.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c > index 62623393f414..78a1b568dbae 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -558,12 +558,16 @@ static int csiphy_init_formats(struct v4l2_subdev *sd, > return csiphy_set_format(sd, fh ? fh->state : NULL, &format); > } > > -static bool csiphy_match_clock_name(const char *clock_name, const char *format, > - int index) > +static bool __printf(2, 3) > +csiphy_match_clock_name(const char *clock_name, const char *format, ...) > { > char name[16]; /* csiphyXXX_timer\0 */ > + va_list args; > + > + va_start(args, format); > + vsnprintf(name, sizeof(name), format, args); > + va_end(args); > > - snprintf(name, sizeof(name), format, index); > return !strcmp(clock_name, name); > } > Reviewed-by: Bryan O'Donoghue