From: Alan Stern <stern@rowland.harvard.edu>
To: "Chary Chennoju, Srikanth" <srikanth.chary-chennoju@amd.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Thinh.Nguyen@synopsys.com" <Thinh.Nguyen@synopsys.com>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"Chris.Wulff@biamp.com" <Chris.Wulff@biamp.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kalluri, Punnaiah Choudary" <punnaiah.choudary.kalluri@amd.com>
Subject: Re: [PATCH 2/3] usb: gadget: f_sourcesink support for maxburst for bulk transfers
Date: Mon, 7 Jul 2025 09:45:15 -0400 [thread overview]
Message-ID: <e5f4942f-4a0d-44a6-a2b2-7d567d4d0ddc@rowland.harvard.edu> (raw)
In-Reply-To: <CH3PR12MB872633800DDD386DCE8169B6B14FA@CH3PR12MB8726.namprd12.prod.outlook.com>
On Mon, Jul 07, 2025 at 10:49:26AM +0000, Chary Chennoju, Srikanth wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Stern,
>
> Thanks for your comments. If you are mentioning to have a check for the value which user is providing, then there is a check which is carried out(#34 to #37 in the patch). It limits to max burst value if user exceeds the supported value.
> > > + /*
> > > + * Fill in the SS bulk descriptors from the module parameters.
> > > + * We assume that the user knows what they are doing and won't
> > > + * give parameters that their UDC doesn't support.
> > > + */
In that case this comment is wrong, isn't it? You don't assume that the
user knows what they are doing; you do check and limit the value to
maxburst if the user's value is too big.
Alan Stern
next prev parent reply other threads:[~2025-07-07 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 11:40 [PATCH 0/3] Add support for Superspeed plus EndPoint for Bulk and Isochronous transfers Srikanth Chary Chennoju
2025-07-04 11:40 ` [PATCH 1/3] usb:gadget:zero: support for super speed plus Srikanth Chary Chennoju
2025-07-04 12:04 ` Greg KH
2025-07-07 10:41 ` Chary Chennoju, Srikanth
2025-08-11 15:35 ` Chary Chennoju, Srikanth
2025-08-11 15:58 ` Greg KH
2025-07-04 11:40 ` [PATCH 2/3] usb: gadget: f_sourcesink support for maxburst for bulk transfers Srikanth Chary Chennoju
2025-07-04 13:47 ` Alan Stern
2025-07-07 10:49 ` Chary Chennoju, Srikanth
2025-07-07 13:45 ` Alan Stern [this message]
2025-07-07 14:01 ` Chary Chennoju, Srikanth
2025-08-11 15:36 ` Chary Chennoju, Srikanth
2025-08-11 16:10 ` Alan Stern
2025-07-04 11:40 ` [PATCH 3/3] usb: gadget: f_sourcesink: Addition of SSP endpoint companion for Isochronous transfers Srikanth Chary Chennoju
2025-07-04 12:03 ` Greg KH
2025-07-07 10:38 ` Chary Chennoju, Srikanth
2025-08-11 15:37 ` Chary Chennoju, Srikanth
2025-07-05 3:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f4942f-4a0d-44a6-a2b2-7d567d4d0ddc@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Chris.Wulff@biamp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=punnaiah.choudary.kalluri@amd.com \
--cc=srikanth.chary-chennoju@amd.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®