From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D867C77B7C for ; Fri, 5 May 2023 18:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233001AbjEEStC (ORCPT ); Fri, 5 May 2023 14:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233274AbjEESs5 (ORCPT ); Fri, 5 May 2023 14:48:57 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D50C51891B for ; Fri, 5 May 2023 11:48:55 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4eff055d4d3so2397597e87.3 for ; Fri, 05 May 2023 11:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683312534; x=1685904534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Crh9fzWfq0MD2HA/mWuy3AwSn4MclmdJjDjdEYt9apw=; b=A3BA8gulgqhSMKGoMnA/WTu7e+p1LZh7rNN2V7J17ajT8yI4vic/7rfTY7kHU5eFBe TDtDz1GwFXdZ3Yi+jQhQ0aF7GBzhnj7OthbB058Zc0v9fTU9UlP/QRBvE7HO1cLJLXBE GOZ1D19yuRtlmxowcHUdD8Q9n+mmX8l/28UoM6F4AV3DhCCMWoMeUAScn9GlsQV5K9d8 /YnF13t958XSrfgzxJ2OgJBN/FmIM2TiOFYjyezG19sR1Q8XcAoXE9zx/NtMBkaWcB13 H0/MF7TbtrZSBjobqxoh9xGdZ/xGI/uMtuavMD6ccjIXQv8gkiZAS6Td3oFjtmhVm192 LCYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683312534; x=1685904534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Crh9fzWfq0MD2HA/mWuy3AwSn4MclmdJjDjdEYt9apw=; b=XPB3NimwzO4hZp+yi+jQBbPLpTk3KSqCntpr4IPNIxBZjULQLuBYf2kGXSdFgePRoT W4Ky7nDpJ87qzmVTEpyzuYOKIOV8gBheZIYathN5gJ8BlBXWuD7OcLtajdu9osxPWJEf PbLo9iL0NocBpLwZaJTGGc7WEvR7orc879lCDZjlMHeWGDlLAWfKo1J68ETJg+8sQPeW GcpmR4fR6kS13O8dCfHpq7dla4rjhlPxK1qdt8q7eQujbn4UCvpDl/Svkdp/nyN1+zqW 2XAB1/9z7c0f/vvSC4G1lQr4IIp9UH7ubcXVjb+rkANKs4Slt5MZlytvQMusdHNzlL5p Fxlg== X-Gm-Message-State: AC+VfDzOfbQ3neKfw5gveMbzWR4hPMBEfN1xETlh6gyPoTnJ2ispageL IHsR7sh7gDYg6cZmCwyZGWlWOJH3I17868vubZY= X-Google-Smtp-Source: ACHHUZ6MB/ZRbiqb+rRR2yJknH8iVNHvoAF46WGJlP3+1O3Eo9MBQbKqyXrbrAEzStwB9WURN0hvvg== X-Received: by 2002:a19:f702:0:b0:4f0:c18:5114 with SMTP id z2-20020a19f702000000b004f00c185114mr883037lfe.26.1683312534123; Fri, 05 May 2023 11:48:54 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id i12-20020ac25d2c000000b004e887fd71acsm376929lfb.236.2023.05.05.11.48.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 11:48:53 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 20:48:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 02/18] media: venus: hfi_venus: Write to VIDC_CTRL_INIT after unmasking interrupts Content-Language: en-US To: Vikash Garodia , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Bryan O'Donoghue , Mansur Alisha Shaik , Jonathan Marek , Hans Verkuil , Dikshita Agarwal Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , stable@vger.kernel.org References: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> <20230228-topic-venus-v2-2-d95d14949c79@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5.05.2023 14:33, Vikash Garodia wrote: > > On 5/4/2023 1:30 PM, Konrad Dybcio wrote: >> The downstream driver signals the hardware to be enabled only after the >> interrupts are unmasked, which... makes sense. Follow suit. > > Rephrase the commit text, > > 1. No need to mention downstream driver, if something is buggy, fix it. Generally I'd agree, however in this specific case the downstream driver is the only available source of knowledge about what the correct (or at least working) initialization sequence of this hw block is. > > 2. Avoid "..." and lets make it more formal. Ack Konrad > >> Cc: stable@vger.kernel.org # v4.12+ >> Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files") >> Signed-off-by: Konrad Dybcio >> --- >>   drivers/media/platform/qcom/venus/hfi_venus.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c >> index bff435abd59b..8fc8f46dc390 100644 >> --- a/drivers/media/platform/qcom/venus/hfi_venus.c >> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c >> @@ -453,7 +453,6 @@ static int venus_boot_core(struct venus_hfi_device *hdev) >>       void __iomem *wrapper_base = hdev->core->wrapper_base; >>       int ret = 0; >>   -    writel(BIT(VIDC_CTRL_INIT_CTRL_SHIFT), cpu_cs_base + VIDC_CTRL_INIT); >>       if (IS_V6(hdev->core)) { >>           mask_val = readl(wrapper_base + WRAPPER_INTR_MASK); >>           mask_val &= ~(WRAPPER_INTR_MASK_A2HWD_BASK_V6 | >> @@ -464,6 +463,7 @@ static int venus_boot_core(struct venus_hfi_device *hdev) >>       writel(mask_val, wrapper_base + WRAPPER_INTR_MASK); >>       writel(1, cpu_cs_base + CPU_CS_SCIACMDARG3); >>   +    writel(BIT(VIDC_CTRL_INIT_CTRL_SHIFT), cpu_cs_base + VIDC_CTRL_INIT); >>       while (!ctrl_status && count < max_tries) { >>           ctrl_status = readl(cpu_cs_base + CPU_CS_SCIACMDARG0); >>           if ((ctrl_status & CPU_CS_SCIACMDARG0_ERROR_STATUS_MASK) == 4) { > > Above code looks good. > > -Vikash >