From: Bart Van Assche <bvanassche@acm.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Cc: Bart Van Assche <bvanassche@google.com>
Subject: Re: [PATCH 2/2] scsi: ufs: Stop clearing unit attentions
Date: Fri, 1 Oct 2021 09:19:37 -0700 [thread overview]
Message-ID: <e60a9acc-f53e-83b4-8add-b7a53cfd6492@acm.org> (raw)
In-Reply-To: <12ba3462-ac6b-ef35-4b5e-e0de6086ab51@intel.com>
On 9/30/21 9:58 PM, Adrian Hunter wrote:
> On 30/09/2021 22:52, Jaegeuk Kim wrote:
>> From: Bart Van Assche <bvanassche@google.com>
>>
>> Commit aa53f580e67b ("scsi: ufs: Minor adjustments to error handling")
>> introduced a ufshcd_clear_ua_wluns() call in
>> ufshcd_err_handling_unprepare(). As explained in detail by Adrian Hunter,
>> this can trigger a deadlock. Avoid that deadlock by removing the code that
>> clears the unit attention. This is safe because the only software that
>> relies on clearing unit attentions is the Android Trusty software and
>
> Did you test this?
This patch series has been tested on an Android phone running the latest Trusty
software but with runtime power management disabled.
Bart.
next prev parent reply other threads:[~2021-10-01 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 19:52 [PATCH 1/2] scsi: ufs: retry START_STOP on UNIT_ATTENTION Jaegeuk Kim
2021-09-30 19:52 ` [PATCH 2/2] scsi: ufs: Stop clearing unit attentions Jaegeuk Kim
2021-10-01 4:58 ` Adrian Hunter
2021-10-01 6:52 ` Adrian Hunter
2021-10-01 16:59 ` Bart Van Assche
2021-10-01 17:21 ` Douglas Gilbert
2021-10-01 17:40 ` Bart Van Assche
2021-10-01 17:24 ` Adrian Hunter
2021-10-01 16:19 ` Bart Van Assche [this message]
2021-09-30 19:55 ` [PATCH 1/2] scsi: ufs: retry START_STOP on UNIT_ATTENTION Bart Van Assche
2021-10-01 18:20 [PATCH 0/2 v2] kill clearing UA in UFS driver Jaegeuk Kim
2021-10-01 18:20 ` [PATCH 2/2] scsi: ufs: Stop clearing unit attentions Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e60a9acc-f53e-83b4-8add-b7a53cfd6492@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=bvanassche@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®