From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943043AbdAJT4z (ORCPT ); Tue, 10 Jan 2017 14:56:55 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:35811 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S940796AbdAJT4G (ORCPT ); Tue, 10 Jan 2017 14:56:06 -0500 Subject: Re: [PATCH v2 1/3] arm64: dts: exynos: Add missing unit name to Exynos7 SoC node To: Krzysztof Kozlowski References: <1484069912-6534-1-git-send-email-javier@osg.samsung.com> <1484069912-6534-2-git-send-email-javier@osg.samsung.com> <20170110184728.2nff4r634ics4wb3@kozik-lap> From: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andi Shyti , Chanwoo Choi , devicetree@vger.kernel.org, Kukjin Kim , Catalin Marinas , linux-samsung-soc@vger.kernel.org, Rob Herring , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org Message-ID: Date: Tue, 10 Jan 2017 16:55:52 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170110184728.2nff4r634ics4wb3@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 01/10/2017 03:47 PM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 02:38:30PM -0300, Javier Martinez Canillas wrote: >> This patch fixes the following DTC warning about a mismatch >> between a device node reg property and its unit name: >> >> Node /soc has a reg or ranges property, but no unit name >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> index 80aa60e38237..0d2fedc6ac2f 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> @@ -69,7 +69,7 @@ >> method = "smc"; >> }; >> >> - soc: soc { >> + soc: soc@0 { > > This looks unnatural, like a fix just to silence the DTC. Mostly de do > not enumerate soc node, although there are few exceptions. > Yes, but OTOH arm32 Exynos SoCs just have an empty "ranges" property in their soc device node (parent and child address space is the same, no translation) so DTC doesn't complain about the unit address in those. But others SoCs DTSI with a non-empty ranges property have an unit name in their soc nodes, i.e for arm64 and arm32: arch/arm64/boot/dts/marvell/berlin4ct.dtsi arch/arm/boot/dts/da850.dtsi > I would prefer ignore the warning... however I am happy to hear other opinions. > If is wrong/unnatural to have addresses for soc nodes then I think DTC should be patched to ignore these (like it will be the case for the OPP nodes AFAIU). > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America