From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946794AbdDYLSt (ORCPT ); Tue, 25 Apr 2017 07:18:49 -0400 Received: from mout.web.de ([212.227.15.4]:54735 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946659AbdDYLSj (ORCPT ); Tue, 25 Apr 2017 07:18:39 -0400 Subject: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller() From: SF Markus Elfring To: Arnd Bergmann , Pavel Machek , Sebastian Reichel , Tony Lindgren Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <2fa2c33a-dc43-7e03-03d7-7ca04931e6c7@users.sourceforge.net> Message-ID: Date: Tue, 25 Apr 2017 13:18:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <2fa2c33a-dc43-7e03-03d7-7ca04931e6c7@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:mQICIdkz2zvuITzWF5mjiCGTmByZZpIUYNfWrdOMoQSu2A0HwCK WcSDJj4cEkcPvCtX17eJXDmkrJI3sYBiCKZkcruUB4tXsa8E8OIH9cgMVVw9CQvLDETLAo8 u3Eujbb+c1hZF70NtYrRBPCEOj1MvmaoLti6xx4wv/0hXpoAreAogmO1bLBjIj0YuIOsCGj e4XEUVIAhZeMM4vezyK9w== X-UI-Out-Filterresults: notjunk:1;V01:K0:fvrJTFxo0ls=:dxe8m6IKQLlrtlAaBUv5o0 L0YjOx6v2W02hgD2zRaurothY9h8uCpUVldziaiGxgrPd0b6GadbgJvDCP064M7o8jhw7fQ7n 9HKTMLldvkpj/puCT2OKIJ7yI8T7kaLKeMFiPJonrc0T3Wo5C8OCDZfmLdtTZNNJElf+b8ev1 hd3do/Z30zbhJTm0qm040ivFWJYJF9YyomPd1u/z6i2JDfzF/E21dFjEDCm7Afknh24pc4mdw 4gMh+vTfv7ivFDxpP5bxgQZi7n59EmZrWvQWW9m7JzghKTDZrTl5oqI8JXehaq590yRhD1tNB InEkwIP4lFif+4V0Bf+P1/1Q4PgI7K9+ZlmF5KRgNyPeWk5as1bfYq91VPncyTWxpTbJaNudz lO59GH/XjE0BMGUjExjOYvNz1gU0CvsfT7xBpze5Iup08P+Mnsjn39P0AFpbNyZ8iPiPdx7W0 sMJGxKty4l+mpXzTzesVamv6/OcYd6QW/XIIcs6kMkNVrWonanaTsxBmJ/2FLFqkAIGHNmm6B hGWn27t0hCJTN3RI4442k9GyBA1m/QUjU8RPx53uOZWMuokUl2XQ3dZOpS+Pt58pDv3gAdinF PxeYouf1zO1TATfyOCfh8aFAOqGBJC2wtP0o+Yk0goN8OJb1WInU01YIS4YgQlNSaq6fRslN7 LSQCqkN35/c03DouWQ7wo72ih4+RxcEXkUepNdYtP7MLYtPFRWCf1chBKpKqFBnz483oFUUX6 QlW3pjtOpvqEigR4iA7uV9s4ikXi1maXs6LM/2KakNAjcgTLt3aeTT6tjPtm5MjUIDIAYECB/ foq7q3l Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 25 Apr 2017 12:42:14 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/hsi/controllers/omap_ssi_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index fb7ed8fce83a..88e48b346916 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -384,10 +384,8 @@ static int ssi_add_controller(struct hsi_controller *ssi, int err; omap_ssi = devm_kzalloc(&ssi->device, sizeof(*omap_ssi), GFP_KERNEL); - if (!omap_ssi) { - dev_err(&pd->dev, "not enough memory for omap ssi\n"); + if (!omap_ssi) return -ENOMEM; - } err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); if (err < 0) -- 2.12.2