From: Maximilian Luz <luzmaximilian@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()
Date: Fri, 26 Mar 2021 15:06:08 +0100 [thread overview]
Message-ID: <e614021b-62aa-c879-c324-fc1dc1eec73e@gmail.com> (raw)
In-Reply-To: <YF3TgCcpcCYl3a//@mwanda>
On 3/26/21 1:28 PM, Dan Carpenter wrote:
> The "&client->ddev->lock" and "&ddev->lock" are the same thing. Let's
> use "&ddev->lock" consistently.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch, thanks!
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/platform/surface/surface_dtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
> index 1fedacf74050..63ce587e79e3 100644
> --- a/drivers/platform/surface/surface_dtx.c
> +++ b/drivers/platform/surface/surface_dtx.c
> @@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
> if (status < 0)
> return status;
>
> - if (down_read_killable(&client->ddev->lock))
> + if (down_read_killable(&ddev->lock))
> return -ERESTARTSYS;
>
> /* Need to check that we're not shut down again. */
>
next prev parent reply other threads:[~2021-03-26 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:28 Dan Carpenter
2021-03-26 14:06 ` Maximilian Luz [this message]
2021-04-07 11:25 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e614021b-62aa-c879-c324-fc1dc1eec73e@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®