Re: [PATCH] x86/sev: Improve handling of writes to intercepted GUEST_TSC_FREQ

[Tom Lendacky <thomas.lendacky@amd.com>]

On 7/15/25 04:13, Nikunj A Dadhania wrote:
> Borislav Petkov <bp@alien8.de> writes:
> 
>> On Mon, Jul 14, 2025 at 09:36:04AM -0700, Sean Christopherson wrote:
>>> Or as Tom suggested, return ES_EXCEPTION and let the kernel's normal machinery
>>> WARN on the bad WRMSR.
>>
>> Ack.
> 
> That will panic the SNP guest instead of #GP:
> 
> root@ubuntu:~# wrmsr 0xc0010134 0
> [   20.804335] ------------[ cut here ]------------
> [   20.804336] WARNING: arch/x86/coco/sev/vc-handle.c:383 at vc_handle_exitcode.part.0+0xc1b/0x1090, CPU#0: wrmsr/607
> ...
> [   20.804507] SEV: Unsupported exception in #VC instruction emulation - can't continue
> [   20.804508] ------------[ cut here ]------------
> [   20.804508] kernel BUG at arch/x86/coco/sev/vc-handle.c:123!
> [   20.804514] Oops: invalid opcode: 0000 [#1] SMP NOPTI

Did you fill in the context with the #GP, i.e., ctxt->fi.vector and
ctxt->fi.error_code?

Thanks,
Tom

> 
> Regards,
> Nikunj