From: David Laight <David.Laight@ACULAB.COM>
To: 'David Miller' <davem@davemloft.net>,
"wei.zheng@vivo.com" <wei.zheng@vivo.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"yeyunfeng@huawei.com" <yeyunfeng@huawei.com>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"info@metux.net" <info@metux.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel@vivo.com" <kernel@vivo.com>,
"wenhu.wang@vivo.com" <wenhu.wang@vivo.com>
Subject: RE: [PATCH] net: vxge: fix wrong __VA_ARGS__ usage
Date: Tue, 17 Mar 2020 10:10:53 +0000 [thread overview]
Message-ID: <e61d7621d4ac4b909fda59f234d587fa@AcuMS.aculab.com> (raw)
In-Reply-To: <20200316.150416.703162062113777580.davem@davemloft.net>
> > printk in macro vxge_debug_ll uses __VA_ARGS__ without "##" prefix,
> > it causes a build error when there is no variable
> > arguments(e.g. only fmt is specified.).
> >
> > Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
>
> Does this even happen right now? Anyways, applied.
I thought most of the compilers removed the lurking ','
using some heristic.
A safer alternative is to include the 'fmt' in the ...
then there is always one argument.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2020-03-17 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 14:23 Zheng Wei
2020-03-16 22:04 ` David Miller
2020-03-17 10:10 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61d7621d4ac4b909fda59f234d587fa@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=guohanjun@huawei.com \
--cc=info@metux.net \
--cc=jdmason@kudzu.us \
--cc=kernel@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wei.zheng@vivo.com \
--cc=wenhu.wang@vivo.com \
--cc=will@kernel.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®