From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Serhii <spevnev16@gmail.com>
Cc: <lenb@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/turbostat: fix microcode patch level reading for AMD/Hygon
Date: Wed, 25 Feb 2026 10:05:16 +0530 [thread overview]
Message-ID: <e61eaaec-2c77-480f-a875-3e42633a5fed@amd.com> (raw)
In-Reply-To: <CAM_YkW65=Wam6or8KXdSdZFC2Q_XXqAfwREiomzH9+xgmFtERw@mail.gmail.com>
Hello Serhii,
On 2/24/2026 7:40 PM, Serhii wrote:
> Yes, the only essential change is shift.
> However, I believe that handling the two paths separately is better
> because (a) using different constants better highlights the semantic
> difference of the values stored and (b) AMD currently reserves upper
> bits, which could require handling in the future making separate paths
> more appropriate.
> What do you think, is it still better to merge back into a single path
> with conditional shift for Intel?
I'll let Len answer which one he prefers but having 2 paths is more
code duplication for error handling when we are essentially doing the
same thing.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-02-25 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:37 Serhii Pievniev
2026-02-24 3:30 ` K Prateek Nayak
2026-02-24 14:10 ` Serhii
2026-02-25 4:35 ` K Prateek Nayak [this message]
2026-02-25 18:53 ` Len Brown
2026-02-25 23:16 ` [PATCH v2] " Serhii Pievniev
2026-03-10 18:51 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61eaaec-2c77-480f-a875-3e42633a5fed@amd.com \
--to=kprateek.nayak@amd.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=spevnev16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®