From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: "Say Y" on CONFIG_LEDS_TRIGGER_ACTIVITY
Date: Tue, 19 Sep 2017 22:05:11 +0200 [thread overview]
Message-ID: <e621b590-422d-bab5-72da-da21da8f9fd6@gmail.com> (raw)
In-Reply-To: <20170919195002.GA21940@amd>
Hi Pavel,
On 09/19/2017 09:50 PM, Pavel Machek wrote:
> Hi!
>
> Help text says:
>
> CONFIG_LEDS_TRIGGER_ACTIVITY:
>
> This allows LEDs to be controlled by a immediate CPU usage.
> The flash frequency and duty cycle varies from faint flashes to
> intense brightness depending on the instant CPU load.
> If unsure, say Y.
>
> I don't believe this is important enough trigger that we should
> suggest it by default. So I believe this should be changed to "say N".
Thanks for the heads-up.
Fixed the related commit on the for-next branch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2017-09-19 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 19:50 Pavel Machek
2017-09-19 20:05 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e621b590-422d-bab5-72da-da21da8f9fd6@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome