From: Neil Armstrong <narmstrong@baylibre.com>
To: yu kuai <yukuai3@huawei.com>,
a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie,
daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, zhengbin13@huawei.com
Subject: Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'bpp'
Date: Mon, 6 Jan 2020 16:07:52 +0100 [thread overview]
Message-ID: <e623257b-362b-cdd4-a47c-84c7f756f7af@baylibre.com> (raw)
In-Reply-To: <20191226121207.2099-1-yukuai3@huawei.com>
On 26/12/2019 13:12, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/bridge/cdns-dsi.c: In function
> ‘cdns_dsi_bridge_enable’:
> drivers/gpu/drm/bridge/cdns-dsi.c:788:6: warning: variable ‘bpp’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index a6ab2d281a9b..b7c97f060241 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -784,13 +784,12 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
> unsigned long tx_byte_period;
> struct cdns_dsi_cfg dsi_cfg;
> u32 tmp, reg_wakeup, div;
> - int bpp, nlanes;
> + int nlanes;
>
> if (WARN_ON(pm_runtime_get_sync(dsi->base.dev) < 0))
> return;
>
> mode = &bridge->encoder->crtc->state->adjusted_mode;
> - bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> nlanes = output->dev->lanes;
>
> WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false));
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
and applying to drm-misc-next
prev parent reply other threads:[~2020-01-06 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 12:12 yu kuai
2020-01-06 15:07 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e623257b-362b-cdd4-a47c-84c7f756f7af@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®