From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED001E511 for ; Mon, 18 May 2026 06:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779086192; cv=none; b=q59e69J95V0yDrvGAV/ToVhmxZ+0e4y6fcbXxq9tOp5+Usn2EyOBBxTmoWIOkVk7wK+YrntYEgldwheMOmxf2FdKijbUYkU39+O0/xr937SEiGu0ofPwblJA5zWgsFWh28UqnfLs33gomMl+9i5b1Yv3rwM1heiRW/9XiGsvDtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779086192; c=relaxed/simple; bh=5RFO+Ssvg4JmPw/yA4u/nPzTGuYXVhi4EeKK7/9cMjw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H750Ea5hZzUSYUNKR8szmNmu2/yiSwicpaRxEbmie2LYZ36YSeD0qRQlYnFtzJmF2NiyZgjdtHjnBOGcn8+SWt3le4okFQqBfgXqMsracI1S7giY9SBFr6NHIpBAw7MxqxFASHWkbkYw3Lg4SyXuHiDFh3/AmfLEz7McQBN154o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m/QupLAN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UpvtwWcp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m/QupLAN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UpvtwWcp" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I1ruAE970086 for ; Mon, 18 May 2026 06:36:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OhWjBMRcsj+kQRn2s4H2mf5lmW3+OFeXfq83HZ0y7aE=; b=m/QupLAN2LODnD+C 1P+6W3OdBFoGdhgeeDxf4ZtQ/rsutO1IA9kh5gKqeZ6nEZJH5eqe+RNl0HRrdeJ/ V8bPW352grJGS9o/uz4btRY9KY6O+/w1bLUTVALAIyo8g3XwHY+FOfZzTlF9bj5X hKWA2uWixvvB1NEue6ZAdsa1LdINFuOS7RtGdwsdZ9U34ppEwyTjpPyIEdJvQ7ef ZS5U+RjDTKfrFimo+Mki1a3zlnSTCYcGCFJh6Uf3lOR2Z7POlYFkbSckkZTt4Ltf 8zFrQkYUSmy+t6o/9e587Yl/NjYdS+gq79PlN+meOlpQjSw5H9YpjkF97fr6AbyK CHyL/A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6hv7vwc2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 06:36:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-368b15eeb3bso4512515a91.2 for ; Sun, 17 May 2026 23:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779086187; x=1779690987; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OhWjBMRcsj+kQRn2s4H2mf5lmW3+OFeXfq83HZ0y7aE=; b=UpvtwWcpxpxJjPBFrGQiimvEbpEorpBhuBTtICwPn7BlpA5WMsqiPiT3VeDbQ5eFQu S9eWmehC0niD/2QP9XPb/9XfmzR51PbPJcxLWleFQyOwoMaJ9nTLAjFRUZVvGQy/X8ch vMoYCTUoVNwYQfaZS5ub/6Y0ES5fiqSdmF7TWhOa6669mqdP1XyXtkQsDli83Xjn8hOf ES5QukaWtTJGY9Nggoc8bhFMGXRM1NX+kdBx/JSzrQBQywAGO/PHdPCXwxQ4xJsKtjsI mN6qvzLSpH+BMtW5vUhs9zQbJ7l1zMZJ+CfiOLkoXmjJbQ1VR9Fng+M3VKU1Vi+pzSci x7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779086187; x=1779690987; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OhWjBMRcsj+kQRn2s4H2mf5lmW3+OFeXfq83HZ0y7aE=; b=IY6Qzf6Hj8Ay/jzO00kYd3REH5r2EjhzIPQIolmjsp/OqxBmptWcZPmKgI4pPNQ+vK vFq8pRpkV6NnV3bMVknvUlJ8bRc2gzOKtx1s+g9KhOeBA+3K+vQXcSHNdhSI98oZQMp8 PWudvu46080uVDc9sWyx81wcARalsBo0EZHoIBGZdehKtnmY2aSsXw9EAsXFtnKUUjLo 7t6sAIG28nImkXEouzzXoHcvSxPwOM3QhGwZTJqIt2bO4ay9RYqa6j+wMhrVOCg4l08U IKXFq/nBrJh+hBDvwS/feaJL1CHFVscGw8aCsvlj1bgPxALIbc/4uFT0FgdE+wsTPsDz UHMw== X-Forwarded-Encrypted: i=1; AFNElJ/ZjHxrVRCmwJZcFCa4Xbxe3+1s2neOVHd8/ECIsaXh4S8uqLA01j6QtEJJw7tiFqziyxn+0yfSiHVYYRM=@vger.kernel.org X-Gm-Message-State: AOJu0YxqMfkrMOChx+u+ee/yAE97fqSY/HTGFFBMKL2eK6/uLRWkkQSW AnlcY802NleiYFjJutFsuG7jihAFnX7yvar13WB7idN+OZxD/ulq1f+V/GvzJ65jNtXzoH29UYN Ax0MIULRjqXqEacNqC0xhI0gZoCw9LLRjhwID7UW+TrEPCfhIHiU4bUBxDJARoaM70Q== X-Gm-Gg: Acq92OF8ESWaRlkgsDuLrwDCX6HnUDsvl0GHg8Jek8VRz//olOHZE4tnI0CV0uZMmeD cKrXdnUO4MH3W0EgDJPNzjYX1APfnE0CwZkE6F2Ne3Q0DvKgLBqH1rG5gTDWj2CTMS8o7aeBJ8s F6J5WKi/lBNFzVe3no6umrnUKOYWCmvX72SRJKsTNBCak++pvxNqOuAHUGPuVTZxMtmt+WTk1r6 n/YV8PDwwz6TKT7NOHr6uXa7kKl9LxJ+m+6dCcFflYo6Yg1vp/U/8WcwWgcthhx8zlE5YQlQAXC ejjsl3lxt9Dqo3RIi9vw+YOVs/R2jvuxPK61Osw/hsRE1f5ttQlmRQJodh3+t18QvopYh28NJUY ua53gORvNeRoZOjPn7AOsjqPf3q3FLflVuTKG+5/ar59HyULu2O+/HR3+Erg+8VEJ9YnkGjJEQK wu99ZBOUXRi9wT0x0jbYg= X-Received: by 2002:a17:90b:4c51:b0:368:2074:b7a with SMTP id 98e67ed59e1d1-369519af671mr13714069a91.5.1779086186746; Sun, 17 May 2026 23:36:26 -0700 (PDT) X-Received: by 2002:a17:90b:4c51:b0:368:2074:b7a with SMTP id 98e67ed59e1d1-369519af671mr13714036a91.5.1779086186266; Sun, 17 May 2026 23:36:26 -0700 (PDT) Received: from [192.168.0.74] (n1-41-240-65.bla22.nsw.optusnet.com.au. [1.41.240.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36951278e7fsm9708269a91.8.2026.05.17.23.36.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2026 23:36:25 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 16:36:20 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() To: Robertus Diawan Chris Cc: jens.wiklander@linaro.org, sumit.garg@kernel.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com References: <20260513091031.145826-1-robertusdchris@gmail.com> <8182784b-b6c2-4136-af8d-3aea4f5a4662@oss.qualcomm.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA2MiBTYWx0ZWRfXwXmM6dlLEl8u esB3+1oLWHNZSDtxtgf25QYZywJj6wrXsQor8xgWYZy69SoJE/DbphdHLFVYex9Q7ssTJelhf8y J6jpEsDOyhehLYb/I1jpX1zrL94JQs3evpvzvacI2jugxieG7Jcl/DQ3o9dNWbgtreE2GcqlhgU 8xpJqwFkj5mmIoysqj8d3aaczUM8lOHclAhMXmL69xxRCvBNs4nqGLBVEtzoBoyob/dNKjnDD5O WsekIft+UQ6N5WgBYzcSRTdzYup1c8dvIgvWi0yeh/tGg1cfUf9rDZ3sYYDzsn732FSuGwrDqZo abFh8ZD/arGWTAwt2fig+BTIYqgzfSuD0sbVXeamGwBbz82EJbgOOjFXyFsA4D3V29wUd7aStWX t6MuUPG0JQ2bgO60wilCQDHT/S74OHAS0V4iK94YvBwi566jWHSIZFo4bdJbl/RvQzfpYIx5EA0 pZglLR/MNutmlBBqFBw== X-Authority-Analysis: v=2.4 cv=a8oAM0SF c=1 sm=1 tr=0 ts=6a0ab36b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=hi51d+lTLNy/RbqRqnOomQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=pGLkceISAAAA:8 a=X36vB_roDklc4VALgUkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: CYMYO-O_AbngtUj8NNYAQZGhpV68S8rv X-Proofpoint-GUID: CYMYO-O_AbngtUj8NNYAQZGhpV68S8rv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_01,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180062 Hi, On 5/15/2026 3:23 PM, Robertus Diawan Chris wrote: > Hello Amir, > > On Fri, May 15, 2026 at 11:31:50AM +1000, Amirreza Zarrabi wrote: >> On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote: >>> qcomtee_object_user_init() is a variadic function and when the function >>> return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB >>> case, there's no va_end to cleanup "ap" object initialized by va_start >>> and that can cause undefined behavior. So make sure to use va_end before >>> returning the error code when there's no dispatch callback. >>> >>> This is reported by Coverity Scan as "Missing varargs init or cleanup". >>> >>> Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") >>> Signed-off-by: Robertus Diawan Chris >>> --- >>> I don't have the device, so I am not sure how to test this change. >>> Thank you. >>> >>> drivers/tee/qcomtee/core.c | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c >>> index b1cb50e434f0..901a31e8201f 100644 >>> --- a/drivers/tee/qcomtee/core.c >>> +++ b/drivers/tee/qcomtee/core.c >>> @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, >>> break; >>> case QCOMTEE_OBJECT_TYPE_CB: >>> object->ops = ops; >>> - if (!object->ops->dispatch) >>> - return -EINVAL; >>> + if (!object->ops->dispatch) { >>> + ret = -EINVAL; >>> + goto out; >>> + } >>> >>> /* If failed, "no-name". */ >>> object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); >>> @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, >>> default: >>> ret = -EINVAL; >>> } >>> + >>> +out: >>> va_end(ap); >>> >>> return ret; >>> >>> base-commit: 5d6919055dec134de3c40167a490f33c74c12581 >> >> Hi, >> >> Forgot to mention: how about using a break instead of a goto. > > Oh right. In this case, using "break" statement is enough. I will send > the v2 of the patch. Maybe something like this: > > if (!object->ops->dispatch) { > ret = -EINVAL; > break; > } > > and then remove the "out" label. > >> Then feel free to add Reviewed-by. > > I want to confirm first, if I changed the patch using "break" statement, > do I need to add "Reviewed-by" tag in the v2 of the patch or not? I am > still not sure when to add "Reviewed-by" tag, like can we add > "Reviewed-by" tag when we changed the patch? > This is a small change. You can add the tag when sending your v2 as long as you include the change. Best Regards, Amir > Thank you. > > Best regards, > Robertus Diawan Chris