From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932310AbdESUlA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 May 2017 16:41:00 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:47325 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756744AbdESUkz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 May 2017 16:40:55 -0400
Subject: Re: [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to
 UAPI
To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com,
        airlied@linux.ie, linux@armlinux.org.uk,
        boris.brezillon@free-electrons.com, daniel.vetter@intel.com,
        jani.nikula@linux.intel.com, seanpaul@chromium.org,
        p.zabel@pengutronix.de, robdclark@gmail.com, bskeggs@redhat.com,
        tomi.valkeinen@ti.com, linux-graphics-maintainer@vmware.com,
        syeh@vmware.com, thellstrom@vmware.com, architt@codeaurora.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        =?UTF-8?Q?Kristian_H=c3=b8gsberg?= <hoegsberg@gmail.com>
References: <20170518013911.29626-1-robert.foss@collabora.com>
 <20170518094956.GY12629@intel.com>
From: Robert Foss <robert.foss@collabora.com>
Message-ID: <e62bab71-34c5-c106-a6bb-aafd05c3a203@collabora.com>
Date: Fri, 19 May 2017 16:40:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170518094956.GY12629@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2017-05-18 05:49 AM, Ville Syrjälä wrote:
> On Wed, May 17, 2017 at 09:39:11PM -0400, Robert Foss wrote:
>> +/*
>> + * DRM_MODE_REFLECT_<axis>
>> + *
>> + * Signals that the contents of a drm plane has been reflected in
>> + * the <axis> axis.
> 
> Still vague.

Ack, I'll add some verbiage.

> 
> Also you didn't respond to my comment about the use of past tense.

Fixed in v4.


Rob.

> 
>> + *
>> + * This define is provided as a convenience, looking up the property id
>> + * using the name->prop id lookup is the preferred method.
>> + */
>> +#define DRM_MODE_REFLECT_X      (1<<4)
>> +#define DRM_MODE_REFLECT_Y      (1<<5)
>> +
>> +/*
>> + * DRM_MODE_REFLECT_MASK
>> + *
>> + * Bitmask used to look for drm plane reflections.
>> + */
>> +#define DRM_MODE_REFLECT_MASK (\
>> +		DRM_MODE_REFLECT_X | \
>> +		DRM_MODE_REFLECT_Y)
>> +
>> +
>>   struct drm_mode_modeinfo {
>>   	__u32 clock;
>>   	__u16 hdisplay;
>> -- 
>> 2.11.0.453.g787f75f05
>