From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B83C25B06 for ; Tue, 9 Aug 2022 08:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234019AbiHIIq2 (ORCPT ); Tue, 9 Aug 2022 04:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238906AbiHIIqR (ORCPT ); Tue, 9 Aug 2022 04:46:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C9CE21815 for ; Tue, 9 Aug 2022 01:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660034775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jaq03+KQYvPWrhdnqM1mj3r1Ie88ciNsACbCUOzVw+0=; b=EpqtKpYqoNUAc8Wh+D7ebYE3TrEjn5mebE6JOjyNHkAOviyHyqYrH1db0AszlMeudRdVXF DgWnH0MbJ/3OOanY4+fylXAcQvn+Ua/GnTfiZRdzK0zCkKMNWXMVu1Ota6QUzLA+5zQlYI x8BIHlL1vEX+FKl3SOENMVdYOCMPwk0= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-484-PT4BwKZpOiyUM_C8HywwgQ-1; Tue, 09 Aug 2022 04:46:14 -0400 X-MC-Unique: PT4BwKZpOiyUM_C8HywwgQ-1 Received: by mail-ej1-f71.google.com with SMTP id go15-20020a1709070d8f00b00730ab9dd8c6so3163927ejc.6 for ; Tue, 09 Aug 2022 01:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=jaq03+KQYvPWrhdnqM1mj3r1Ie88ciNsACbCUOzVw+0=; b=foWEJ1dMErDnduFuts5xMV09HMXYDAe56fBH/CYjX24rThtXBiz0EL0nxYvR139tqE 1Exf8hUGvKNGjN8OeAxJ7CFQF7gw/xulQCdTVjcBp0w8S4UHP1Wrr1z7gHMeFJWSItmk PZJJGxMRfRSnifTCReGjbbtmR9xnkvUSMzjN5W7u9ZlNCIfc04bqlcg1A+NEAbLjUgkH /snV0UbkiiguNNnCVAL8zR65M7bZh4dRzIz90lQUh+CnAcDQtfbIppYczpuyktRZFIg+ 9NpCBubpYpUhOA1rauRflgp7PsIhLcs0pxgVxXiuobX4RdIKUWAK/pbx1isiX/T6ACJI WMBg== X-Gm-Message-State: ACgBeo0cBbdyxwb31cfOHywoVgMWDKCJKY2wgfwPLObq7LTEGbNCj/pP ZoScg4MB89CvZRuSR4obKsUkhEEowF3FiMv98uoynDgACVNEbYGZBPRVXAe7uWD04L+2ivAwEtW KQMP2I4HmoJ7W7IIkIZqnGnDa X-Received: by 2002:a17:906:9b83:b0:730:b3ae:343 with SMTP id dd3-20020a1709069b8300b00730b3ae0343mr17022674ejc.670.1660034772845; Tue, 09 Aug 2022 01:46:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR5KxB7CeMHwSWISG3iCZ0m1EID+v/ZwlOpnEekw9+qvE0R6X982djrb+Kwdr6dAEKJ2OPR60Q== X-Received: by 2002:a17:906:9b83:b0:730:b3ae:343 with SMTP id dd3-20020a1709069b8300b00730b3ae0343mr17022663ejc.670.1660034772690; Tue, 09 Aug 2022 01:46:12 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id dm13-20020a05640222cd00b0043cb1a83c9fsm5758408edb.71.2022.08.09.01.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 01:46:12 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 10:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 2/2] asus-wmi: Add support for ROG X13 tablet mode Content-Language: en-US To: Andy Shevchenko , "Luke D. Jones" Cc: Platform Driver , Linux Kernel Mailing List References: <20220809033048.1634583-1-luke@ljones.dev> <20220809033048.1634583-3-luke@ljones.dev> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/9/22 10:40, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 5:31 AM Luke D. Jones wrote: >> >> Add quirk for ASUS ROG X13 Flow 2-in-1 to enable tablet mode with >> lid flip (all screen rotations). > > ... > >> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */ >> { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */ >> + { KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */ > > Shouldn't you keep it sorted by value? Actually as I mentioned in my review of v1, we don't want this addition at all, see: https://lore.kernel.org/platform-driver-x86/d9d79f9b-f3ab-c07e-9e18-5760ff828487@redhat.com/ Regards, Hans > > ... > >> #define NOTIFY_KBD_FBM 0x99 >> #define NOTIFY_KBD_TTP 0xae >> #define NOTIFY_LID_FLIP 0xfa >> +#define NOTIFY_LID_FLIP_ROG 0xbd > > Ditto. > > ... > >> +static void lid_flip_rog_tablet_mode_get_state(struct asus_wmi *asus) >> +{ >> + int result; >> + >> + result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_LID_FLIP_ROG); >> + if (result >= 0) { > > You missed the second part of my comment. Please, read carefully _all_ > reviewer's comments. > >> + input_report_switch(asus->inputdev, SW_TABLET_MODE, result); >> + input_sync(asus->inputdev); >> + } >> +} > > ... > > Overall, it's getting better! >