mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Chunkai Deng <chunkai.deng@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com,
	tony.truong@oss.qualcomm.com, tao.zhang1@oss.qualcomm.com,
	peter.chen@oss.qualcomm.com
Subject: Re: [PATCH v2 1/2] rpmsg: glink: Split protocol start out of native_probe
Date: Thu, 3 Sep 2026 12:49:00 +0200	[thread overview]
Message-ID: <e637fadc-7107-4d00-b763-fb9f0839d8b9@oss.qualcomm.com> (raw)
In-Reply-To: <20260824-rpmsg-glink-split-protocol-start-v2-1-362d7c233f66@oss.qualcomm.com>

On 8/24/26 9:05 AM, Chunkai Deng wrote:
> The SMEM and RPM transports request their receive interrupt with
> IRQF_NO_AUTOEN and enable it only once qcom_glink_native_probe() has
> returned. But native_probe() sends the version command, so on a fast
> remote the version ACK can land while the interrupt is still masked. The
> ACK is dropped and the handshake never completes.
> 
> Move the version command and the chrdev registration into a new
> qcom_glink_native_start(), leaving native_probe() to set up the glink
> instance. Both transports enable their interrupt before calling
> native_start().
> 
> Signed-off-by: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
> Assisted-by: Claude:claude-opus-5
> ---


Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-09-03 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  7:05 [PATCH v2 0/2] rpmsg: glink: Fix version handshake race against a late RX interrupt Chunkai Deng
2026-08-24  7:05 ` [PATCH v2 1/2] rpmsg: glink: Split protocol start out of native_probe Chunkai Deng
2026-09-03 10:49   ` Konrad Dybcio [this message]
2026-08-24  7:05 ` [PATCH v2 2/2] rpmsg: glink: Request the RX interrupt already enabled Chunkai Deng
2026-09-03 10:54   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e637fadc-7107-4d00-b763-fb9f0839d8b9@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=chris.lew@oss.qualcomm.com \
    --cc=chunkai.deng@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=peter.chen@oss.qualcomm.com \
    --cc=tao.zhang1@oss.qualcomm.com \
    --cc=tony.truong@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®