mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
	peterz@infradead.org, james.clark@arm.com, alisaidi@amazon.com,
	leo.yan@linaro.org, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, mark.rutland@arm.com,
	maddy@linux.ibm.com, tmricht@linux.ibm.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	sandipan.das@amd.com, ananth.narayan@amd.com,
	santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2 2/3] perf mem amd: Fix perf_pmus__num_mem_pmus()
Date: Thu, 15 Jun 2023 11:33:57 +0530	[thread overview]
Message-ID: <e63e6d33-6659-b63f-2716-c347aba7f525@amd.com> (raw)
In-Reply-To: <CAP-5=fWkzHufJXV-iRAGifv_z11AOc5LKOyL-QvYL_N+gSPvzw@mail.gmail.com>

>> +int perf_pmus__num_mem_pmus(void)
>> +{
>> +       /* AMD uses IBS OP pmu for perf mem/c2c */
> 
> nit: could we just add:
> AMD uses IBS OP pmu and not a core PMU for perf mem/c2c

Sure.

  reply	other threads:[~2023-06-15  6:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  5:16 [PATCH v2 0/3] perf mem amd: Fix few logic bugs Ravi Bangoria
2023-06-15  5:16 ` [PATCH v2 1/3] perf pmus: Describe semantics of 'core_pmus' and 'other_pmus' Ravi Bangoria
2023-06-15  5:16 ` [PATCH v2 2/3] perf mem amd: Fix perf_pmus__num_mem_pmus() Ravi Bangoria
2023-06-15  6:02   ` Ian Rogers
2023-06-15  6:03     ` Ravi Bangoria [this message]
2023-06-15  6:12       ` [PATCH v2.1 " Ravi Bangoria
2023-06-16 13:59         ` Arnaldo Carvalho de Melo
2023-06-15  5:17 ` [PATCH v2 3/3] perf mem: Scan all PMUs instead of just core ones Ravi Bangoria
2023-06-15  6:03 ` [PATCH v2 0/3] perf mem amd: Fix few logic bugs Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e63e6d33-6659-b63f-2716-c347aba7f525@amd.com \
    --to=ravi.bangoria@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alisaidi@amazon.com \
    --cc=ananth.narayan@amd.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sandipan.das@amd.com \
    --cc=santosh.shukla@amd.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®