From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 864C1C77B7A for ; Tue, 30 May 2023 09:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbjE3JfL (ORCPT ); Tue, 30 May 2023 05:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjE3Jet (ORCPT ); Tue, 30 May 2023 05:34:49 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EB02F9 for ; Tue, 30 May 2023 02:34:48 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34U8fdTM024574; Tue, 30 May 2023 04:34:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=KHDijHzgsVXY1MQfmw7OOY+PLkzfOlr/Cua2+1zmRfs=; b=FEvk9mUuRCqyJYHdD1whGFFj5kV4MctpWzcVqd85UicdaXvfWSrCfpl80aIALoeVu1Fe 1gdt03ogMxv6qHsxBCZrD96yeDIhrK2A/by27Sg6q6rfQo4cXwtTGxFI6cyIPX5TsQrj dSPKGORI4hzkFdC1164eG2nhB43DNZMxZWR7oX0jFArg7j1wUTtctuJI9CIGV8XC7vC/ 1Aasqu5XCnM1px0toPhNO5UxN5sa4IWxhexDHloh4boIcUGIJ1Xc7702TpODsM2anDa1 VKyH48r6mTd7wCf6RdbtoSiBd1VXGT1vFFD41xQCitkl8yKYYmGrsUa3adKkyCJ8WkF4 jw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3quf90txf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 04:34:13 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 30 May 2023 10:34:11 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 30 May 2023 10:34:11 +0100 Received: from [198.90.251.127] (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.127]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 2C485475; Tue, 30 May 2023 09:34:11 +0000 (UTC) Message-ID: Date: Tue, 30 May 2023 10:34:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 12/12] ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier Content-Language: en-US To: , , , CC: , , , References: <20230526122852.4552-1-rf@opensource.cirrus.com> <20230526122852.4552-13-rf@opensource.cirrus.com> <4ec68c42-dbab-5006-c6a5-0be147a7d0f1@microchip.com> From: Richard Fitzgerald In-Reply-To: <4ec68c42-dbab-5006-c6a5-0be147a7d0f1@microchip.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9XoKl8oyEkvkJrjyPkZbuGQy29DXhfpT X-Proofpoint-ORIG-GUID: 9XoKl8oyEkvkJrjyPkZbuGQy29DXhfpT X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/05/2023 08:39, Claudiu.Beznea@microchip.com wrote: > On 26.05.2023 15:28, Richard Fitzgerald wrote: >> +static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56, >> + const struct firmware **firmware, char **filename, >> + const char *dir, const char *system_name, >> + const char *amp_name, >> + const char *filetype) >> +{ >> + char *s, c; >> + int ret = 0; >> + >> + if (system_name && amp_name) >> + *filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc-%s-%s.%s", dir, >> + cs35l56->base.secured ? "s" : "", cs35l56->base.rev, >> + system_name, amp_name, filetype); >> + else if (system_name) >> + *filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc-%s.%s", dir, >> + cs35l56->base.secured ? "s" : "", cs35l56->base.rev, >> + system_name, filetype); >> + else >> + *filename = kasprintf(GFP_KERNEL, "%scs35l56%s-%02x-dsp1-misc.%s", dir, >> + cs35l56->base.secured ? "s" : "", cs35l56->base.rev, >> + filetype); >> + >> + if (!*filename) >> + return -ENOMEM; >> + >> + /* >> + * Make sure that filename is lower-case and any non alpha-numeric >> + * characters except full stop and forward slash are replaced with >> + * hyphens. >> + */ >> + s = *filename; >> + while (*s) { >> + c = *s; >> + if (isalnum(c)) >> + *s = tolower(c); >> + else if (c != '.' && c != '/') >> + *s = '-'; >> + s++; >> + } >> + >> + ret = firmware_request_nowarn(firmware, *filename, cs35l56->base.dev); >> + if (ret) { >> + dev_dbg(cs35l56->base.dev, "Failed to request '%s'\n", *filename); >> + kfree(*filename); >> + *filename = NULL; >> + } else { >> + dev_dbg(cs35l56->base.dev, "Found '%s'\n", *filename); > > I may be wrong but *filename seems leaked to me on this path. I noticed it > is could be duplicated on cs_dsp_debugfs_save_wmfwname() but the original > copy seems left aside. > It's not a leak. The file has been found so the name of the found file is returned (it's used by other code). But there is a leak of that memory elsewhere. >> + } >> + >> + return ret; >> +} >