Re: [PATCH v2 16/24] media: iris: Add encoder support for V4L2 event subscription

[Vikash Garodia <quic_vgarodia@quicinc.com>]

On 8/13/2025 3:08 PM, Dikshita Agarwal wrote:
> Implement support for V4L2 event subscription on the encoder device by
> handling the SUBSCRIBE_EVENT and UNSUBSCRIBE_EVENT ioctls with the
> necessary hooks.
> 
> This enables userspace applications to subscribe to V4L2 events,
> allowing asynchronous notification mechanisms.
> 
> Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # X1E80100
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> ---
>  drivers/media/platform/qcom/iris/iris_venc.c | 14 ++++++++++++++
>  drivers/media/platform/qcom/iris/iris_venc.h |  1 +
>  drivers/media/platform/qcom/iris/iris_vidc.c |  9 ++++++++-
>  3 files changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/platform/qcom/iris/iris_venc.c
> index 301206253090962abbb4e4eac8ee88e7b359c98d..3dbcce23cbe94cf0edc4421694a3ba11faa5eb96 100644
> --- a/drivers/media/platform/qcom/iris/iris_venc.c
> +++ b/drivers/media/platform/qcom/iris/iris_venc.c
> @@ -3,6 +3,7 @@
>   * Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>   */
>  
> +#include <media/v4l2-event.h>
>  #include <media/v4l2-mem2mem.h>
>  
>  #include "iris_buffer.h"
> @@ -283,3 +284,16 @@ int iris_venc_validate_format(struct iris_inst *inst, u32 pixelformat)
>  
>  	return 0;
>  }
> +
> +int iris_venc_subscribe_event(struct iris_inst *inst,
> +			      const struct v4l2_event_subscription *sub)
> +{
> +	switch (sub->type) {
> +	case V4L2_EVENT_EOS:
> +		return v4l2_event_subscribe(&inst->fh, sub, 0, NULL);
> +	case V4L2_EVENT_CTRL:
> +		return v4l2_ctrl_subscribe_event(&inst->fh, sub);
> +	default:
> +		return -EINVAL;
> +	}
> +}
> diff --git a/drivers/media/platform/qcom/iris/iris_venc.h b/drivers/media/platform/qcom/iris/iris_venc.h
> index 04fd41275547c40c359c6ea04dfe4ee31d2d0df6..2d9614ae18e8a2318df6673fbeae5ee33c99b596 100644
> --- a/drivers/media/platform/qcom/iris/iris_venc.h
> +++ b/drivers/media/platform/qcom/iris/iris_venc.h
> @@ -14,5 +14,6 @@ int iris_venc_enum_fmt(struct iris_inst *inst, struct v4l2_fmtdesc *f);
>  int iris_venc_try_fmt(struct iris_inst *inst, struct v4l2_format *f);
>  int iris_venc_s_fmt(struct iris_inst *inst, struct v4l2_format *f);
>  int iris_venc_validate_format(struct iris_inst *inst, u32 pixelformat);
> +int iris_venc_subscribe_event(struct iris_inst *inst, const struct v4l2_event_subscription *sub);
>  
>  #endif
> diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
> index 458773a2ed7f5e16d5bd5e79dba2f5c029036505..d8c94074153e9b1ceac4f911210ddbf89bbe3533 100644
> --- a/drivers/media/platform/qcom/iris/iris_vidc.c
> +++ b/drivers/media/platform/qcom/iris/iris_vidc.c
> @@ -489,7 +489,12 @@ static int iris_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subs
>  {
>  	struct iris_inst *inst = container_of(fh, struct iris_inst, fh);
>  
> -	return iris_vdec_subscribe_event(inst, sub);
> +	if (inst->domain == DECODER)
> +		return iris_vdec_subscribe_event(inst, sub);
> +	else if (inst->domain == ENCODER)
> +		return iris_venc_subscribe_event(inst, sub);
> +
> +	return -EINVAL;
>  }
>  
>  static int iris_dec_cmd(struct file *filp, void *fh,
> @@ -584,6 +589,8 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops_enc = {
>  	.vidioc_enum_framesizes         = iris_enum_framesizes,
>  	.vidioc_enum_frameintervals     = iris_enum_frameintervals,
>  	.vidioc_querycap                = iris_querycap,
> +	.vidioc_subscribe_event         = iris_subscribe_event,
> +	.vidioc_unsubscribe_event       = v4l2_event_unsubscribe,
>  };
>  
>  void iris_init_ops(struct iris_core *core)
> 

Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>