From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE731E6DEB for ; Wed, 4 Sep 2024 19:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725479851; cv=none; b=WnmGVr3JEhNpPKJ3R1naR0a5XkAI7zloKWUVRJ/qdlbWwd1lpOqSFPb7VDULtAKo3vOf7J34apGLrEFtDzNZ/xzeEC2a43GNkdqPQZ1AKwB/5A9OZU1bwkjcNDJ3yy8FmxqGQA0rgIMeblzKVMtIKeACr6iWdQj0czQ38+n5GRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725479851; c=relaxed/simple; bh=Xwgfnwm4aixwjHxK45Cfat1yHYnqgba6d47DLMpHEVU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UiAz1iV55uUMJDW52qdWLvFCNbhY9SNO3ZyLpgt8sWK/I+6+o/OrHDH+AykssxwJ60IE3UGX0l91J2yznOQhWuh0S9a54ye1c6yG/Pm9M3i79qbM8ZaUO2S2Bdz/5Bc6xaq49jWIP5WzAXI/5+Z8TuIWS0QhpXa4fbR2+/s/f54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NlSCdQS8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NlSCdQS8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725479849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dfOc/OwTB9hjAZ4+hRIzp7kADInixhRm8yePf7xIchM=; b=NlSCdQS8ssym0JxaKEomFDLnTCDur9swUf4rREY8TxkdF2Yy3wwZuNEj/FOl9aQXcTZaL1 qBroIyL1mZj3enN8XZi7Ipwlf4OZMweiWZqlVRyBenDhI29bAob6trM+7pSz2ds38X4zC4 e4CqgEYvwUC+Nt9zZrs7PptRMB6uBh8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-zfEPBnLnPWaYPpaPaasuhw-1; Wed, 04 Sep 2024 15:57:28 -0400 X-MC-Unique: zfEPBnLnPWaYPpaPaasuhw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a8698664af8so2365866b.0 for ; Wed, 04 Sep 2024 12:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725479847; x=1726084647; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dfOc/OwTB9hjAZ4+hRIzp7kADInixhRm8yePf7xIchM=; b=AQFWL+XUp3jdJ2P9GdlfY3k9COrUAFdrXozh0v8SGHJ4ZeXGMd870V1fF32yEHKs3Q FBGSnGXsGwAH7J8rqh6YLPiVKXC8OKPeDn5rl6LbCQIixXfU7VLkaqDJO6ep2bPCtjkG QBNk19o8F6DETuFySaMfUzlqTrUXTHPcxE9EUhba0LLnfpDeqY6kZ6nty7cVcmgqxMEi tGD1cVFD8rGb56JODSdlgOzpYi0epjK5WW2lqSY066rz4ASljWYtuPm9Mvqn+kF/gIO9 tcZwLlZbolvglhl6PGlgxqtk2b2UTxr80CUnNjZ8ifat1XeIsANL2tpDLYkSe5S6/fO4 jGkw== X-Forwarded-Encrypted: i=1; AJvYcCW0cAfNKNp6Y8pOJRop2JviTiajt51icRikdUyKZQI5ZEF2W6TRoU18O4vekFXKiJvuEmmYnqYdPRFqPZs=@vger.kernel.org X-Gm-Message-State: AOJu0YzOueq1Rpzp/m/FEl3AhyNE1LHAqKTUYefDRn2NK0vNfccs4mCL hIOF76Qo8zOQ0M/lnmMQeY3sgx9gKrBbNzosbxLwQnkoRmUH7r2tD4JvFejoSuFGwYBusnN5nX4 aQfnRpECHdxzJF16fIrW3zLUd+iBrf9HwqKLBWNbjxC2QdqN1daajBzf+E8vHXA== X-Received: by 2002:a17:907:94d4:b0:a89:b829:7598 with SMTP id a640c23a62f3a-a8a42fdba65mr344795966b.12.1725479846710; Wed, 04 Sep 2024 12:57:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQhgIOlhuLY34Q4gwUYH9FdcOa8lFucrXBT8MB62RussGsqf5BBIcU5nwJAWBclu+fIPfYxw== X-Received: by 2002:a17:907:94d4:b0:a89:b829:7598 with SMTP id a640c23a62f3a-a8a42fdba65mr344794466b.12.1725479846369; Wed, 04 Sep 2024 12:57:26 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a62370ee0sm30693466b.106.2024.09.04.12.57.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 12:57:26 -0700 (PDT) Message-ID: Date: Wed, 4 Sep 2024 21:57:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 4/9] power: supply: sysfs: register battery properties To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Sebastian Reichel , Armin Wolf Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904-power-supply-extensions-v3-0-62efeb93f8ec@weissschuh.net> <20240904-power-supply-extensions-v3-4-62efeb93f8ec@weissschuh.net> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240904-power-supply-extensions-v3-4-62efeb93f8ec@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 9/4/24 9:25 PM, Thomas Weißschuh wrote: > Instead of only registering properties from the psy_desc itself, > also register the ones from the battery. > Use power_supply_has_property() for this test which makes the logic also > easier to read. > > Signed-off-by: Thomas Weißschuh Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/power/supply/power_supply_sysfs.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index 3e63d165b2f7..4ab08386bcb7 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -367,7 +367,6 @@ static umode_t power_supply_attr_is_visible(struct kobject *kobj, > struct device *dev = kobj_to_dev(kobj); > struct power_supply *psy = dev_get_drvdata(dev); > umode_t mode = S_IRUSR | S_IRGRP | S_IROTH; > - int i; > > if (!power_supply_attrs[attrno].prop_name) > return 0; > @@ -375,19 +374,11 @@ static umode_t power_supply_attr_is_visible(struct kobject *kobj, > if (attrno == POWER_SUPPLY_PROP_TYPE) > return mode; > > - for (i = 0; i < psy->desc->num_properties; i++) { > - int property = psy->desc->properties[i]; > - > - if (property == attrno) { > - if (power_supply_property_is_writeable(psy, property) > 0) > - mode |= S_IWUSR; > - > - return mode; > - } > - } > - > - if (power_supply_battery_info_has_prop(psy->battery_info, attrno)) > + if (power_supply_has_property(psy, attrno)) { > + if (power_supply_property_is_writeable(psy, attrno) > 0) > + mode |= S_IWUSR; > return mode; > + } > > return 0; > } >