From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755733AbdJJIkg (ORCPT ); Tue, 10 Oct 2017 04:40:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45768 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755272AbdJJIkf (ORCPT ); Tue, 10 Oct 2017 04:40:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D6F3F7EBD6 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH] arch/x86: remove redundant null checks before kmem_cache_destroy To: Tim Hansen Cc: rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com References: <20171008031523.jj63si46bgb27yxu@debian> From: Paolo Bonzini Message-ID: Date: Tue, 10 Oct 2017 10:40:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171008031523.jj63si46bgb27yxu@debian> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Oct 2017 08:40:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2017 05:15, Tim Hansen wrote: > Remove redundant null checks before calling kmem_cache_destroy. > > Found with make coccicheck M=arch/x86/kvm on linux-next tag > next-20170929. > > Signed-off-by: Tim Hansen > --- > arch/x86/kvm/mmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index eca30c1eb1d9..a6c7177326c5 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -5463,10 +5463,8 @@ static struct shrinker mmu_shrinker = { > > static void mmu_destroy_caches(void) > { > - if (pte_list_desc_cache) > - kmem_cache_destroy(pte_list_desc_cache); > - if (mmu_page_header_cache) > - kmem_cache_destroy(mmu_page_header_cache); > + kmem_cache_destroy(pte_list_desc_cache); > + kmem_cache_destroy(mmu_page_header_cache); > } > > int kvm_mmu_module_init(void) > Queued, thanks. Paolo