From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D53C2F0673 for ; Wed, 11 Mar 2026 11:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.180.163 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773229070; cv=fail; b=FhQdWFj+/aFuRizjiK9Ztn0FP6rmi0CngfeQx2bQCxEK7aN9MeYJFZeS/GbBfCXXrZr5ldrS3UoFkZfellAB8VZRcK+pXDmFIfnr8suB4mV+ugqzu9RA+VdiNCZtVXmTk3Bpr7RmcZq1q3NgoYuG6LnC0GQgh7n78S64NqD9SUA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773229070; c=relaxed/simple; bh=9ORy/ihrTzUmDvXkO5CVcDWdK6L+Og1c2J5rTaEfBJk=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=EkwWfPEPLLgDSiLBsJkAc3lzO0czwbFsQAdWuzLipcC90Zzb/h8tfsZPqaMAvNtyKFgHkEO1W7o/nl3n/89ir0Kz9Pt42DFPP1qVUgrqVQ2zrJ1goQmgwCEYl9nP1qopft5ygAgOudXtrI3SYJGiJVAEK0MFHZxtCBhA7HnC8fA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=ToYePn8w; dkim=pass (1024-bit key) header.d=IMGTecCRM.onmicrosoft.com header.i=@IMGTecCRM.onmicrosoft.com header.b=N9tIF5YT; arc=fail smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="ToYePn8w"; dkim=pass (1024-bit key) header.d=IMGTecCRM.onmicrosoft.com header.i=@IMGTecCRM.onmicrosoft.com header.b="N9tIF5YT" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B5tPoG1393193; Wed, 11 Mar 2026 11:37:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=dk201812; bh=2b53eGW+nD2imWrv6yYBLWP4f aNXBt9dtgdnExolHng=; b=ToYePn8wO9XTB0yb1GHBQE4EGlG2FIIcN5nbLFFs4 BRUJDNTUc8s+Q5cm1LsXW6X6unMPEpOc587jv3/7gk7GfsfuIymqsqzoFr7bsG3U /OZcYL4xsZQ/2x2HSqDtAATPHNOrj3g6ZJLWd+vDjN2y+cAdj4mKkxBgxutg4xmc dc8ZvhBfBBxqxAsYDExCzWZG3uiGK+AM2shtcN4Dgarz1YtLXcyJ5gG2Ok962l5t aKCUwsYBk8hiCkF7AV2g9xjGIo+GXbmBnVzqFCp95EUjqk5zYuYjaUpOubxOj9OT aPrbNpZiG4RoEsgb1V+mIcccH/NrQ9J9XmgShd3HzMacA== Received: from cwxp265cu009.outbound.protection.outlook.com (mail-ukwestazon11021085.outbound.protection.outlook.com [52.101.100.85]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxyggey5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 11 Mar 2026 11:37:28 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oCwF75KSXR6DRVKYgGl6mp2tM4ndQL3tgMO1toMuN3l+dhnfWwGqAYBYSlBUIOqOGAjA0JsisINy8VD3b2hwhdbY3o63vaGxrzGKfVti7fUCBqUq8VTBIcKhKkqwDnUXYYl7jRaOvu/19m2OrcKTzbOGP0blxnDuWdlUwiammeZtTzoPGtZYI13kvfQw2C+HalV2yjktHElpW4usQIFRJVlOYdHCITndeEwdoUKvU3/l9pTncNjX8sDSExVeNrKw30OGIxTBjy0ni9JE0iq4UyN2bcH0ryW6vfi/CDTmrh+0esXhprpBzaxxs9k9dXc1XeQUo1SvDQR+E7cXyoiJsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2b53eGW+nD2imWrv6yYBLWP4faNXBt9dtgdnExolHng=; b=cHg7GtOse4PQEBC/xk2mhs3wpgW5tmSMIFcvtW9hqE7wjwtiDLaHpi0luUyLihPTAB2w3N1YC/ondlcRf7k3z17Yxwg7hBfLV1QM46NL5IabFR2bMPUNWi+1ddw3HLe7nCMDIBvWgVghtqL/rDuTtS2wyLle7gOxYthhl/mV+U5Et/9pgSfQAmRy5Ko7Li/IvRISOhOUHKDBndzBgfYvT5EqUN9wV8iBVqWkxBrBjcUYXwGcpLI/jjUQdVF5PhoGEnB7tOWaecNGrd/AGk2gt9KYKxerUy/eXCgh4lu9SiGdhfTc3nwptZLV46jLPZnH9sAP7Ttx9mpe8jyZFuXPwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2b53eGW+nD2imWrv6yYBLWP4faNXBt9dtgdnExolHng=; b=N9tIF5YT+L9vhoKhtkPpeAAJxQV2YldjrsMKShc0IV1qqJHHAEshNNJw1Sa4Wjxh86e69eLYvZQZNvrvBbwWT+yPZqJFto9boc6p7TjM3NetHfszU78rt5nindJXtuZAsZHVyUAIIo68hMczSvRkZSGReJ6is+uLCPgLGC7LvZs= Received: from CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:e2::14) by LO0P265MB3403.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:168::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.12; Wed, 11 Mar 2026 11:37:25 +0000 Received: from CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM ([fe80::f32f:ed34:4f98:6cd6]) by CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM ([fe80::f32f:ed34:4f98:6cd6%6]) with mapi id 15.20.9700.010; Wed, 11 Mar 2026 11:37:25 +0000 From: Matt Coster To: Brajesh Gupta CC: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Binns , Alessio Belle , Alexandru Dadu , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] drm/imagination: Improve firmware power off for layout_mars config Thread-Topic: [PATCH 1/2] drm/imagination: Improve firmware power off for layout_mars config Thread-Index: AQHcrJBAel5RZoI+XkKfB4afOqTlvrWpPbqA Date: Wed, 11 Mar 2026 11:37:25 +0000 Message-ID: References: <20260305-b4-staging-layout_mars_base-v1-0-09831fa17cef@imgtec.com> <20260305-b4-staging-layout_mars_base-v1-1-09831fa17cef@imgtec.com> In-Reply-To: <20260305-b4-staging-layout_mars_base-v1-1-09831fa17cef@imgtec.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CWLP265MB3393:EE_|LO0P265MB3403:EE_ x-ms-office365-filtering-correlation-id: 81bc11f3-b106-400d-7ed9-08de7f629165 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|6049299003|366016|1800799024|18002099003|56012099003|22082099003|38070700021|4053099003; x-microsoft-antispam-message-info: 8yfoB4d0OpZqIGvK/IaeAIQBzO744HZ0WhaDiV7vHRcEQAQa1Eo5OtEK6xn+McFThkQJqv/Y0jjs8IgxHAB1vDHGct9bzlLdGcwZAW7eUZmCHYD1xZQQfceRZFHxmyN8HXlpAlSsu8xvJ6ryifDt9w6v75TJAIbKmpL6pxK0FnMj7tCYAeGk4o6DHjgUZafvbAqQjWFfeH2zFfkrfgrhL6nCetkNnoA+ft1PyhiMbv3+m6+N7a1p2CHzPSXgjpHsv2b/zCMw/fKISfF42c4je9/SLCBL08C2Mmsry16jKmx5dFYXj/bkPSxc6hi31TgdG9byubZjvebp8rbj9GnRiMmtwgrdqKft2b8Dx5JR2iN6jby+2LMgsXwq6o+pOnAgDAMzLIEFkDX6eC/tBu8cxOAa1m7CLvJ1fZ+ClXumPY+DNMmfQ0+MOJWJcfujTlR8BCdRrRXZEDC+ee7gy+FUOrPGdCGFTsbvQg61foTQLRzXPlLspWG3a1SPhb7WTMMqzJxTad3MpOTZGwBmrKvmliOQ04abVPofuPv7VhFbRS5TqHhvnknD4d98LPDY2wJkvRybdD6EGTn0RLcO+/xgaL6Fud1uq9i8E/h1bwyK/4bYXxWnK0shIHgrBeYdEg05NE1R2/+gXr2mhqKsyyTLsrid2DYB3DPGuk3Ma9ohuv+aBGcz8jYdbVFacCcPAmclWNZ0Q4okk8ZIzLg3eue0/af/o9y3YfEtLS9qXt2oNuKmd/OoxwqrTQG7K6njhpB9qoNScEgQ43b/hj0fqxlhg44qCKjW4Ts13e0mdwBl6Cw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(6049299003)(366016)(1800799024)(18002099003)(56012099003)(22082099003)(38070700021)(4053099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dk40YlRmcmV5NVQ4dGZiemZ4TTBpZ2hqY0EvaXZ2eXNoNFNHM1E1ZzZ4YURk?= =?utf-8?B?TnJEOGQ0L09ZRWRRTWJyMkFySTFLenoyUG15MGxvT09VVU9NMk9JNWJvM3Zu?= =?utf-8?B?ZS9DeC9vbUowN0ExOXI0MTRvYUEvVDFDbnJ5RDBMK3E4OTQrKytUZWxwK012?= =?utf-8?B?WUhGUEErdHI4QVhVMVhsa1hyemZzdXZUY0EwQk9mSEhoTm85UlJCTmp0Z3V0?= =?utf-8?B?Z00vK243NXhtckhZYUlNTXYrbFlmSzdVTkQveExmL2NON2NsZDFsMVlNRVdL?= =?utf-8?B?VkFQWG1VM0FSbGFyN0g2WVVUM09udG1CV0pjNUt0KzB5TFN5OHluQzdPZHhP?= =?utf-8?B?VmZ3UE5OUEhicWV0NnhyOVhVMHpGUE5UME1GRVhtbTM4bDgzekdvWEpEUEVB?= =?utf-8?B?MjhYWHFlczJ6MjZSRlJjVE5aU0tTTmZxRE13ZkU2ZEpVZVdOVXk1VDVRVDYz?= =?utf-8?B?dUphdGp3UDdIcDYxZS9WUGlMc2xmaGNIRmVMQzJpa0tCdkNObVhtajVjcm05?= =?utf-8?B?MVA5L1hlSHlkSUdGRGZyU0hneUtZTTd0bUl0Y09aK1M4dWRvbWF1VmRIUFZJ?= =?utf-8?B?QzdqekRRN0pXR1g1dlJxYmtyTXYvY0x4V1ZCT2VGNGxQdXBnVTMzeExoRm5H?= =?utf-8?B?Tzl6cHF2emlHcFg1alhTekplaWRkRCtuRGZqVXg0b1piYnR0RDJrS2ExZCtS?= =?utf-8?B?MGZIWWd5RElUd3ZhdDVibm1wQVVWTWxEdEdFYW5VaFFZNGVPaklmQXpSZTkv?= =?utf-8?B?QVE4WWtnTkdvNGo4Wm1TOExsayt1T3NESHdna2tUMDBGYm5IVE9JNHpsWnNQ?= =?utf-8?B?OG5KVHlTQ2pSN0wzb3NaSFlBSWlyQTFlVDVGT0JwaU8vUXlmM0taelNYVFQ0?= =?utf-8?B?aFVkVlFqam9sd09xYWxjVWk1V29rMzJMUUorbEhxY0RzRmNSVWVOU0pKUitn?= =?utf-8?B?NVJZQnhtR2ZUK1dORHJ6VXlCTm5jYmFUNXRsUDZhSktOZTkvRWp5NkJBWGNu?= =?utf-8?B?RGJSL3J0OHBIem9weDFHWUJ2UGNEcnNPMUhmU0RjRnpVaFR6blNaY0FPMllL?= =?utf-8?B?V2x4VUZRZk9IcGd1c1Z1eFJpcm5CNXFSRUc4OEhmdlF6YlZwYXduOUI3VUpl?= =?utf-8?B?V0ZaNzF4TDBhTVpWVlBnQWJZRlAvMUFpSWxhdExZaEZoVStGV0N2SjRSNVhZ?= =?utf-8?B?ZURKWlVrQVZ5NXNiaU14cHQvNWtmZkdPc1lhcFNNQkRyR0l6MTNNem9ONE5m?= =?utf-8?B?UEZaallTTmxPLzVuNEtWdXg4OFk2MC8rQnY1NE5qaWpKcE9FMm9Pbnl5UVVp?= =?utf-8?B?emZuaVhCY3pRdmRhbk9xUE1OWVpYdzRLbGtmai82VTYwRFNTOExhSjJ2MFVy?= =?utf-8?B?dHJsUnNidng2bUNMcjFIZ2xicWQ1VDhLRkxrMXpHRndjT1Q3dTBhbThDME1F?= =?utf-8?B?RlE4UEpjSVZjUFJkU0lBL3N6VkJxOWRCRWZwSkFmbnRZQnExOUtJN3hsTVFt?= =?utf-8?B?em9WVmtKbU5ZK0xDb3BhaCt1Yit6dngrMGd2ZXNIS1pFRzVtZnpFQ3dDU1BY?= =?utf-8?B?Y1k2Z0VtN1Z1aFEzR2loNmxtRTlvS2ZITDJ0bCtyalYvVTl3d3lVNitnMGJS?= =?utf-8?B?SHdNTUQ4TVZIOStiN28vYUROeHpmaDlyc1FlUkp3Wk5uU2VkSnRiL0hsMld0?= =?utf-8?B?UnZyVDRBTmdlNWxpR3BINHU3NGczUXV4U0I0dnVLUEJTcVZHZFN0NUorclNt?= =?utf-8?B?WGswY0lUdDFheXpZYW05VWFqUW1rQmtJMEhJUXFrZ2IrRDNkZUZUeWNVQmFB?= =?utf-8?B?RHplU050RGhFUzNFaHpsRmpIcXorNmRZOElVdDJtdDcxWEpVdk1uK3pZOEZ2?= =?utf-8?B?dHRTNkR3aFRndGlsb2p2dmpmMzdGYnFwNXdCUG1pamlMVHVsOVFHTEdEVm1S?= =?utf-8?B?OEh1Y2c2SnVsNkFHVzNhb2R1WEc0bTJHMHBXQmFXdTVualFzVzhORXFSb1V0?= =?utf-8?B?OWNDa3U5OHNLc0puVW9wMFdlQmZwb0E0c0NOcTd3bWU1RURlYktkRkp6MHFm?= =?utf-8?B?NjJ6ckxsYjNiUGZCVlI2UHluRG5pd1VvUlE3WHJPbVlncWRlQzFmYjRjdWN2?= =?utf-8?B?dkJqV2l4SHBGUXpJRlVSY2xYN2QwdzNFM1pDU0JoUXZnOXBIdXIyNTdpNFZu?= =?utf-8?B?azB3ZW1zcXNzYjQvUDZiZTM4TVIyeWZLV3g1QUI0clNhUXlzWUYzWTBmZGMy?= =?utf-8?B?QUtIVGliNEFwYmlkL01CZWJQMy90SlVqY0FZa2FtUHdCbk1TbFRTU1VWSndR?= =?utf-8?B?QVlQY2JLRlNFeXRvd2o3YWhNNzczSnJ0WTZ0clI1NHpndVM2T3ZEb29nNys3?= =?utf-8?Q?mdi3zsEyPiUwYEeU=3D?= Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------sIIp8ZkUiGY0ooUXpNdKXEKD" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: ri+psZPXC9SC9mmHp1RkkQiiBgiUGS6LJKXZ4mfbj5ALjSqV3oZZOcqaYW+y47CzlkBDOPxpLJbmr/KJ4cJC635jd3/2xBqWUWoWsGfX8+egYxbqhUt5iz2pfYkhTR/7I5CyA0K98KnfYT2XEMPipS/X/66sIwQP1wI1457ZwTA4lEzFrLeEQ0SG0pcYQ9B3PYiKmNppMsMEK2d89F5U42ROIHfpRyf0UAZFJnOjinHy/BBh5mDWccvWfEJvbWQsYyzkScj5/Jn84GIUIDBwq5HJ/6xmqcjKyk3+kpRdNXuz/thbZanq/GW4CzZ8g3Fi5YgGRbSMiVxyz2ish0xlug== X-OriginatorOrg: imgtec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 81bc11f3-b106-400d-7ed9-08de7f629165 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2026 11:37:25.5829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HPGYQMGfFmlaJz9WsaJyahK+1hGcla+vKzjF4XfJRx8JN6mNNZj1ML8mVv/ewWKg8xi1COG/cPohm04JZr6/Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB3403 X-Proofpoint-ORIG-GUID: jYNRhS2OcU9iIUG2gyWdAYMSmffPFrZ4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA5NyBTYWx0ZWRfXzp+rDrGh6vGn wsrHIam1sACBTmp9OvXv1+b90ymmGUOIVpOFktL0WrCrA4aN04kOEKFbNtJG3PXxEr7nFflzQdt yzd3v7od3edAqCRyp0iUL8h2JLpforvBLtcMIcpmTT4r/+Qkp4igj1uviplOGb6fNa8s1LfKsX3 oPA+s6u+bweeFOIkT86RgyYr1Ch1JP8vz+1sibAE1RWWC85UPB8/ZMlq93uvBMdsLyLJNxSGily jdsin+TmZwykmlXXK6lVg7zEmeD5ask5pHq56C64K877sN9exRjZPhxkyGCsQ5Uq46XDrWJ1RI3 H5tBMUH4/rus2PtHcvgntUL0YfN/fDqsZiBhWwrZGbRr09cqFjXLI3VSleNTgPDuv/3UODh35x3 fhcWlqh3mbCmtPfsrpmgVBsnU7K657rMJuL6F7xzaPYCamYMdVq1YOPT+Y6awtHSdqwJCSNjZhI zJHUrKeLlXEfBFHfN6A== X-Proofpoint-GUID: jYNRhS2OcU9iIUG2gyWdAYMSmffPFrZ4 X-Authority-Analysis: v=2.4 cv=NevrFmD4 c=1 sm=1 tr=0 ts=69b153f8 cx=c_pps a=gcGV6/u4+zGVzz+KJd0EHw==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=NgoYpvdbvlAA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=DhoFW8cXbMnIWbzCb8oA:9 a=QEXdDO2ut3YA:10 a=krqkoVJFrrUXOiIj2iUA:9 a=FfaGCDsud1wA:10 a=t8nPyN_e6usw4ciXM-Pk:22 --------------sIIp8ZkUiGY0ooUXpNdKXEKD Content-Type: multipart/mixed; boundary="------------ydKZKIWYG4rkfpG8vWCotMbY"; protected-headers="v1" Message-ID: Date: Wed, 11 Mar 2026 11:37:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/imagination: Improve firmware power off for layout_mars config To: Brajesh Gupta Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Binns , Alessio Belle , Alexandru Dadu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260305-b4-staging-layout_mars_base-v1-0-09831fa17cef@imgtec.com> <20260305-b4-staging-layout_mars_base-v1-1-09831fa17cef@imgtec.com> Content-Language: en-GB From: Matt Coster Autocrypt: addr=matt.coster@imgtec.com; keydata= xjMEYl2lchYJKwYBBAHaRw8BAQdAOYlooFfHTXzAQ9aGoSnT9JS9wq8xprG+KVLbkxJDF5DN JE1hdHQgQ29zdGVyIDxtYXR0LmNvc3RlckBpbWd0ZWMuY29tPsKWBBMWCAA+AhsDBQsJCAcC BhUKCQgLAgQWAgMBAh4BAheAFiEEBaQM/OcmnWHZcQChdH8KkDb5DfoFAmgHpowFCQlsaBoA CgkQdH8KkDb5DfqxDgEA81pbVLJDmpFyFZLRhAGig9rgoDY6l774yhTzRVm/SvkBAJLzpSlm wyQaQuB668TKOX9XvRLKFGjSq5kkdQcxqjkCzjgEYl2lchIKKwYBBAGXVQEFAQEHQCaVC8X5 7NOv2jNbeXqjP9ekY7rzy7auiEZ5PxaDWUQVAwEIB8J+BBgWCAAmAhsMFiEEBaQM/OcmnWHZ cQChdH8KkDb5DfoFAmgHpowFCQlsaBoACgkQdH8KkDb5DfoK+AD/Q4aN/zUvP72RRE4cNWpM MXeRXg+LTN+OJ24U10LltxIA/2w3kDqMC/0t1oqO8TM+c2LMWO/x2IBkG7oRZ/hVw1QI In-Reply-To: <20260305-b4-staging-layout_mars_base-v1-1-09831fa17cef@imgtec.com> --------------ydKZKIWYG4rkfpG8vWCotMbY Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Brajesh, Just a couple minor comments but this otherwise looks good to me. On 05/03/2026 11:06, Brajesh Gupta wrote: > In layout_mars HW config, Firmware MCU moved from SideKick to new Mars > domain so Firmware takes care of powering down Sidekick/Jones and SLC. I don't know which is correct, but I know we should probably be consistent with the capitlisation of SideKick/Sidekick. > Skip checks for those from kernel and check idle bits for Firmware MCU > and system arbiter excluding SOCIF. >=20 > Signed-off-by: Brajesh Gupta > --- > drivers/gpu/drm/imagination/pvr_fw_startstop.c | 86 +++++++++++++++++-= -------- > 1 file changed, 58 insertions(+), 28 deletions(-) >=20 > diff --git a/drivers/gpu/drm/imagination/pvr_fw_startstop.c b/drivers/g= pu/drm/imagination/pvr_fw_startstop.c > index dcbb9903e791..ce089f51f06a 100644 > --- a/drivers/gpu/drm/imagination/pvr_fw_startstop.c > +++ b/drivers/gpu/drm/imagination/pvr_fw_startstop.c > @@ -208,19 +208,31 @@ pvr_fw_stop(struct pvr_device *pvr_dev) > ~(ROGUE_CR_SIDEKICK_IDLE_GARTEN_= EN | > ROGUE_CR_SIDEKICK_IDLE_SOCIF_E= N | > ROGUE_CR_SIDEKICK_IDLE_HOSTIF_= EN); > - bool skip_garten_idle =3D false; > + u64 layout_mars_value =3D 0; > + bool layout_mars =3D false; > u32 reg_value; > int err; >=20 > + if (PVR_FEATURE_VALUE(pvr_dev, layout_mars, &layout_mars_value)= =3D=3D 0) > + layout_mars =3D layout_mars_value > 0; > + > /* > - * Wait for Sidekick/Jones to signal IDLE except for the Garten= Wrapper. > - * For cores with the LAYOUT_MARS feature, SIDEKICK would have = been > + * For cores with the LAYOUT_MARS feature, SIDEKICK and SLC wou= ld have been > * powered down by the FW. > */ > - err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SIDEKICK_IDLE, side= kick_idle_mask, > - sidekick_idle_mask, POLL_TIMEOUT_USEC);= > - if (err) > - return err; > + if (!layout_mars) { > + /* Wait for Sidekick/Jones to signal IDLE except for th= e Garten Wrapper. */ > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SIDEKICK_ID= LE, sidekick_idle_mask, > + sidekick_idle_mask, POLL_TIMEOU= T_USEC); > + if (err) > + return err; > + > + /* Wait for SLC to signal IDLE. */ > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SLC_IDLE, R= OGUE_CR_SLC_IDLE_MASKFULL, > + ROGUE_CR_SLC_IDLE_MASKFULL, PO= LL_TIMEOUT_USEC); > + if (err) > + return err; > + } >=20 > /* Unset MTS DM association with threads. */ > pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_INTCTX_THREAD0_DM_ASSOC, > @@ -229,6 +241,7 @@ pvr_fw_stop(struct pvr_device *pvr_dev) > pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_BGCTX_THREAD0_DM_ASSOC, > ROGUE_CR_MTS_BGCTX_THREAD0_DM_ASSOC_MASKFULL & > ROGUE_CR_MTS_BGCTX_THREAD0_DM_ASSOC_DM_ASSOC_CLR= MSK); > + I think this might be a remnant from the second patch, can you drop it? > pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC, > ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_MASKFULL & > ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_DM_ASSOC_CL= RMSK); > @@ -270,25 +283,23 @@ pvr_fw_stop(struct pvr_device *pvr_dev) > return err; >=20 > /* > - * Wait for SLC to signal IDLE. > - * For cores with the LAYOUT_MARS feature, SLC would have been = powered > - * down by the FW. > + * For cores with the LAYOUT_MARS feature, SIDEKICK and SLC wou= ld have been > + * powered down by the FW. > */ > - err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SLC_IDLE, > - ROGUE_CR_SLC_IDLE_MASKFULL, > - ROGUE_CR_SLC_IDLE_MASKFULL, POLL_TIMEOU= T_USEC); > - if (err) > - return err; > + if (!layout_mars) { > + /* Wait for SLC to signal IDLE. */ > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SLC_IDLE, > + ROGUE_CR_SLC_IDLE_MASKFULL, > + ROGUE_CR_SLC_IDLE_MASKFULL, POL= L_TIMEOUT_USEC); > + if (err) > + return err; >=20 > - /* > - * Wait for Sidekick/Jones to signal IDLE except for the Garten= Wrapper. > - * For cores with the LAYOUT_MARS feature, SIDEKICK would have = been powered > - * down by the FW. > - */ > - err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SIDEKICK_IDLE, side= kick_idle_mask, > - sidekick_idle_mask, POLL_TIMEOUT_USEC);= > - if (err) > - return err; > + /* Wait for Sidekick/Jones to signal IDLE except for th= e Garten Wrapper. */ > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SIDEKICK_ID= LE, sidekick_idle_mask, > + sidekick_idle_mask, POLL_TIMEOU= T_USEC); > + if (err) > + return err; > + } >=20 > if (pvr_dev->fw_dev.processor_type =3D=3D PVR_FW_PROCESSOR_TYPE= _META) { > err =3D pvr_meta_cr_read32(pvr_dev, META_CR_TxVECINT_BH= ALT, ®_value); > @@ -300,11 +311,30 @@ pvr_fw_stop(struct pvr_device *pvr_dev) > * Wrapper if there is no debugger attached (TxVECINT_B= HALT =3D > * 0x0). > */ > - if (reg_value) > - skip_garten_idle =3D true; > - } > + if (!reg_value) { > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SID= EKICK_IDLE, > + ROGUE_CR_SIDEKICK_IDLE_= GARTEN_EN, > + ROGUE_CR_SIDEKICK_IDLE_= GARTEN_EN, > + POLL_TIMEOUT_USEC); > + if (err) > + return err; This duplicates the polling of CR_SIDEKICK_IDLE. Can you move it down outside this laddered if/elseif block, and make it conditional on a new variable poll_sidekick_idle_at_end or similar? Cheers, Matt > + } > + } else if (layout_mars) { > + /* > + * As FW core has been moved from SIDEKICK to the new M= ARS domain, checking > + * idle bits for CPU & System Arbiter excluding SOCIF w= hich will never be > + * idle if Host polling on this register > + */ > + err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_MARS_IDLE, > + ROGUE_CR_MARS_IDLE_CPU_EN | > + ROGUE_CR_MARS_IDLE_MH_SYSARB0_E= N, > + ROGUE_CR_MARS_IDLE_CPU_EN | > + ROGUE_CR_MARS_IDLE_MH_SYSARB0_E= N, > + POLL_TIMEOUT_USEC); >=20 > - if (!skip_garten_idle) { > + if (err) > + return err; > + } else { > err =3D pvr_cr_poll_reg32(pvr_dev, ROGUE_CR_SIDEKICK_ID= LE, > ROGUE_CR_SIDEKICK_IDLE_GARTEN_E= N, > ROGUE_CR_SIDEKICK_IDLE_GARTEN_E= N, >=20 > -- > 2.43.0 >=20 --=20 Matt Coster E: matt.coster@imgtec.com --------------ydKZKIWYG4rkfpG8vWCotMbY-- --------------sIIp8ZkUiGY0ooUXpNdKXEKD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQS4qDmoJvwmKhjY+nN5vBnz2d5qsAUCabFT8wUDAAAAAAAKCRB5vBnz2d5qsNoN AP947RbCRxsZmqR6tEK5OZIfzAj5tNHUVyrvCPOMp33c3QD+JK7UW+aRLWzKfUCN3nGBXyygdUaQ NRi7zRje3AZ4gQg= =xvNu -----END PGP SIGNATURE----- --------------sIIp8ZkUiGY0ooUXpNdKXEKD--