From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B9A1DED6D for ; Mon, 27 Jan 2025 23:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738021676; cv=none; b=OiPUaf1jgZzpgQStMWLDdcN7Nn2AYx403iLL0kEl6yqX3QXHYilB76zVqu+tdRrS0KP0VTsoDM5MGochRyeI6msk5BYNtdr0vFaPhpP45iSzB6DoWSzO7VJFIIBrJ/kgINZeXqapToCKI2+3sCri6pJDP3igN+gaLjS3zHtWAtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738021676; c=relaxed/simple; bh=ZhTim9zucw235FoWB0yKshnJisPkmKNGRB7FZmrJi8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nmb5mqUI0imVSjtVJU0IN2Oz1hdKO31d1qJAsQ6TpqSw98RlkMOgJu6EmpsbUqJxrDTGWKLNDaB4lMpnK1oj0jhriAirfrEdNh60HuJ3sVMLu0S5m98qfpO+y72C6Tez6X5vf3w//q51IoBS4eE9BtLPEkYrxKY6/+aSAzna2pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=eijv0JFS; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="eijv0JFS" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-29fb5257e05so1583248fac.0 for ; Mon, 27 Jan 2025 15:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738021674; x=1738626474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zj9pcMMVgp4HQXKodFRNu0/WkE6xV+1IDSiA1yELFNg=; b=eijv0JFSzq3H5eSKAC4P2Holwz1lMi0J9GLOCL5jeAHw3etRFXvj0L/mgzjc3hvVaJ ToA34tM/BFhI3N89l4eSI9ndzEsvWoCx8Qmxrudo5saRWsBoF1HSfuHyGUNuORktcEHY 8CUrvedkhqWq2bhcHidlWHaYtClnaokC/kNi5lo+tJfvadyBu2R7fxHNSlGnrMuUwwt/ H906C4c++BGW0cdAQRSztjE1hj2YVtd7BzfGy3OhOJICpjeuTlItWngbFzWF33FunTxU RMev6l8F9lqwGRW9xxcp+sCJ0LPd1qOMzC5fmWO3A9+6EM2wggXGjFaKCE9jx8oBdpjL 7VGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738021674; x=1738626474; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zj9pcMMVgp4HQXKodFRNu0/WkE6xV+1IDSiA1yELFNg=; b=p+BrMKxAPpts5GEyCWX/1OCYF9k6A6ypwshn9NgjxRY8FtNWNwarIOk3iuQAsK1XDo uOOAhpY8yTAGxw4Z9IhWMqmdSSEk8XlF/YIUyIKAtoII29O9guKjKn7Q3C46Aav9r1rh 6WhtVDZR4NCkOa91Xy3RUrW7+0d3oFMzgJTpGCqK5lKWvfM5nRdbB2BdfWFgkgtiplaW sFciM9Y8kIr7s0loTf/JSdTlP2xIqNEw/v/7AMwaWKaJYR8wmQrDyLT5sX5/dbggNPO4 p/qR7aC4XSTOXcQIsRgF39J64dJByuh7gY5HIexxcHbNrWbOJBug/3C11o7N1BKExXF9 5hVg== X-Forwarded-Encrypted: i=1; AJvYcCXYgTdbnNVDuY1DJRZnqnol1mKTkuRew20J13u92cm1BLZIHvHe0z1Jt0izCvO/xWkjYRzznMRf9fvNFTg=@vger.kernel.org X-Gm-Message-State: AOJu0YwNkKRrpzXJdxElBrypllTtj9T+5P9QZkrrdPwrFsk/bOL+ht3y qeBC/xTPmK8zZcXnGp3mjJ+s1j6vyfGRJQDaM1LwTsFoOs5Bk0EeBBWLCzObPpo= X-Gm-Gg: ASbGnctIQDVZhzSGTFP6sG5n5aCj6yfmII0LVEttf4z/2OTKNpQnO6Fe6+EGDteXF+Z jI62bPRjHovgVJ04QnmQb6RNzONQVwgND1on2oOoKLcavTW7SmNEaZwJYbNmpI4oEWnCK4/OiGb jYLC1uMQn8MLU2pC1ACsPcNw5RAgBIp/h3XuAC+mloBfZlIFXdu/hF4zPq9O9HNpQY7GCvGAG57 YhtITzYnxGtxa5o6OABwbqvafw7R9kIMW0dABlLyuZgDEGjm8MSOGLx8JYow8O25kioMle/Rk9f CyORC0VE3S5x5FoMoGgq0mOtZeGnP3shwWKMDFh1B89k+wMbumkP X-Google-Smtp-Source: AGHT+IF/BjQ2vfcU7AR2KFWOh60J8qCWDJIXaHZ5HGLcMJiuX5mst+T96QDPq/tWpXq+LexE1xiBAQ== X-Received: by 2002:a05:6871:2281:b0:29e:2695:5214 with SMTP id 586e51a60fabf-2b1c0c54d73mr22519741fac.25.1738021673942; Mon, 27 Jan 2025 15:47:53 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b28f0facaesm3055861fac.1.2025.01.27.15.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 15:47:52 -0800 (PST) Message-ID: Date: Mon, 27 Jan 2025 17:47:51 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/16] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonath4nns@gmail.com, marcelo.schmitt1@gmail.com References: <8bff69133cddd7e6be714781ea7655a427a6c32e.1737985435.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <8bff69133cddd7e6be714781ea7655a427a6c32e.1737985435.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/27/25 9:13 AM, Jonathan Santos wrote: > When the device is configured to Sinc5 filter and decimation x8, > output data is reduced to 16-bits in order to support 1 MHz of > sampling frequency due to clock limitation. > > Use multiple scan types feature to enable the driver to switch > scan type in runtime, making possible to support both 24-bit and > 16-bit resolution. > > Signed-off-by: Jonathan Santos > --- > v2 Changes: > * Included the ".shift" value back to scan_type. > * Changed the number of bytes from regmap_read instead of shifting the > ADC sample value when the word size is lower (16-bits). > --- > drivers/iio/adc/ad7768-1.c | 73 ++++++++++++++++++++++++++++++++------ > 1 file changed, 62 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index e3ea078e6ec4..7686556c7808 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -136,6 +136,15 @@ struct ad7768_clk_configuration { > enum ad7768_pwrmode pwrmode; > }; > > +enum ad7768_scan_type { > + AD7768_SCAN_TYPE_NORMAL, > + AD7768_SCAN_TYPE_HIGH_SPEED, > +}; > + > +static const int ad7768_mclk_div_rates[4] = { > + 16, 8, 4, 2, > +}; > + > static const struct ad7768_clk_configuration ad7768_clk_config[] = { > { AD7768_MCLK_DIV_2, AD7768_DEC_RATE_8, 16, AD7768_FAST_MODE }, > { AD7768_MCLK_DIV_2, AD7768_DEC_RATE_16, 32, AD7768_FAST_MODE }, > @@ -150,6 +159,23 @@ static const struct ad7768_clk_configuration ad7768_clk_config[] = { > { AD7768_MCLK_DIV_16, AD7768_DEC_RATE_1024, 16384, AD7768_ECO_MODE }, > }; > > +static const struct iio_scan_type ad7768_scan_type[] = { > + [AD7768_SCAN_TYPE_NORMAL] = { > + .sign = 's', > + .realbits = 24, > + .storagebits = 32, > + .shift = 8, > + .endianness = IIO_BE, > + }, > + [AD7768_SCAN_TYPE_HIGH_SPEED] = { > + .sign = 's', > + .realbits = 16, > + .storagebits = 32, Why not make storagebits 16 here? > + .shift = 16, > + .endianness = IIO_BE, > + }, > +}; > +