From: Dinh Nguyen <dinguyen@kernel.org>
To: "Ang, Tien Sung" <tien.sung.ang@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/12] New Crypto service commands
Date: Fri, 23 Jun 2023 02:32:00 -0500 [thread overview]
Message-ID: <e65cd698-3ac5-4eb7-a65c-2647c77af78f@kernel.org> (raw)
In-Reply-To: <DM8PR11MB5735AB9B7112E33B173C4251BE23A@DM8PR11MB5735.namprd11.prod.outlook.com>
On 6/23/23 01:53, Ang, Tien Sung wrote:
>
>
>> -----Original Message-----
>> From: Dinh Nguyen <dinguyen@kernel.org>
>> Sent: Friday, 23 June, 2023 1:37 PM
>> To: Ang, Tien Sung <tien.sung.ang@intel.com>
>> Cc: linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH 00/12] New Crypto service commands
>>
>>
>>
>> On 6/22/23 22:20, tien.sung.ang@intel.com wrote:
>>> From: Ang Tien Sung <tien.sung.ang@intel.com>
>>>
>>> hi,
>>> This patch set comprises updates to the svc driver to add new crypto
>>> services for AES encryption/decryption, SHA2 digest generation, SHA2
>>> MAC verification, ECDSA hash signing, ECDSA SHA2 data signing, ECDSA
>>> hash signature verification, ECDSA SHA2 data signature verification
>>> crypto key management and lastly ECDSA public key retrieval.
>>> The additions of the commands are all standard entries to svc driver
>>> with minimal logic.
>>>
>>
>> I guess I'll ask the same question, who's the consumer for these?
>>
>>
> This commands will be used by the future and current
> downstream crypto driver that is under redesign.
> The svc driver is merely a firmware messenger that is
> used to send Mailbox commands to the SDM firmware.
> It is essential for us to begin doing this first. Thanks
>
I think what you're going to find out quickly when you upstream more is
that the community will not care about your downstream stuff. The
problem I have with this patch is that you're adding code that no-one is
using at the moment and with the crypto driver being redesigned, this
code may or may not get used, right? Let's focus on the getting the
crypto driver first.
Dinh
next prev parent reply other threads:[~2023-06-23 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 3:20 tien.sung.ang
2023-06-23 3:20 ` [PATCH 01/12] firmware: stratix10-svc: support open & close crypto session tien.sung.ang
2023-06-23 3:20 ` [PATCH 02/12] firmware: stratix10-svc: crypto key management tien.sung.ang
2023-06-23 3:20 ` [PATCH 03/12] firmware: stratix10-svc: AES encrypt and decrypt tien.sung.ang
2023-06-23 3:20 ` [PATCH 04/12] firmware: stratix10-svc: increase msg arg size tien.sung.ang
2023-06-23 3:20 ` [PATCH 05/12] firmware: stratix10-svc: SHA-2 digest tien.sung.ang
2023-06-23 3:20 ` [PATCH 06/12] firmware: stratix10-svc: HMAC SHA2 verify tien.sung.ang
2023-06-23 3:20 ` [PATCH 07/12] firmware: stratix10-svc: ECDSA Hash signing tien.sung.ang
2023-06-23 3:20 ` [PATCH 08/12] firmware: stratix10-svc: ECDSA SHA2 data signing tien.sung.ang
2023-06-23 3:20 ` [PATCH 09/12] firmware: stratix10-svc: hash signature verification tien.sung.ang
2023-06-23 3:20 ` [PATCH 10/12] firmware: stratix10-svc: SHA2 " tien.sung.ang
2023-06-23 3:20 ` [PATCH 11/12] firmware: stratix10-svc: public key request tien.sung.ang
2023-06-23 3:20 ` [PATCH 12/12] firmware: stratix10-svc: ECDH request tien.sung.ang
2023-06-23 5:36 ` [PATCH 00/12] New Crypto service commands Dinh Nguyen
2023-06-23 6:53 ` Ang, Tien Sung
2023-06-23 7:32 ` Dinh Nguyen [this message]
2023-06-23 7:35 ` Ang, Tien Sung
2023-06-27 15:17 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e65cd698-3ac5-4eb7-a65c-2647c77af78f@kernel.org \
--to=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tien.sung.ang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®