From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3C03A3811 for ; Tue, 7 Apr 2026 07:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775548246; cv=none; b=k+FS8xJUDivBePx/UUH2pkF92tJr/510pW6OgLPbOqwsOOOMchdn0eiYdjHALBKkdgiBekAcdol5VZFIUKSSsDimoyciCVoiH9V53uyx6owlthDcpcj2alW+C8CYE5bc+3y+wuF52vuA2YMBXj6Q4+1vMXJdP/G506X0uDYv7ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775548246; c=relaxed/simple; bh=eca/h+do6RIFotxCTr+RFfKX/XHK/c61LD6sOoH0Lbs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=G/ljTXeSdgCy986bxB83Em4zjZBHccxRE04VcEjx9Q+5NjFO8AEKrX1gUr+GslJDENf+BJHOw4/igtK6EawgM080r2b+xCjFHFESr/LQ2xIJBSNIFv6LyCD007ztQXy3Ec6QFlZlDc47i/UBc8c93B0qTvAzeygB5FeZbhzWQo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=jXYaPDgB; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="jXYaPDgB" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d029f346eso4009155f8f.3 for ; Tue, 07 Apr 2026 00:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775548242; x=1776153042; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=eca/h+do6RIFotxCTr+RFfKX/XHK/c61LD6sOoH0Lbs=; b=jXYaPDgBLBZ1G3g1Y6Kf5XyM8gGplJIV5qQImv8obKiZzJT6INQrVmZ+z1QrxcmvUp wlxeagStJHxC2Wqe0JiP8RcVs++1SB2HZUmKdY2ZgtHOtm01ki33lOcx2CHX3+biM1ap fZhzPRGXT37Ycz6uFtkh2g+5DV5VW/cYkCz9f2cTiDca7Y1/cUzTb/zTMmVDweRM0OUX 6oDU5tpznRKvApxbkjR6C17FBQi1PD9cg9+phEUooFRBQ85expesGa/FVlEoahtWNoew AXvjx7v/b2FmPTM9susG2/gLD0irlHuCqzX4aR79VRfNSt3QCVi4vbyhIE3Yy7MaUCnr vmyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775548242; x=1776153042; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eca/h+do6RIFotxCTr+RFfKX/XHK/c61LD6sOoH0Lbs=; b=aDyH1dSoyh0J5NUP1mxT7P47AccPgyVkzFHl7z4wa81mxoGWdBmZWisSovCrsS90GH MtdUVHoLgoUCeeEb2gbjP1elauMBpUGgT0oyGg2TgBDpBOQAsaTMZlAUKzUc5Bd4QquC WUOlKrAXIwnnDmknjZMmBZjhVasvkyOKK1AekbPXJn2K10r+mcW/4F5zRp2a9YDtG8qL 2GpwUJs9u9Cju0XqkBINGtGOw6FoWsJQk/V/b0g0WElYiKKVUKr0KRvYoS++YBRoU5O4 jJymctBoddMeJ8KqofbB3haBg/ckxAHNN+z6SfuTiHfxBUH53pf/4dqwalseEpdwQjD6 C6LQ== X-Forwarded-Encrypted: i=1; AJvYcCUAJuZROVOY1e8Bf5TDuhnqpmyAlRsXs4FM40+sd922L08KQt0ebj0nUiGtI2oIGPEiviA9mqtKLxf1AaY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8tOF0y/W9WivY7AMOaYTfaXAqQBgAHK3dwp4mP3bS5omN47lY 6zuv9/W/JtNDEmWJWAkUyZrUtQBPKTHj+20C2GuaU/oZD8LBbwdSdQShDl7iVXrrBdw= X-Gm-Gg: AeBDieu+yGqfCeBtEipIeUHn5hNsR5SpGhSZA3NWvsiOU6pRaWZYYfES9MESEwPfoa3 a2gR6ePu23i2RXGd6lDtQP8X7GS3IMcxX42wQTS7ZdZV8xq6Zu3hdiBnv6NmqnZt+/GWBjzBZyG A059qjAVB1Khvd7xnwOZXslFyoImTwufKdgVBCtQWu5t5bg3ssBFpR02NTh/QwCt60h+lm6nVDf oiiRh4LxxhfprJLlawn3ovjxfHpqVshAauqrBZPH8cxa4JRaQBIB+f0f/QOu5zcaEpu3ft4F96n h4SCNcMxOnlJ2iG9eFbyH3dpOG32FWxq7lgGajIaRH0TTLPQzyKXOR4A4NnemQEwon1in+i26MW lN6YuqaOCCTBdB9aeyKnbE6UtsoUP0i/mKE0YpS7WojJvi6gw6bqc4ZYKLSrj7Ev+A+qk/CsuQA EyykA2Fw26hNxyYQLewZIuJeW2+ATDMtiWXQ2s5M1b/IURPFeHCdvIRCIdrbQ= X-Received: by 2002:a05:6000:61e:b0:43d:1bf6:927 with SMTP id ffacd0b85a97d-43d29295ffdmr22422634f8f.14.1775548241517; Tue, 07 Apr 2026 00:50:41 -0700 (PDT) Received: from [10.87.54.69] (mob-176-247-8-139.net.vodafone.it. [176.247.8.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4e56fesm45883632f8f.27.2026.04.07.00.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 00:50:40 -0700 (PDT) Message-ID: Subject: Re: [PATCH] pinctrl: mcp23s08: Disable all pin interrupts during probe From: Francesco Lavra To: Linus Walleij , Maksim Kiselev , Sander Vanheule , Andy Shevchenko , Mike Looijmans , Dmitry Mastykin , Evgenii Shatokhin , Arturas Moskvinas , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Andreas Kaessens , Radim Pavlik , Thomas Preston Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 07 Apr 2026 09:50:39 +0200 In-Reply-To: References: <20260330161914.1071118-1-flavra@baylibre.com> Organization: BayLibre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-04-07 at 08:58 +0200, Linus Walleij wrote: > On Mon, Mar 30, 2026 at 6:19=E2=80=AFPM Francesco Lavra > wrote: >=20 .... > > This issue has always been present, but has been latent until commit > > "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at probe > > and > > switch cache type"), which correctly removed reg_defaults from the > > regmap > > and as a side effect changed the behavior of the interrupt handler so > > that > > the real value of the MCP_GPINTEN register is now being read from the > > chip > > instead of using a bogus 0 default value; a non-zero value for this > > register can trigger the invocation of a nested handler which may not > > exist > > (yet). > > Fix this issue by disabling all pin interrupts during initialization. > >=20 > > Fixes: "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at > > probe and switch cache type") I realized I put stray double quotes around the commit hash. > > Signed-off-by: Francesco Lavra >=20 > Patch applied for fixes since it's pretty urgent, and it also looks > right to me. >=20 > However added some people using this to the CC so they > get a chance to react before it goes upstream. Thanks!