From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10F641DA23 for ; Tue, 14 Apr 2026 08:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776153885; cv=none; b=JS5pavmXQkFS7ITd/obXc6Pzvap/7SRdQ900ttV6iMBCvTA4Hz1R1vaSjmNcYJl5HK2YN/dWugv6bSMgs1A51fnzJBO7z5xYfK/RZcILI9eNv+nK0YyyhtfewZFpyC4/fIxC7WP5lH8hLvZZtJ74IoaX5lgAXgQFAlJA5Z9OJsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776153885; c=relaxed/simple; bh=GyBY7p8cR+pivlzjQTvfaqKS6RU0U10RRg1Nj6nEYk0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qEYWDmQDxZstSzdw8wNX0x3WsauixJeW0mXl0M7qfn12SN4oQ5XuzxAgFqIg/FyLljZcAGdKWLcKXgiOGu/5mJ+niVUyndIAX9l+BYgXuNzAG/QymRP9dYLaN5iwffDxf/0S8S/FZnHh3Vay5pxJ4Kpm95KKGX4f5r61QL7Dvwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tcurg1Ap; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Tpn/TELZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tcurg1Ap"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Tpn/TELZ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6bKBu3425969 for ; Tue, 14 Apr 2026 08:04:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yTX/7ucEL6ex2fPrlvvCAc7rdkKfuse1roma74lGVgQ=; b=Tcurg1Ap2O9dNPI9 h/XBh4cIqszBiUBsrkgjiE59SocQov4FSIest7Y8tqxzqN6++7QYcV8gJbD2GMfJ 8mv7amPKgBkHJulUFW6TPL5p/0Adgt/8+qZVyMJamSLE2GfcSOQLkxQu6rzk4D+0 ZlqcXN6rZV4pNUw6pPb795JUY7aLfjbHp1ogW52v/G080F8RTH/pM06N4cbU62bf m7XIld+QL7sisoM21qFa0nBuv2KyuiGWgQA7b9cc4qyV1nl8VV2jsNGa5MqLc3si NmK0lc1xHAiDNKsnBOdXSChn3xCN4pLxtCPcimxQ5eIsbo0Q5Bq90wM39o6wKQTW BbQzHw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh87f9q2y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:04:43 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-354490889b6so7658568a91.3 for ; Tue, 14 Apr 2026 01:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776153882; x=1776758682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yTX/7ucEL6ex2fPrlvvCAc7rdkKfuse1roma74lGVgQ=; b=Tpn/TELZ2vkzFw2z6V1XEe57wk0TnrlA6VwRjyQCcajs9C5KShuE4tKD02HOqisP57 4h4jrivLYYqB2pQ0nE8qUOCXe9cM7aBFDYWvVHY+8lhN/RonEJKWIUQ+ejeTx2RXL7jn D4v68A8e3V5BMEKhJmMN2eCQrHPJk7M9TVUeuPBicyQkzlr/zNXn2O1wFDMz9khLTfYN xL/TcXXHKM+XtJzU4hNzEElB70bbZXKv3OJIVvnH5kSX/ia4y8hzeO1z2kG2OylZ+jxn ccMIFhNCbMbn1mTX18rGMgLoURsiTZISy1inJo3eqoY7pO3emOdBeQfAQGYCaDDUpoDz p6XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776153882; x=1776758682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yTX/7ucEL6ex2fPrlvvCAc7rdkKfuse1roma74lGVgQ=; b=grfRDynW6tGWFRN08rg5DHJXyvSKV0aNmMDucs9Xie9SSRnWpRhYA1wSzw7ElSZElc ppEg3PpBRwnWotH8Rcy64vBdbh6e5n3kcKjqjacHR4R9Do9q3ZptF/K3CUcyr6qq600G xp7cUJi8lxLUzGtbigs3hWlZsgx5Dg+L0MYmeCSCqC3wV91dGuSP6lKM70ZUQfN0++Gx EFJU0WneY353T0BXr48ENheQqtC2LouZFltYyGa9+MJKp0hULMC/elOzARfz0mgfsQaZ /FSOr0q1adyJBiKBjJFEwhbAwPziejSksP1pAwPRPDBTQaWN2r+tD1jIMlOG1tFasdys ExJQ== X-Forwarded-Encrypted: i=1; AFNElJ/pUTswjb9g5lxq6HFx64aVPjBJBwrwBLnfBqh+ApkoSsZpbfZVDnLehPORpgXFC1S1nivflWYPHr2YF7M=@vger.kernel.org X-Gm-Message-State: AOJu0YwGTUe0ZxgrA7XLg1eSqEFSOthEpdS6VIg8Pqch0w3d9ViEeh9e BgmDeFmnr4M0uhYpZVYGWY/w4SIqXAQXlaHT9V2ZzJWtJWHDQ+X+k/V1u8caFEX3Ta5RNMikaHc wSCdV5zb59qjBQE/qeTtma0wRovBAkvuvq040WiR8yQldHvZSqadX2elY6yhtGjfBZ/M= X-Gm-Gg: AeBDiesUL81rIvmCI6Y/DpKxo0K+08ro9i5iJQiarSUFh66yEyhGYcHCLyCcYqBDEoZ mctg5mK2NWHGjDdI3WrnVa42DADQcEbPJ0va1XS70/Vq6ZY9cbmGFIiHM22UoQaZJ2kP4u0ulF2 HpCgd51H+rl+qNZe4s1Cs6V6LL+VW92zUzwmrRsqjOc5kZiESJJfTgR9n0c5icJezmXt3a8eJn+ Sw4Px40hPV82ru+Dl19meUSzQE6K38MAQNOcBCGhh/4kpP8h6ksqOtlTMzx4CE1iHOJ+X6Z+JX6 hoV5iW9x5d1SK722R4oTkgT65Opm6PyDcMalGjl5vJ/4GknAIOnCGuBu32niqmGh5/Z+xgbBCgx 5rcO9RhNr1wUwgdRdIejvwcv6TkVKzY89MXrbWBkK/WyfbSvcX80bvixEyhEEEXZSYxCPmtUnDm HjlElBaMxREA== X-Received: by 2002:a17:90b:1d8a:b0:35e:3e86:e2d3 with SMTP id 98e67ed59e1d1-35e42777a47mr17421185a91.10.1776153882494; Tue, 14 Apr 2026 01:04:42 -0700 (PDT) X-Received: by 2002:a17:90b:1d8a:b0:35e:3e86:e2d3 with SMTP id 98e67ed59e1d1-35e42777a47mr17421164a91.10.1776153881943; Tue, 14 Apr 2026 01:04:41 -0700 (PDT) Received: from [10.133.33.11] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fc6e8ae9bsm1165923a91.1.2026.04.14.01.04.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:04:41 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 16:04:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] coresight: etm4x: fix leaked trace id To: Yeoreum Yun , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com References: <20260413142003.3549310-1-yeoreum.yun@arm.com> <20260413142003.3549310-4-yeoreum.yun@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260413142003.3549310-4-yeoreum.yun@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3NCBTYWx0ZWRfX5nN8Lq1+N4Fc /Zs96yVk8pRHhHJr1SVX+Lx/CtBZDv0kyxD9LmkUW70skq8Eo6B/XSXUTJwInEqZATZYXbMXGv0 5uz8bAi36vnXs2V6d3HFLp/dedbk6O3RAWucg9dzWFZ7D1pVCL3+4Zb00MalVuf2/5MsOIY+wdj /di47sEw1mGSVojRDwuU1MojKeP7pkCNTTgbCTdbTozuvxbmxglgZndJ0uP7gN87okROzhu0whg L7y2fsL9R90g81oI/dGIA5I2j1AsSDf5oRdgFOcrdw1Hez7kTbWSgoXeWT7Hu/KaCSg1ZMo5vCn MVcwplpyTXFbzN7fx7GW1tyc+FsamQfBrIYgFsV67kSrt/7z4rDbHCK/xDhtEN1qpnp7/95CfA4 vaLZjdQEZe0fyCM4wR1TO/vcQTgRQz8+obYfFy1sTWiKbhhBNPt7XZmVMvVmquVU4HEmuZ2ZHOx 5Iws8qCnGeO+0wwkyBA== X-Authority-Analysis: v=2.4 cv=DaYnbPtW c=1 sm=1 tr=0 ts=69ddf51b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=7CQSdrXTAAAA:8 a=gFnN8SiNFoKemXR6UKMA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: ESuAV3FL5aRYGfPS_p5vP2b_SXLSyv6B X-Proofpoint-ORIG-GUID: ESuAV3FL5aRYGfPS_p5vP2b_SXLSyv6B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140074 On 4/13/2026 10:19 PM, Yeoreum Yun wrote: > If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(), > the trace ID may be leaked because it is not released. > > To address this, call etm4_release_trace_id() when etm4_enable_sysfs() > fails in cscfg_csdev_enable_active_config(). > LGTM. Reviewed-by: Jie Gan > Signed-off-by: Yeoreum Yun > --- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index 8ebfd3924143..1bc9f13e33f7 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -918,8 +918,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa > cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset); > if (cfg_hash) { > ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset); > - if (ret) > + if (ret) { > + etm4_release_trace_id(drvdata); > return ret; > + } > } > > raw_spin_lock(&drvdata->spinlock);