From: Pavel Begunkov <asml.silence@gmail.com>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
linux-kernel@vger.kernel.org,
Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH v2 net-next 06/11] udp/ipv6: optimise out daddr reassignment
Date: Thu, 28 Apr 2022 14:58:01 +0100 [thread overview]
Message-ID: <e66e22f3f148e3bd5911fe4483af39088a74e684.1651153920.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1651153920.git.asml.silence@gmail.com>
There is nothing that checks daddr placement in udpv6_sendmsg(), so the
check reassigning it to ->sk_v6_daddr looks like a not needed anymore
artifact from the past. Remove it.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
net/ipv6/udp.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 1f05e165eb17..34c5919afa3e 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -1417,14 +1417,6 @@ int udpv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
}
}
- /*
- * Otherwise it will be difficult to maintain
- * sk->sk_dst_cache.
- */
- if (sk->sk_state == TCP_ESTABLISHED &&
- ipv6_addr_equal(daddr, &sk->sk_v6_daddr))
- daddr = &sk->sk_v6_daddr;
-
if (addr_len >= sizeof(struct sockaddr_in6) &&
sin6->sin6_scope_id &&
__ipv6_addr_needs_scope_id(__ipv6_addr_type(daddr)))
--
2.36.0
next prev parent reply other threads:[~2022-04-28 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 13:57 [PATCH v2 net-next 00/11] UDP/IPv6 refactoring Pavel Begunkov
2022-04-28 13:57 ` [PATCH v2 net-next 01/11] ipv6: optimise ipcm6 cookie init Pavel Begunkov
2022-04-28 13:57 ` [PATCH v2 net-next 02/11] udp/ipv6: refactor udpv6_sendmsg udplite checks Pavel Begunkov
2022-04-28 13:57 ` [PATCH v2 net-next 03/11] udp/ipv6: move pending section of udpv6_sendmsg Pavel Begunkov
2022-04-28 13:57 ` [PATCH v2 net-next 04/11] udp/ipv6: prioritise the ip6 path over ip4 checks Pavel Begunkov
2022-04-28 13:58 ` [PATCH v2 net-next 05/11] udp/ipv6: optimise udpv6_sendmsg() daddr checks Pavel Begunkov
2022-04-28 13:58 ` Pavel Begunkov [this message]
2022-04-28 13:58 ` [PATCH v2 net-next 07/11] udp/ipv6: clean up udpv6_sendmsg's saddr init Pavel Begunkov
2022-04-28 13:58 ` [PATCH v2 net-next 08/11] ipv6: partially inline fl6_update_dst() Pavel Begunkov
2022-04-28 13:58 ` [PATCH v2 net-next 09/11] ipv6: refactor opts push in __ip6_make_skb() Pavel Begunkov
2022-04-28 13:58 ` [PATCH v2 net-next 10/11] ipv6: improve opt-less __ip6_make_skb() Pavel Begunkov
2022-04-28 13:58 ` [PATCH v2 net-next 11/11] ipv6: clean up ip6_setup_cork Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66e22f3f148e3bd5911fe4483af39088a74e684.1651153920.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®