From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE60C6FD1D for ; Thu, 30 Mar 2023 14:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbjC3OLh (ORCPT ); Thu, 30 Mar 2023 10:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjC3OLf (ORCPT ); Thu, 30 Mar 2023 10:11:35 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0786B3 for ; Thu, 30 Mar 2023 07:11:33 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id o32so11008717wms.1 for ; Thu, 30 Mar 2023 07:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680185492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+/11lbx2+OLsP5+4dMf0d4+77ejtkZtCxn73BU3ygIA=; b=hHjrk15GcvrQeufjkpCutHUhQG02cItQfcmF1eCByAc5XP/3GRJ3l+/Z5DqtxBEpzo vSjKRI4KxOkNLJfwrBRBPCM3jJqrNGioGh2W6VOtTnAKcjyIaPGCsb8y9oxGycPYHD9d R0mHuIILIRhID4cmurz77CsOeN95ATFZet0cca6to3YDoqyHE5E0PWOt1uz//rDLNQPw f8SS9FRgCMPUBCYipLifK2+sXSCA/XNIjVdTLMTQP3CGbSoTtf5xp475GCWFDsO5Phgg 7h6onpoZfL8r9xvMceXS4dGp0LssRSROyideVcC79VX2uppc/ts7Wul6RcYBxAlzUdJd Nmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680185492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+/11lbx2+OLsP5+4dMf0d4+77ejtkZtCxn73BU3ygIA=; b=7fAtKeUDsW5kpZgV5Lna+wy5fGPrSMLBvKDk/xpRD6V+6HNof9NkTvQQTapH7uX4+s l3Md4DKozcVs1M6TLdANeviKWSctq0UtG+ncXDQe4ZNQCF+NL9Ox0FRuiplilmL+ftcI kylsvQDY2QenlXFJ6F/H9CPzh5Iw4NoX+PULDtMO2RtUeeBpBRkflqeorq+HVGBsL/zz K+vJ9Wy4YfzThemH38uP3Ci7eYdpl8votIgJ5r/jZ/lr7CXHh4sbHXfDFgHeYb4D69rB IUNVyqGyKHCuG8NxNRWjxTUPBwp5QwEG+nV4lauyF2AqPRdE/ag2dcVMJUXsjPZ8DpKB EuEA== X-Gm-Message-State: AO0yUKWa86kJaZvGMniFZikvN64o2Vnt7PZcaut5ksmn4WVCF5FsCQev W+z4jeT+YwOPGr68e5wF1fA= X-Google-Smtp-Source: AK7set+0v3qdSi/olNwk5smzxmld9SdjfWJXtXnVbwWl/UlS7cLg4FLwT34Cf0kqEwRjVI7Gm/yaYA== X-Received: by 2002:a05:600c:2049:b0:3df:e6bb:768 with SMTP id p9-20020a05600c204900b003dfe6bb0768mr17449957wmg.24.1680185492312; Thu, 30 Mar 2023 07:11:32 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id b5-20020adfee85000000b002c573778432sm32761705wro.102.2023.03.30.07.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 07:11:31 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: hvaibhav.linux@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alison Schofield Subject: [PATCH 1/2] staging: greybus: add a single exit path to arche_platform_wd_irq() Date: Thu, 30 Mar 2023 19:11:24 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org arche_platform_wd_irq() function has two exit paths. To make the code more readable, use only one exit path. Suggested-by: Alison Schofield Signed-off-by: Khadija Kamran --- drivers/staging/greybus/arche-platform.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index fcbd5f71eff2..a64c1af091b0 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -153,6 +153,7 @@ static irqreturn_t arche_platform_wd_irq_thread(int irq, void *devid) static irqreturn_t arche_platform_wd_irq(int irq, void *devid) { struct arche_platform_drvdata *arche_pdata = devid; + irqreturn_t rc = IRQ_HANDLED; unsigned long flags; spin_lock_irqsave(&arche_pdata->wake_lock, flags); @@ -180,9 +181,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) WD_STATE_COLDBOOT_START) { arche_platform_set_wake_detect_state(arche_pdata, WD_STATE_COLDBOOT_TRIG); - spin_unlock_irqrestore(&arche_pdata->wake_lock, - flags); - return IRQ_WAKE_THREAD; + rc = IRQ_WAKE_THREAD; } } } @@ -204,7 +203,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); - return IRQ_HANDLED; + return rc; } /* -- 2.34.1