From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B88873093AE for ; Wed, 3 Sep 2025 13:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756906695; cv=none; b=C/fGHfvugQTnsLZKnugOlXiJmjKxPDmpZEuyMlZoeaHtKkCfBneLQ4OUnXZVorFCebF8K8DQHJ/NmgfsBwon+ju7ehgfvDqua0De2fm7t+HXmC1LRWmYSCiGiih9AHZsOabUSuhJzB8Nfe5BtQNolDSfiihsktWAMQA7EouZqhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756906695; c=relaxed/simple; bh=LOn4lvVTz9RolUVuFrhuGbcWkHCfxy2FGtDMv4SJQ+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MUu3s4VJEvpK6FKfGozErQh8cjZ9O+rgz+ZD46XeKMnmzqfTI6PQ1cwq2DwCyWUgurqsuERystnbs0uESPXhxaC1YB+saK0VMBApcn9v6Rjmw5DHm98xDk6mMUTKod+Mq34tbq9XtKwbXYgz+00TuqBFjZui2Ugb883e1CdWcFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UpmHgTXV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UpmHgTXV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 583BF4GN004619 for ; Wed, 3 Sep 2025 13:38:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +aXgx0C/TKBcTy6Wyua/O23sUvaZBDBg9e7hKnXJ9Os=; b=UpmHgTXV3+w3B4pt cREBVJYCxm0fGIOPXLriIEv6OMHG7Lal57rwNw+rbkwTCxBLFLJdPLdzXLiaUj35 GcqpHQ92FITlQTgIY7urCVhiTjyJUOnmVILhH8Dgf1P7FdMZSbCIc4Nw4ancUIj/ fDBk4mHUNyc/WTu87Kw1YwaFjssHcL1pVnnL0BYR/AK/tcJtfmfWS+sUpoc0DHsJ ZsVKGYTeG9J+x3KCFGj1so4SyqRvPZm/nL+IjU5Z0rJXw4BKysDU1ggGiuCGTdfR RjUxCgCcbI7OOwMYKFBkRQAJup95hfuAoAGVodfHlOBto5S+9tM1tB9ko0F4wBHb zHizJA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48upnpc06e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 03 Sep 2025 13:38:12 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4b4bcb1e32dso876801cf.1 for ; Wed, 03 Sep 2025 06:38:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756906692; x=1757511492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+aXgx0C/TKBcTy6Wyua/O23sUvaZBDBg9e7hKnXJ9Os=; b=aWUX4wxdQ3T2Vv7NYK5e4VcRxPSLtDafZpmV2tdKUW887Lzc/q7uXSSPAwwOoVHvrv kH9mozDla9EYKrlUSkmKrzAyyGpbeGxjsujmehS6a5cFnIuEQsT2qQJ8PmFJxHZ2Dn+G TGKfEcrMnYpkEJOoLLD+rbFSSlm06JGPA+a+RmsnwnWDSmxDHToLByUD//EsdiajcIu1 v9CSpvNaCY97DBbhMCiW+7dnAz79Dq4B68SjRLq1+PiI980kpwF0sY3FD+nvO9lkeT5s 5DCi0JuxxNKJnbAPZniGoe59O4mtZRLBxKbLLdNFk2I1SqCgfkqzg5fWsJW0SfTx9J90 e3hg== X-Forwarded-Encrypted: i=1; AJvYcCWCa9tlNX3asHk8JZUYKvAMDuBlB/TKHtOIxvVjbxGqE9GsKhJkpE3RYsMDHsh9TreIDV5TmcReiyVHKHo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8AkOI8cyvV8L+/uoEzriBfZse9CX3PxTbc7v+RJB8jBxLBbr0 MkLnaQvkLcVT28/ep1R2w3yzNQVdHUPoGXnAmzzIgUTRdMhwab9Mynd61Z1C1T65nCeYYHqy+4F 0KOGlIVZn77MNXHtOI561+NMreS7YuNLQWwZhqGHCans8LtIAbfxxYck7YXUGdh0O41U= X-Gm-Gg: ASbGncvpA3rCG/L085boK4dydf0ii0RDeTCtG6sc1SNcmKvWTGL53ljCPXZmj/200Su hI5RhKYYJyyaFx5lL4AQCbjm+X794/EKwApeS6xXZ5lQ+/Rx337wE5AMLZhpCeKd9dTsDOKoGFu VfmuMQO6l023EY3ESYVkBiDErfTGXF9opRHNcEHHoskugmHZXoHzQBQHIw/4yxcEoV6YpYIhE/C 4JJC81JOdgFl6m3a2JodaNOxtuBpiNxKGAagRe4pKKMXx/XkG3nuNc/0mGUmDPStz58Fv1b1bdB /2U6J5oFisxGw+xMyqMpZv/Z/FvFkCtcR7g4Zbyc2eQ5tZiI3+p2YFiNusMrlkZWtW88z3e0Puj Triz8eD9UcMVqz4QjNrWKdg== X-Received: by 2002:ac8:5e06:0:b0:4b2:f5a8:21da with SMTP id d75a77b69052e-4b313e1a3c7mr154164531cf.5.1756906691908; Wed, 03 Sep 2025 06:38:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHctp8klVVlJwh/I9Cv1/2OINdIX9gzROyxCMvF3SPTjSmgb2xzFihn2uTLcDdSBJMQgIRRKA== X-Received: by 2002:ac8:5e06:0:b0:4b2:f5a8:21da with SMTP id d75a77b69052e-4b313e1a3c7mr154164281cf.5.1756906691437; Wed, 03 Sep 2025 06:38:11 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b046aa92242sm149794966b.59.2025.09.03.06.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Sep 2025 06:38:10 -0700 (PDT) Message-ID: Date: Wed, 3 Sep 2025 15:38:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] phy: qcom: edp: Make the number of clocks flexible To: Abel Vesa , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Sibi Sankar , Rajendra Nayak Cc: Johan Hovold , Taniya Das , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250903-phy-qcom-edp-add-missing-refclk-v2-0-d88c1b0cdc1b@linaro.org> <20250903-phy-qcom-edp-add-missing-refclk-v2-2-d88c1b0cdc1b@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250903-phy-qcom-edp-add-missing-refclk-v2-2-d88c1b0cdc1b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: WvYAtOCQajJRNhzxF19yx5C17sxWJWT5 X-Authority-Analysis: v=2.4 cv=Jt/xrN4C c=1 sm=1 tr=0 ts=68b844c4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=JahnCVLux6B-E1IX8mMA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: WvYAtOCQajJRNhzxF19yx5C17sxWJWT5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAwMSBTYWx0ZWRfXxm7GpEE8Hy9A EHFs51XX45kc0/PYVGmVSML1OwtkbE46lZEEm6pNIVywjwriuvCbz2hhaSalSPCPrdVZ1rU2AzE Ttd+Y4AgHCOSKyfU1Z2t3ll1107PJneAzOqanBJg3BSmaIcgYxF0u+SBCpw5DuTNcTJgWzqclom lWX3FJ6fLGQjkowdmcavQqrko4DeVtoTleXHVrjCmbYSnbB/pGT3T/rAezre5wBy98DRl9V5Iei F6KrfNVuoogAWcdcBFU6Kdvuy9ofYsfX1gx1P6B6Sip7VrKly0UcZF9RNObku/kC1kl/oLRXA+C DoK1L/A30J6/N751ewnVHQD4LZ3x4+TnMlP+jXOSMr+gjT+GpXtXJU7yf1WLWQ0/EZx/BV8LNnq UKc2fYqZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-03_07,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300001 On 9/3/25 2:37 PM, Abel Vesa wrote: > On X Elite, the DP PHY needs another clock called refclk, > while all other platforms do not. So get all the clocks > regardless of how many there are provided. > > Cc: stable@vger.kernel.org # v6.10 > Fixes: db83c107dc29 ("phy: qcom: edp: Add v6 specific ops and X1E80100 platform support") > Signed-off-by: Abel Vesa > --- [...] > @@ -1092,11 +1094,11 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) > if (IS_ERR(edp->pll)) > return PTR_ERR(edp->pll); > > - edp->clks[0].id = "aux"; > - edp->clks[1].id = "cfg_ahb"; > - ret = devm_clk_bulk_get(dev, ARRAY_SIZE(edp->clks), edp->clks); > - if (ret) > - return ret; > + edp->num_clks = devm_clk_bulk_get_all(dev, &edp->clks); > + if (edp->num_clks < 0) { > + dev_err(dev, "Failed to get clocks\n"); > + return edp->num_clks; return dev_err_probe(), also please print the ret code Konrad