From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108AbcKWC7d (ORCPT ); Tue, 22 Nov 2016 21:59:33 -0500 Received: from mail-pg0-f45.google.com ([74.125.83.45]:35720 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbcKWC7b (ORCPT ); Tue, 22 Nov 2016 21:59:31 -0500 Subject: Re: [PATCH 1/2] PCI: iproc: fix 32-bit build To: Arnd Bergmann References: <20161122141844.1655574-1-arnd@arndb.de> <4393833.rTFctaL9Kd@wuerfel> Cc: Bjorn Helgaas , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Oza Oza , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Ray Jui Message-ID: Date: Tue, 22 Nov 2016 18:59:28 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <4393833.rTFctaL9Kd@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2016 1:13 PM, Arnd Bergmann wrote: > On Tuesday, November 22, 2016 9:42:05 AM CET Ray Jui wrote: >> >> Hmmm, somehow we've never seen this link error for the ARM32 based >> platforms that we build for. Does it behave differently between >> different versions of compilers? >> >> Nevertheless, this is a good change to take, thanks! > > I looked at it again, and see now that it only happens with > a 64-bit RESOURCE_SIZE_T, which is only used on 32-bit > platforms with more than 4GB of memory addresses. It would > however show up in a multiplatform distro build for ARMv7VE, > so the fix is still clearly needed. > > Arnd > Yes, got it for how it showed up in your environment, :) This change stands good as it has been. Thanks, Ray