From: Johannes Berg <johannes@sipsolutions.net>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/3] compiler-gcc: hide COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW from sparse
Date: Sat, 17 Nov 2018 12:29:12 +0100 [thread overview]
Message-ID: <e6910a457e75e240e18ed395ccb2f960dda6fc94.camel@sipsolutions.net> (raw)
In-Reply-To: <20181117004209.v67yalpxuswhs2vr@ltop.local> (sfid-20181117_014213_396373_F28FF538)
On Sat, 2018-11-17 at 01:42 +0100, Luc Van Oostenryck wrote:
> On Fri, Nov 09, 2018 at 10:35:32AM +0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Sparse doesn't support all the overflow builtins, so just hide
> > them from it to avoid lots of warnings/errors reported by it.
>
> The development version of sparse support these builtins
> since their introduction in the kernel and sparse's main tree
> have been updated (very recently).
All the better, but I certainly checked sparse git before even
considering this patch, so saying "but it's all there" feels somewhat
dishonest. Also, the sparse repo is 'backdated' to the end of October.
I'm almost certain this wasn't present when I sent the patch.
However, it would be nice to be able to use distro sparse versions, so
not sure I fully agree that we shouldn't apply such patches.
johannes
prev parent reply other threads:[~2018-11-17 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 9:35 Johannes Berg
2018-11-09 9:35 ` [PATCH v2 2/3] kernel.h: hide __is_constexpr() " Johannes Berg
2018-11-17 0:45 ` Luc Van Oostenryck
2018-11-09 9:35 ` [PATCH v2 3/3] slab: use logical instead of bitwise operation in kmalloc_type() Johannes Berg
2018-11-09 18:53 ` Andrew Morton
2018-11-17 0:42 ` [PATCH v2 1/3] compiler-gcc: hide COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW from sparse Luc Van Oostenryck
2018-11-17 11:29 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6910a457e75e240e18ed395ccb2f960dda6fc94.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®