From: Anton Volkov <avolkov@ispras.ru>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: Re: Question about apds990x.ko
Date: Thu, 10 Aug 2017 18:11:44 +0300 [thread overview]
Message-ID: <e691e344-c24f-e177-0ab0-1e1d39b5c573@ispras.ru> (raw)
In-Reply-To: <20170810150755.GB8851@kroah.com>
The author of this driver as well as bh1770glc.ko is Samu Onkalo. His
e-mail that was found as a contact in the module's source is invalid. I
tried to add him previous time (Question about bh1770glc.ko). The
message was not delivered then.
On 10.08.2017 18:07, Greg KH wrote:
> On Thu, Aug 10, 2017 at 05:57:30PM +0300, Anton Volkov wrote:
>> Hello.
>>
>> While searching for races in the Linux kernel I've come across
>> "drivers/misc/apds990x.ko" module. Here are questions that I came up with
>> while analyzing results. Lines are given using the info from Linux v4.12.
>>
>> Consider the following case:
>>
>> Thread 1: Thread 2:
>> apds990x_suspend
>> apds990x_resume apds990x_irq
>> -> apds990x_chip_on if (!pm_runtime_suspended
>> (chip->client->dev)){
>> -> apds990x_configure if (status & APDS990X_ST_AINT) {
>> chip->again_meas = 1 chip->again_meas = chip->again_next
>> (apds990x.c: line 571) (apds990x.c: line 505)
>> }
>> }
>>
>> First question. Is this race feasible from your point of view?
>> Second question. The check for the device suspension status
>> (pm_runtime_suspended()) is present in the interrupt handler, but the
>> functions pm_runtime_set_suspended / pm_runtime_set_active are not used in
>> apds990x_suspend / apds990x_resume respectively. Do you know about any other
>> method being used to make the modification of suspension status?
>
> No idea, sorry. Maybe the driver authors know?
>
> greg k-h
>
--
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avolkov@ispras.ru
prev parent reply other threads:[~2017-08-10 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 14:57 Anton Volkov
2017-08-10 15:07 ` Greg KH
2017-08-10 15:11 ` Anton Volkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e691e344-c24f-e177-0ab0-1e1d39b5c573@ispras.ru \
--to=avolkov@ispras.ru \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®