From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8280F2D060C for ; Tue, 27 Jan 2026 03:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769483012; cv=none; b=u+VIngnjj9JkIMR9rerc7vZtjbuQoAwENHqHwyLRZmT2GJt6ATlk6DJfwTWjjXJeaXbRRZFjXUPOqpyzOUlPxv8aOgUGtG6/WmiEZ9zsWYTKmXWbIZmaWQv2yrEO75RlMEFZ+5dsx2rNj35DqRcXRcW3gJ6CP+7MktYFohhf7M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769483012; c=relaxed/simple; bh=GmNqDG50C5kjAf+rA5TEiGCcffG33TrUgVO4YyDdmSM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J9ltZ/nq1QYF6F+KsXUPCKmTLi3AEFaLkxQKEnrXZZMOdfF4U8cNlV3bpU6i/3W5QVTYaxSrsUS2fKCCsxUQ9RaAC9GKQ0hTdgYQDS2X2ewFxWTXr4YC2FP6FM+vdcJHMmzCsn5mk2yth4Ij2CANOWgUx7xyIckkFEnXSGBwpnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hP80O4ut; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QmoSDQnP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hP80O4ut"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QmoSDQnP" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60QKgIwe3384255 for ; Tue, 27 Jan 2026 03:03:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YnAwXWL3GpUOqmGUJiuTdNi//qtxXIIbE2DSDpIS5lU=; b=hP80O4utmL7254mA D9x4+vXrJ0TYoP5rgBv7lO4xDPt3MrB9lML2F27eyjGIC9zyLD9K06Eob8zT1/yG sj2P6uhHe0PIr3U4yqWF0Dm5rmluIt9sWf5heQGP0hETp7rWqtNs97iqFFFtUs5j g0b/dbjwfPTRypwWCc2+Da+efV00ms5RDI+FBjb+Lu8nQ86fX5cWtTS16QBYdVso mvWDOmGWmtbKWJ+gAt+OH9UDcAcsAHfgaHUaHz04DGxqSed2rdsJxY9+ak09u3G4 NeJOGyKofd7lKyV9vlEtVRNPH877f5LHMhf6Hl5u99/nmGV2+ci+GpA1xz+3bWcO w1ElOA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxf3a0xm8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 03:03:30 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34ac814f308so400217a91.3 for ; Mon, 26 Jan 2026 19:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769483010; x=1770087810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YnAwXWL3GpUOqmGUJiuTdNi//qtxXIIbE2DSDpIS5lU=; b=QmoSDQnPdgD7eDCxumHRzhtmV6V2ZYNuAn80odsc0S/K1RORKvwXw00sB/HzAZLBn4 fsBom74r1l+RvFCbRIRzEl3JCt9JgYaWgD2aaPUx81vxDbv9xCF/ubCJqjm42OLebZ9y GEXe9oqTP0p/cxU3LeQK+7DZMsUeQ8N8rnJI+Ni6NOyN0VVQRwZYm0BeAoc7aePkDit1 K9q8HgJtIdx/lNkHdnGQ24daeIXOnNcokri+j6GsXFuSX6TnFLrq2CnNSa9iCjFVJbAm wxuYNrHuj/MtHu0WsRqSQ9F0hQftr/Bf1BCH7RL2bprktvFuq+YklcjIMdey65fmqmhv et6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769483010; x=1770087810; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YnAwXWL3GpUOqmGUJiuTdNi//qtxXIIbE2DSDpIS5lU=; b=qsc11Y3sr2ft6JpgSCgdfXBPvQ6nNo8kyOIDwjYiyAluiN+fUWVnvL5Sy6MWgYBopg DCQerHegyP6RH0iKPss+qQbZE6DTDNXI4CeAIU5Q+vym41uDxOog10myAN/sHwCor75c o14pUMjNLOn7N7flmWJe35ikM+PpsiVIDjOi3lWQFKabPRBDm+qhBN8ijQO2K6QZhOBa yu/V2jDiGNyqM90zAcCGS19Q6537FCUN6bg/WzdhJ4mQ4mYbGvmP56Sejs/LMIUaf/WJ NJ/pK/W6KvRtDYRnPYJyiFmAe68wCFEU64MI59JAr4jE8Mdow/FTGJHZamQaXy7b5y2K P4lw== X-Gm-Message-State: AOJu0YxzvqHpJRnlybX1JqCJ76lL1NUFLuzoeaCbQ+4iYNLRU4Uf4F0P +3ucBBf1fNG7eISZ82UBVpxEdLTvadRmdGCiuGwgp/kXl6xNVO1/wmOVgQPXyemUEW4MpW2vgIO iXkah5AVlzm1O7P68TsOL+H2s8n6EiOHwwX9jbeMg9pirZiKqn+B6BYc4po01fLQa+yY= X-Gm-Gg: AZuq6aJ0ZiaDbaxxXjAlk1dN0bPmca9X/5aK+LKtxTqgnXa8HmLR7foOjkVrdpPcaiT E9Z5H6Ln97uB8zpm8YV77DKOEJ2oxXm6PD3Jc2g7HS2TC2VmnM0+VzEPyWllscJ+Gbz8wszmvQy +M5qPfnY8nripzPGDfw+xIvwZp5giUNIrMTDMCtTIBV/fkn4FBstGHTtccXtc4issZysR4QmpJI 5dYShpD3dNmC+S+QvdvbeydO5y84H2g+Vf8OvI91OBGkb+fMf4zERRjop7BwNoe6+6vtsuBz1KK MtplaeokasyI+3CmbZawFFgZPvMdIjfJXktFpjSN/tUJ3I4QRFioCbZZpsBbXV6/JzRbAf4/bJl gUidDB80mPVirLF5ipwepn+OydOSNtN+9AQ1yKkk= X-Received: by 2002:a05:6a20:3d84:b0:34f:ec32:6a3c with SMTP id adf61e73a8af0-38ec62de194mr146425637.28.1769483009945; Mon, 26 Jan 2026 19:03:29 -0800 (PST) X-Received: by 2002:a05:6a20:3d84:b0:34f:ec32:6a3c with SMTP id adf61e73a8af0-38ec62de194mr146380637.28.1769483009319; Mon, 26 Jan 2026 19:03:29 -0800 (PST) Received: from [10.239.133.242] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a425254sm9558200a12.29.2026.01.26.19.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 19:03:28 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 10:50:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 7/7] qcom-tgu: Add reset node to initialize To: Konrad Dybcio , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-8-songwei.chai@oss.qualcomm.com> <7dd40fb6-38a7-4e29-823b-5c0b2c66e3df@oss.qualcomm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: <7dd40fb6-38a7-4e29-823b-5c0b2c66e3df@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDAyNCBTYWx0ZWRfX40c3IKn30ai3 7jVh03b1n18Er+KVfJIp1PozjO+005k/7Fvm/tCxNhQF509RKavabT7dhiMtU6IkCum4HniiylD f/N2LpmxF3Bn5q1umh5jg7VkFifrj28IZWIsP2YeKSZ93A0QTT1T5v8s/aK7jvlemVrOwUlCZkt 9ZtoCFsqtYKWClJFF3BuvjMefPbS0N4FTpb2o5bQlDiBCypLb1Mxl/3oFq5bAZYlemsTJ6yGfTN AxV4lzDKsxf7qFfx5qRT6SXlwJHho57Y53xqEjnng3IqdM8dK1nFWG13JQN1PJFJUeg81dStWL6 AtGTuMba+tPFJPcYWeG+AZgCj1Q+cHnjrWEq16jHH/jzBzrflgZB3wMSKif2Q/Qukv9F7AWtZYs vtBb+HCVgDU6HZNC84H+6kUcv9ynDsFou+jMszW6WNIV0EYYxPsDVk3gYcfPpdgskMpaMw1aaUU 1Fetc+WVaRPu4MDcW4g== X-Proofpoint-ORIG-GUID: m27IHH3O1uPmX-YZ7cEjcQuMFWksio1h X-Proofpoint-GUID: m27IHH3O1uPmX-YZ7cEjcQuMFWksio1h X-Authority-Analysis: v=2.4 cv=a6k9NESF c=1 sm=1 tr=0 ts=69782b02 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aDFzzllK5DXHcxDTN8AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_01,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270024 On 1/13/2026 7:22 PM, Konrad Dybcio wrote: > On 1/9/26 3:11 AM, Songwei Chai wrote: >> Add reset node to initialize the value of >> priority/condition_decode/condition_select/timer/counter nodes. >> >> Signed-off-by: Songwei Chai >> --- > > [...] > >> +/* reset_tgu_store - Reset Trace and Gating Unit (TGU) configuration. */ >> +static ssize_t reset_tgu_store(struct device *dev, >> + struct device_attribute *attr, const char *buf, >> + size_t size) >> +{ >> + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); >> + unsigned long value; >> + int i, j, ret; >> + >> + if (kstrtoul(buf, 0, &value) || value == 0) >> + return -EINVAL; > > Your documentation blurb promises that only 1 is accepted, but this is not > the case. I think the previous additions had a similar flaw I’ll fix this to only accept 1 and review the previous additions for similar issues. > >> + >> + if (!drvdata->enable) { > > I think this check needs to be made under a lock, otherwise something else > may pull the plug inbetween Will move "guard(spinlock)(&drvdata->lock);" before "drvdata->enable" check. > >> + ret = pm_runtime_get_sync(drvdata->dev); >> + if (ret < 0) { >> + pm_runtime_put(drvdata->dev); >> + return ret; >> + } >> + } >> + >> + guard(spinlock)(&drvdata->lock); >> + TGU_UNLOCK(drvdata->base); >> + >> + writel(0, drvdata->base + TGU_CONTROL); >> + >> + TGU_LOCK(drvdata->base); > > This is tgu_disable() will use tgu_disable instead. > >> + >> + if (drvdata->value_table->priority) >> + memset(drvdata->value_table->priority, 0, >> + MAX_PRIORITY * drvdata->max_step * >> + drvdata->max_reg * sizeof(unsigned int)); >> + >> + if (drvdata->value_table->condition_decode) >> + memset(drvdata->value_table->condition_decode, 0, >> + drvdata->max_condition_decode * drvdata->max_step * >> + sizeof(unsigned int)); >> + >> + /* Initialize all condition registers to NOT(value=0x1000000) */ > > One \t too much will update. > >> + for (i = 0; i < drvdata->max_step; i++) { >> + for (j = 0; j < drvdata->max_condition_decode; j++) { >> + drvdata->value_table >> + ->condition_decode[calculate_array_location( >> + drvdata, i, TGU_CONDITION_DECODE, j)] = >> + 0x1000000; > > This is unreadable, take a pointer to condition_decode[] sure. > >> + } >> + } >> + >> + if (drvdata->value_table->condition_select) >> + memset(drvdata->value_table->condition_select, 0, >> + drvdata->max_condition_select * drvdata->max_step * >> + sizeof(unsigned int)); >> + >> + if (drvdata->value_table->timer) >> + memset(drvdata->value_table->timer, 0, >> + (drvdata->max_step) * >> + (drvdata->max_timer) * >> + sizeof(unsigned int)); >> + >> + if (drvdata->value_table->counter) >> + memset(drvdata->value_table->counter, 0, >> + (drvdata->max_step) * >> + (drvdata->max_counter) * >> + sizeof(unsigned int)); > > This is similarly difficult to read with almost random indentation > I agree, the indentation hurts readability. I’ll rework this to make the expression clearer. > Konrad