mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Wu <michael@allwinnertech.com>
To: Bart Van Assche <bvanassche@acm.org>,
	jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: core: Fix block I/O error of USB card reader during resume
Date: Mon, 29 Aug 2022 17:06:44 +0800	[thread overview]
Message-ID: <e69414ae-3181-5c33-d625-f30867869836@allwinnertech.com> (raw)
In-Reply-To: <5ba28a61-0aa2-14d7-61f0-0e9316844f70@acm.org>

On 8/27/2022 6:05 AM, Bart Van Assche wrote:
> On 8/23/22 03:16, Michael Wu wrote:
>> Yes... My patch did seem suspicious. Here's the scene about the block 
>> I/O error: Some card reader does not respond the command 'MEDIUM 
>> REMOVAL PREVENT' correctly, as a result, the host does not send 
>> subsequent cmd 'MEDIUM REMOVAL ALLOW'/'MEDIUM REMOVAL PREVENT' 
>> before/after sleep, which leads to a enumeration failure after system 
>> resume.
>> I wonder, without changing the behavior of the device, is there's a 
>> better way to solve this? -- Modifying the scsi core should not be a 
>> good idea though :(
> 
> The above is not clear to me. My understanding is that "MEDIUM REMOVAL 
> PREVENT" is a sense code instead of a SCSI command?
> 
>> Thanks for your kindly notice. I looked around in the latest linux 
>> mainline repo, but could not find this code. Where can I get this 2002 
>> version of scsi_lib.c? Thank you.
> 
> Please take a look at 
> https://stackoverflow.com/questions/3264283/linux-kernel-historical-git-repository-with-full-history. 
> That web page has instructions for how to configure a git repository 
> such that history goes back before the time when Linus started using git.
> 
> Bart.
> 
Dear Bart,
Thank you. I'll try to figure it out and sync to you later.

-- 
Regards,
Michael Wu

      reply	other threads:[~2022-08-29  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  8:34 Michael Wu
2022-08-17 13:52 ` Bart Van Assche
2022-08-23 10:16   ` Michael Wu
2022-08-26 22:05     ` Bart Van Assche
2022-08-29  9:06       ` Michael Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e69414ae-3181-5c33-d625-f30867869836@allwinnertech.com \
    --to=michael@allwinnertech.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®