From: Sinan Kaya <okaya@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
sumeet.r.pawnikar@intel.com, Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset
Date: Sun, 23 Dec 2018 23:23:24 +0100 [thread overview]
Message-ID: <e695ac50-0e7c-6cc4-5f63-42c842787fd7@kernel.org> (raw)
In-Reply-To: <CAJZ5v0j6Z42pk16fFGpQz+xvU-gVnarkoafcWJuQPWY=X532YQ@mail.gmail.com>
On 12/23/2018 10:48 PM, Rafael J. Wysocki wrote:
> Can you actually test this driver with your new #ifdef stuff and with
> CONFIG_PCI unset?
>
> Have you really test it in that configuration?
>
No, I haven't. Code was compile tested only.
> If not, you shouldn't even post this patch.
>
I was hoping the maintainer to chime in. By looking at the code, it was
registering a platform and PCI driver. I assumed that it was generic code
that can be used with and without PCI.
> Please make the driver depend on PCI.
I can do that.
next prev parent reply other threads:[~2018-12-23 22:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181222090720.19234-1-okaya@kernel.org>
2018-12-22 9:07 ` [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
2018-12-23 21:45 ` Rafael J. Wysocki
2018-12-23 22:21 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-22 16:40 ` Lukas Wunner
2018-12-22 23:00 ` Sinan Kaya
2018-12-23 17:15 ` Lukas Wunner
2018-12-23 23:13 ` Sinan Kaya
2018-12-24 9:27 ` Daniel Vetter
2018-12-22 9:07 ` [PATCH v2 04/11] platform/x86: " Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 06/11] apple-gmux: Make PCI dependency explicit Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
2018-12-23 21:48 ` Rafael J. Wysocki
2018-12-23 22:23 ` Sinan Kaya [this message]
2018-12-22 9:07 ` [PATCH v2 08/11] ASoC: Intel: Make PCI dependency explicit Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 11/11] drivers: thermal: Make PCI dependency explicit Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e695ac50-0e7c-6cc4-5f63-42c842787fd7@kernel.org \
--to=okaya@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sumeet.r.pawnikar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®