From: Andrei-Alexandru Bleortu <me@andrei-z.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@nbd.name>
Subject: [PATCH wireless-next 2/2] wifi: mac80211: keep the BSS color while a color change is pending
Date: Sun, 4 Oct 2026 14:14:50 +0300 [thread overview]
Message-ID: <e696e399eee2f42c2907c45c85aa894705bee1bf.1791111135.git.me@andrei-z.com> (raw)
In-Reply-To: <cover.1791111135.1.git.me@andrei-z.com>
When a BSS color change starts, mac80211 tells the driver that the BSS
color is disabled, as the Beacon frames say during the countdown, but it
also sets the color to 0. While the BSS Color Disabled subfield is 1, an
HE STA shall keep using its nonzero color, the one it used before, in the
BSS_COLOR of the HE PPDUs it transmits (IEEE Std 802.11-2024, 26.11.4),
and a driver can only do so if it still knows the color.
Keep the current color and only clear enabled.
Assisted-by: LLM
Signed-off-by: Andrei-Alexandru Bleortu <me@andrei-z.com>
---
net/mac80211/cfg.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 28f99a8f8a..e68edf833f 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -5807,8 +5807,13 @@ ieee80211_color_change(struct wiphy *wiphy, struct net_device *dev,
cfg80211_color_change_started_notify(sdata->dev, params->count, link_id);
+ /* While the color is disabled, the BSS keeps using its current color
+ * (IEEE Std 802.11-2024, 26.11.4)
+ */
if (changed)
- ieee80211_color_change_bss_config_notify(link, 0, 0, changed);
+ ieee80211_color_change_bss_config_notify(link,
+ link_conf->he_bss_color.color,
+ 0, changed);
else
/* if the beacon didn't change, we can finalize immediately */
ieee80211_color_change_finalize(link);
--
2.47.3
prev parent reply other threads:[~2026-10-04 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 11:14 [PATCH wireless-next 0/2] wifi: mac80211: airtime weight op, BSS color during a color change Andrei-Alexandru Bleortu
2026-10-04 11:14 ` [PATCH wireless-next 1/2] wifi: mac80211: notify driver on airtime weight changes Andrei-Alexandru Bleortu
2026-10-04 11:14 ` Andrei-Alexandru Bleortu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e696e399eee2f42c2907c45c85aa894705bee1bf.1791111135.git.me@andrei-z.com \
--to=me@andrei-z.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®