From: Guenter Roeck <linux@roeck-us.net>
To: Balakrishnan Sambath <balakrishnan.s@microchip.com>,
wim@linux-watchdog.org
Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] watchdog: at91/sama5d4: header cleanup and driver refactor
Date: Thu, 26 Feb 2026 23:44:04 -0800 [thread overview]
Message-ID: <e69972db-20c3-4ce7-ad12-bb91a8eadfb2@roeck-us.net> (raw)
In-Reply-To: <20260227073116.30447-1-balakrishnan.s@microchip.com>
On 2/26/26 23:31, Balakrishnan Sambath wrote:
> This series cleans up the AT91 watchdog header and refactors the
> sama5d4 watchdog driver.
>
> The header reorganization introduces consistent register naming and
> makes the WDDIS bit handling explicit for modern (SAM9X60, SAMA7G5,
> SAM9X7) and legacy (SAMA5, AT91SAM9261) SoCs. The driver refactor
> improves readability and fixes the reset regression introduced by
> commit 266da53c35fc ("watchdog: sama5d4: readout initial state").
>
That is inappropriate as a bug fix. Ther bug fix should come first,
in a form that can be backported, followed by an optional cleanup.
Guenter
> Andrei Simion (2):
> watchdog: at91sam9_wdt.h: Cleanup the header file
> watchdog: sama5d4_wdt: Refactor the driver
>
> Balakrishnan Sambath (1):
> watchdog: at91sam9_wdt: Rename AT91_WDT_WDDIS to AT91_WDT_WDDIS_LEGACY
>
> drivers/watchdog/at91sam9_wdt.c | 8 +-
> drivers/watchdog/at91sam9_wdt.h | 65 +++++++------
> drivers/watchdog/sama5d4_wdt.c | 156 ++++++++++++++++----------------
> 3 files changed, 113 insertions(+), 116 deletions(-)
>
next prev parent reply other threads:[~2026-02-27 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:31 Balakrishnan Sambath
2026-02-27 7:31 ` [PATCH 1/3] watchdog: at91sam9_wdt.h: Cleanup the header file Balakrishnan Sambath
2026-02-27 7:52 ` Alexandre Belloni
2026-03-02 7:11 ` Balakrishnan.S
2026-02-27 7:31 ` [PATCH 2/3] watchdog: sama5d4_wdt: Refactor the driver Balakrishnan Sambath
2026-02-27 8:05 ` Alexandre Belloni
2026-03-02 7:24 ` Balakrishnan.S
2026-02-27 7:31 ` [PATCH 3/3] watchdog: at91sam9_wdt: Rename AT91_WDT_WDDIS to AT91_WDT_WDDIS_LEGACY Balakrishnan Sambath
2026-02-27 7:44 ` Guenter Roeck [this message]
2026-03-02 7:26 ` [PATCH 0/3] watchdog: at91/sama5d4: header cleanup and driver refactor Balakrishnan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69972db-20c3-4ce7-ad12-bb91a8eadfb2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.belloni@bootlin.com \
--cc=balakrishnan.s@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®