From: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <broonie@kernel.org>,
<vkoul@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>
Cc: <quic_msavaliy@quicinc.com>, <dianders@chromium.org>,
<mka@chromium.org>, <swboyd@chromium.org>,
<quic_vtanuku@quicinc.com>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7280: Add stream-id of qspi to iommus
Date: Wed, 12 Apr 2023 20:58:23 +0530 [thread overview]
Message-ID: <e69c570d-71e3-2e52-698a-52ea44ec47f7@quicinc.com> (raw)
In-Reply-To: <86449ddc-1eeb-5af0-dfaf-0b80e7d8d992@linaro.org>
Thank you very much for the review...
On 4/4/2023 11:49 PM, Krzysztof Kozlowski wrote:
> On 04/04/2023 20:03, Vijaya Krishna Nivarthi wrote:
>> This is done as part of adding DMA support to qspi driver.
>>
>> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 5e6f9f4..9e05285 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -3434,6 +3434,7 @@
>> qspi: spi@88dc000 {
>> compatible = "qcom,sc7280-qspi", "qcom,qspi-v1";
>> reg = <0 0x088dc000 0 0x1000>;
>> + iommus = <&apps_smmu 0x20 0x0>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
Added changes to yaml file, ran the check and ensured it builds fine.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-04-12 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 18:03 [PATCH 0/2] spi: Add DMA mode support to spi-qcom-qspi Vijaya Krishna Nivarthi
2023-04-04 18:03 ` [PATCH 1/2] arm64: dts: qcom: sc7280: Add stream-id of qspi to iommus Vijaya Krishna Nivarthi
2023-04-04 18:19 ` Krzysztof Kozlowski
2023-04-12 15:28 ` Vijaya Krishna Nivarthi [this message]
2023-04-04 18:03 ` [PATCH 2/2] spi: spi-qcom-qspi: Add DMA mode support Vijaya Krishna Nivarthi
2023-04-04 18:17 ` Mark Brown
2023-04-06 14:53 ` Vijaya Krishna Nivarthi
2023-04-06 15:28 ` Mark Brown
2023-04-12 15:29 ` Vijaya Krishna Nivarthi
2023-04-12 16:12 ` Mark Brown
2023-04-12 17:27 ` Vijaya Krishna Nivarthi
2023-04-04 20:45 ` Stephen Boyd
2023-04-12 15:28 ` Vijaya Krishna Nivarthi
2023-04-04 22:05 ` kernel test robot
2023-04-04 20:30 ` [PATCH 0/2] spi: Add DMA mode support to spi-qcom-qspi Stephen Boyd
2023-04-12 15:28 ` Vijaya Krishna Nivarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69c570d-71e3-2e52-698a-52ea44ec47f7@quicinc.com \
--to=quic_vnivarth@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®