From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB8D6A8BE; Tue, 20 Feb 2024 13:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437343; cv=none; b=Tcvn29yFc58j33bsFoLitcz2SalcbtN6tvUlVyyHuzyDRZJV1GMOEN7qdjU1ATHOr3I7YQ6aabtDv0XWm/sZCBzMDdqQkaNksbHWdv5jPy6GUy++Bid0dvzp2hI7KvxSCoU3EtIQe8GVjeeaX3iJ5e5YXCXYXM6uFauc7bIwlu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437343; c=relaxed/simple; bh=JDNYKCX7Gnczf5JaEMRjWQJZmqZ/a75WvEM0QMCpONE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=g3T9+BUKg4j7lRd+ucPS5DJEs3DPu1MAEjNkQh/AFo43pahQVvsPKxZdukrdW30y5kLXRONMUSlEVG0rbJJNJw5wkOplBLUc1twlxSkZ1CvLok6uP5BZz6XmHR32hmSHTtHVg8lxNB+shqfsnixuA6LqYbFt/mqnRfEmQ8srgTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=PaoKjvW1; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PaoKjvW1" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 41KDtar5080825; Tue, 20 Feb 2024 07:55:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1708437336; bh=9L1rHmMmIbC6TlVE2ZEhGXvsFuBdWXewTcaJYFPLP8s=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=PaoKjvW1d65Ua54jd+7gp9MI+PwmvxH6+/LRrgLSp5CsHECnRbyQXJAKYubOIfjzu vJ3pqT47ELcOj4NP2YM3FRc+ENFyfq+oK7QeEBAfP6iHxpo3QLWQaaSEnh0INkSfh4 QTEzZCLi9yUFfmrthq9YAgptOx8KfWtOvUle3vxw= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 41KDtaAo008926 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Feb 2024 07:55:36 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Feb 2024 07:55:36 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Feb 2024 07:55:36 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 41KDtav0087390; Tue, 20 Feb 2024 07:55:36 -0600 Message-ID: Date: Tue, 20 Feb 2024 07:55:35 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] power: reset: xgene-reboot: Fix a NULL vs IS_ERR() test To: Dan Carpenter CC: Sebastian Reichel , , , References: Content-Language: en-US From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 2/20/24 3:02 AM, Dan Carpenter wrote: > The devm_platform_ioremap_resource() function returns error points. It > never returns NULL. Update the check accordingly. > > Fixes: 7ddfd33c6ee5 ("power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper") > Signed-off-by: Dan Carpenter > --- Acked-by: Andrew Davis > drivers/power/reset/xgene-reboot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/reset/xgene-reboot.c b/drivers/power/reset/xgene-reboot.c > index 867162dfe7ea..b5eee19bac42 100644 > --- a/drivers/power/reset/xgene-reboot.c > +++ b/drivers/power/reset/xgene-reboot.c > @@ -51,9 +51,9 @@ static int xgene_reboot_probe(struct platform_device *pdev) > return -ENOMEM; > > ctx->csr = devm_platform_ioremap_resource(pdev, 0); > - if (!ctx->csr) { > + if (IS_ERR(ctx->csr)) { > dev_err(dev, "can not map resource\n"); > - return -ENODEV; > + return PTR_ERR(ctx->csr); > } > > if (of_property_read_u32(dev->of_node, "mask", &ctx->mask))