From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id A29B0C433EF for ; Tue, 12 Jun 2018 13:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58D012089C for ; Tue, 12 Jun 2018 13:31:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D012089C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933583AbeFLNbw (ORCPT ); Tue, 12 Jun 2018 09:31:52 -0400 Received: from icp-osb-irony-out4.external.iinet.net.au ([203.59.1.220]:24943 "EHLO icp-osb-irony-out4.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932749AbeFLNbu (ORCPT ); Tue, 12 Jun 2018 09:31:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AOAQDmyR9b/zSOqnwNTxoBAQEBAQIBA?= =?us-ascii?q?QEBCAEBAQGFTIN3lTEBAQEBAQEGgQUpllOEdwKCUjgUAQIBAQEBAQEChj4BAQE?= =?us-ascii?q?DIxVBEAsNCwICJgICVwYNBgIBAYMegXSpdW2CHBqEQINsgWiBC4hJgQeBDySCa?= =?us-ascii?q?IdzglUCmQYIAY5ziBqFHpMQgXMzGggoCIJ+kGFdkCoBAQ?= X-IPAS-Result: =?us-ascii?q?A2AOAQDmyR9b/zSOqnwNTxoBAQEBAQIBAQEBCAEBAQGFTIN?= =?us-ascii?q?3lTEBAQEBAQEGgQUpllOEdwKCUjgUAQIBAQEBAQEChj4BAQEDIxVBEAsNCwICJ?= =?us-ascii?q?gICVwYNBgIBAYMegXSpdW2CHBqEQINsgWiBC4hJgQeBDySCaIdzglUCmQYIAY5?= =?us-ascii?q?ziBqFHpMQgXMzGggoCIJ+kGFdkCoBAQ?= X-IronPort-AV: E=Sophos;i="5.51,214,1526313600"; d="scan'208";a="80706464" Received: from unknown (HELO [192.168.0.106]) ([124.170.142.52]) by icp-osb-irony-out4.iinet.net.au with ESMTP; 12 Jun 2018 21:31:17 +0800 Subject: Re: [PATCH 1/3] m68k: coldfire: Normalize clk API To: Geert Uytterhoeven Cc: Ralf Baechle , James Hogan , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Corentin Labbe , "David S. Miller" , Arnd Bergmann , linux-m68k , Linux MIPS Mailing List , netdev , Linux Kernel Mailing List References: <1528706663-20670-1-git-send-email-geert@linux-m68k.org> <1528706663-20670-2-git-send-email-geert@linux-m68k.org> <944b08ba-a882-e6cd-42fa-9251bce1d7b1@linux-m68k.org> From: Greg Ungerer Message-ID: Date: Tue, 12 Jun 2018 23:31:12 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 12/06/18 17:31, Geert Uytterhoeven wrote: > On Tue, Jun 12, 2018 at 9:27 AM Greg Ungerer wrote: >> On 11/06/18 18:44, Geert Uytterhoeven wrote: >>> Coldfire still provides its own variant of the clk API rather than using >>> the generic COMMON_CLK API. This generally works, but it causes some >>> link errors with drivers using the clk_round_rate(), clk_set_rate(), >>> clk_set_parent(), or clk_get_parent() functions when a platform lacks >>> those interfaces. >>> >>> This adds empty stub implementations for each of them, and I don't even >>> try to do something useful here but instead just print a WARN() message >>> to make it obvious what is going on if they ever end up being called. >>> >>> The drivers that call these won't be used on these platforms (otherwise >>> we'd get a link error today), so the added code is harmless bloat and >>> will warn about accidental use. >>> >>> Based on commit bd7fefe1f06ca6cc ("ARM: w90x900: normalize clk API"). >>> >>> Signed-off-by: Geert Uytterhoeven >> >> I am fine with this for ColdFire, so >> >> Acked-by: Greg Ungerer > > Thanks! > >> Are you going to take this/these via your m68k git tree? > > I''m fine delagating this to you. No problem. I'll add it to the m68knommu git tree (for-next branch) when the merge window closes. Thanks Greg